[PATCH v2] drm/tests/buddy: fix build with unused prng

[PATCH v2] drm/tests/buddy: fix build with unused prng

[Matthew Auld]

We no longer use the prng, which leads to the following warning:

drivers/gpu/drm/tests/drm_buddy_test.c: In function
‘drm_test_buddy_alloc_clear’:
drivers/gpu/drm/tests/drm_buddy_test.c:264:23: error: unused variable
‘prng’ [-Werror=unused-variable]
  264 |         DRM_RND_STATE(prng, random_seed);

v2 (Thomas)
 - Add Closes links

Reported-by: Jani Nikula <jani.nikula@intel.com>
Closes: https://lore.kernel.org/dri-devel/875xmggvcs.fsf@intel.com/
Reported-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Closes: https://lore.kernel.org/dri-devel/3f816555e6913fdbcb254523f65c98088d70581b.camel@intel.com/
Fixes: 8cb3a1e2b350 ("drm/buddy: Add a testcase to verify the multiroot fini")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/tests/drm_buddy_test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
index 4b5818f9f2a9..7a0e523651f0 100644
--- a/drivers/gpu/drm/tests/drm_buddy_test.c
+++ b/drivers/gpu/drm/tests/drm_buddy_test.c
@@ -261,7 +261,6 @@ static void drm_test_buddy_alloc_range_bias(struct kunit *test)
 static void drm_test_buddy_alloc_clear(struct kunit *test)
 {
 	unsigned long n_pages, total, i = 0;
-	DRM_RND_STATE(prng, random_seed);
 	const unsigned long ps = SZ_4K;
 	struct drm_buddy_block *block;
 	const int max_order = 12;
-- 
2.47.1

Re: [PATCH v2] drm/tests/buddy: fix build with unused prng

[Paneer Selvam, Arunpravin]

Thank you, I was going to send this patch out.

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>

@Jani, Thomas - Are you planning to merge this patch into drm-misc-next 
and try re-building drm-tip?

Regards,
Arun.


On 1/15/2025 6:19 PM, Matthew Auld wrote:
> We no longer use the prng, which leads to the following warning:
>
> drivers/gpu/drm/tests/drm_buddy_test.c: In function
> ‘drm_test_buddy_alloc_clear’:
> drivers/gpu/drm/tests/drm_buddy_test.c:264:23: error: unused variable
> ‘prng’ [-Werror=unused-variable]
>    264 |         DRM_RND_STATE(prng, random_seed);
>
> v2 (Thomas)
>   - Add Closes links
>
> Reported-by: Jani Nikula <jani.nikula@intel.com>
> Closes: https://lore.kernel.org/dri-devel/875xmggvcs.fsf@intel.com/
> Reported-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Closes: https://lore.kernel.org/dri-devel/3f816555e6913fdbcb254523f65c98088d70581b.camel@intel.com/
> Fixes: 8cb3a1e2b350 ("drm/buddy: Add a testcase to verify the multiroot fini")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
>   drivers/gpu/drm/tests/drm_buddy_test.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 4b5818f9f2a9..7a0e523651f0 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -261,7 +261,6 @@ static void drm_test_buddy_alloc_range_bias(struct kunit *test)
>   static void drm_test_buddy_alloc_clear(struct kunit *test)
>   {
>   	unsigned long n_pages, total, i = 0;
> -	DRM_RND_STATE(prng, random_seed);
>   	const unsigned long ps = SZ_4K;
>   	struct drm_buddy_block *block;
>   	const int max_order = 12;