From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Marco Patalano <mpatalan@redhat.com>,
Ewan Milne <emilne@redhat.com>,
James Smart <james.smart@broadcom.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [RFC PATCH] nvme-fc: move tagset removal to nvme_fc_delete_ctrl()
Date: Thu, 16 Jan 2025 07:10:04 +0100 [thread overview]
Message-ID: <20250116061004.GA25010@lst.de> (raw)
In-Reply-To: <20250113124446.830697-1-ming.lei@redhat.com>
On Mon, Jan 13, 2025 at 08:44:46PM +0800, Ming Lei wrote:
> Now target is removed from nvme_fc_ctrl_free() which is the ctrl->ref
> release handler. And even admin queue is unquiesced there, this way
> is definitely wrong because the ctr->ref is grabbed when submitting
> command.
>
> And Marco observed that nvme_fc_ctrl_free() can be called from request
> completion code path, and trigger kernel warning since request completes
> from softirq context.
>
> Fix the issue by moveing target removal into nvme_fc_delete_ctrl(),
> which is also aligned with nvme-tcp and nvme-rdma.
>
Yeah, the current placement is wrong. Can I talk someone to make
the whole setup/teardown process in nvme-fc match that of the other
fabrics (and slightly less so PCIe) order? I know a long time ago
Sagi was atually looking into sharing more code as well, but that
would be a next step.
But I'd really like to have one known working sequence instead
of various different ones.
next prev parent reply other threads:[~2025-01-16 6:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 12:44 [RFC PATCH] nvme-fc: move tagset removal to nvme_fc_delete_ctrl() Ming Lei
2025-01-14 17:06 ` Ewan Milne
2025-01-14 18:31 ` Ewan Milne
2025-01-15 17:33 ` Ewan Milne
2025-01-16 1:57 ` Ming Lei
2025-01-17 22:03 ` Ewan Milne
2025-01-16 6:10 ` Christoph Hellwig [this message]
2025-01-17 22:06 ` Ewan Milne
2025-01-20 13:51 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116061004.GA25010@lst.de \
--to=hch@lst.de \
--cc=emilne@redhat.com \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=mpatalan@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.