All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Ewan Milne <emilne@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org,
	Marco Patalano <mpatalan@redhat.com>,
	James Smart <james.smart@broadcom.com>,
	Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [RFC PATCH] nvme-fc: move tagset removal to nvme_fc_delete_ctrl()
Date: Thu, 16 Jan 2025 09:57:17 +0800	[thread overview]
Message-ID: <Z4hnfSFc1hobsN7g@fedora> (raw)
In-Reply-To: <CAGtn9rn=rUsaOACWyOLAx2=E++WvStwtQwyXZR=kxYmuCQQ0_A@mail.gmail.com>

Hi Ewan,

On Wed, Jan 15, 2025 at 12:33:50PM -0500, Ewan Milne wrote:
> Moving the tagset removal to the end of nvme_fc_delete_ctrl() ran OK and we
> no longer see the WARN_ON() seen earlier, however I think that there is a
> potential problem with doing this because the keepalive is not stopped until
> nvme_uninit_ctrl() is called.  On our systems w/FC kato is normally disabled
> so we wouldn't see any problem but this isn't true in the general case.

Please see e9869c85c811 ("nvme-fabrics: fix kernel crash while shutting down controller")
which stops the keepalive request at the entry of
nvme_remove_admin_tag_set().

So your above concern shouldn't exist.

Thanks,
Ming



  reply	other threads:[~2025-01-16  1:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13 12:44 [RFC PATCH] nvme-fc: move tagset removal to nvme_fc_delete_ctrl() Ming Lei
2025-01-14 17:06 ` Ewan Milne
2025-01-14 18:31   ` Ewan Milne
2025-01-15 17:33     ` Ewan Milne
2025-01-16  1:57       ` Ming Lei [this message]
2025-01-17 22:03         ` Ewan Milne
2025-01-16  6:10 ` Christoph Hellwig
2025-01-17 22:06   ` Ewan Milne
2025-01-20 13:51 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4hnfSFc1hobsN7g@fedora \
    --to=ming.lei@redhat.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mpatalan@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.