All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: Daniel Scally <djrscally@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH 2/2] media: i2c: ov7251: Introduce 1 ms delay between regulators and en GPIO
Date: Mon, 20 Jan 2025 12:11:23 +0200	[thread overview]
Message-ID: <20250120101123.148482-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250120101123.148482-1-sakari.ailus@linux.intel.com>

Lift the xshutdown (enable) GPIO 1 ms after enabling the regulators, as
required by the sensor's power-up sequence.

Fixes: d30bb512da3d ("media: Add a driver for the ov7251 camera sensor")
Cc: stable@vger.kernel.org
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/ov7251.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c
index f3e2d26bb840..3226888d77e9 100644
--- a/drivers/media/i2c/ov7251.c
+++ b/drivers/media/i2c/ov7251.c
@@ -922,6 +922,8 @@ static int ov7251_set_power_on(struct device *dev)
 		return ret;
 	}
 
+	usleep_range(1000, 1100);
+
 	gpiod_set_value_cansleep(ov7251->enable_gpio, 1);
 
 	/* wait at least 65536 external clock cycles */
-- 
2.39.5


  reply	other threads:[~2025-01-20 10:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 10:11 [PATCH 1/2] media: i2c: ov7251: Set enable GPIO low in probe Sakari Ailus
2025-01-20 10:11 ` Sakari Ailus [this message]
2025-01-20 10:39   ` [PATCH 2/2] media: i2c: ov7251: Introduce 1 ms delay between regulators and en GPIO Dave Stevenson
2025-01-20 17:23   ` Andy Shevchenko
2025-01-22 11:54     ` Sakari Ailus
2025-01-22 16:36       ` Andy Shevchenko
2025-01-23  7:33         ` Sakari Ailus
2025-01-23 13:25           ` Andy Shevchenko
2025-01-20 10:37 ` [PATCH 1/2] media: i2c: ov7251: Set enable GPIO low in probe Dave Stevenson
2025-01-20 17:24 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120101123.148482-2-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.