From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/2] media: i2c: ov7251: Set enable GPIO low in probe
Date: Mon, 20 Jan 2025 19:24:24 +0200 [thread overview]
Message-ID: <Z46GyGL2K5s7Rw3d@smile.fi.intel.com> (raw)
In-Reply-To: <20250120101123.148482-1-sakari.ailus@linux.intel.com>
On Mon, Jan 20, 2025 at 12:11:22PM +0200, Sakari Ailus wrote:
> Set the enable GPIO low when acquiring it.
...
> - ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH);
> + ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
Fine with me, but it's not helpful for MS Surface family of the devices anyway.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-01-20 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 10:11 [PATCH 1/2] media: i2c: ov7251: Set enable GPIO low in probe Sakari Ailus
2025-01-20 10:11 ` [PATCH 2/2] media: i2c: ov7251: Introduce 1 ms delay between regulators and en GPIO Sakari Ailus
2025-01-20 10:39 ` Dave Stevenson
2025-01-20 17:23 ` Andy Shevchenko
2025-01-22 11:54 ` Sakari Ailus
2025-01-22 16:36 ` Andy Shevchenko
2025-01-23 7:33 ` Sakari Ailus
2025-01-23 13:25 ` Andy Shevchenko
2025-01-20 10:37 ` [PATCH 1/2] media: i2c: ov7251: Set enable GPIO low in probe Dave Stevenson
2025-01-20 17:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z46GyGL2K5s7Rw3d@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.