[sj:damon/next 45/45] mm/damon/paddr.c:316:30: warning: variable 'last_addr' set but not used

[sj:damon/next 45/45] mm/damon/paddr.c:316:30: warning: variable 'last_addr' set but not used

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   38bf43ccce488ca872dbc52673c7a2223fb13598
commit: 38bf43ccce488ca872dbc52673c7a2223fb13598 [45/45] mm/damon/paddr: implement a DAMON operations set for cache address space
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250119/202501191712.rj88Gj15-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250119/202501191712.rj88Gj15-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501191712.rj88Gj15-lkp@intel.com/

All warnings (new ones prefixed by >>):

   mm/damon/paddr.c: In function '__damon_ca_check_access':
>> mm/damon/paddr.c:316:30: warning: variable 'last_addr' set but not used [-Wunused-but-set-variable]
     316 |         static unsigned long last_addr;
         |                              ^~~~~~~~~


vim +/last_addr +316 mm/damon/paddr.c

   309	
   310	/* caddr's access check can reuse almost every pa's access check logic, since
   311	 * r->sampling_addr is a physical address */
   312	
   313	static void __damon_ca_check_access(struct damon_region *r,
   314			struct damon_attrs *attrs)
   315	{
 > 316		static unsigned long last_addr;
   317		static unsigned long last_folio_sz = PAGE_SIZE;
   318		static bool last_accessed;
   319	
   320		last_accessed = damon_pa_young(r->sampling_addr, &last_folio_sz);
   321		damon_update_region_access_rate(r, last_accessed, attrs);
   322	
   323		last_addr = r->sampling_addr;
   324	}
   325	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [sj:damon/next 45/45] mm/damon/paddr.c:316:30: warning: variable 'last_addr' set but not used

[SeongJae Park]

On Sun, 19 Jan 2025 17:35:50 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   38bf43ccce488ca872dbc52673c7a2223fb13598
> commit: 38bf43ccce488ca872dbc52673c7a2223fb13598 [45/45] mm/damon/paddr: implement a DAMON operations set for cache address space
> config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250119/202501191712.rj88Gj15-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250119/202501191712.rj88Gj15-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501191712.rj88Gj15-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    mm/damon/paddr.c: In function '__damon_ca_check_access':
> >> mm/damon/paddr.c:316:30: warning: variable 'last_addr' set but not used [-Wunused-but-set-variable]
>      316 |         static unsigned long last_addr;
>          |                              ^~~~~~~~~

Thank you always for nice reports!  Just pushed a fix:
https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=2e43bb84cc76ee5e1bc1000d161609ee4c279771


Thanks,
SJ

[...]