* [Buildroot] [PATCH] package/minisign: bump to version 0.12
@ 2025-01-21 3:14 patrick.oppenlander
2025-01-24 20:29 ` Julien Olivain
0 siblings, 1 reply; 5+ messages in thread
From: patrick.oppenlander @ 2025-01-21 3:14 UTC (permalink / raw)
To: buildroot; +Cc: Patrick Oppenlander
From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
package/minisign/minisign.hash | 2 +-
package/minisign/minisign.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/minisign/minisign.hash b/package/minisign/minisign.hash
index 12cde42a43..74941163e9 100644
--- a/package/minisign/minisign.hash
+++ b/package/minisign/minisign.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55 minisign-0.11.tar.gz
+sha256 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0 minisign-0.12.tar.gz
sha256 d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b LICENSE
diff --git a/package/minisign/minisign.mk b/package/minisign/minisign.mk
index 7cdce597f7..5cc8e14cba 100644
--- a/package/minisign/minisign.mk
+++ b/package/minisign/minisign.mk
@@ -4,7 +4,7 @@
#
################################################################################
-MINISIGN_VERSION = 0.11
+MINISIGN_VERSION = 0.12
MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION))
MINISIGN_LICENSE = ISC
MINISIGN_LICENSE_FILES = LICENSE
--
2.48.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/minisign: bump to version 0.12
2025-01-21 3:14 [Buildroot] [PATCH] package/minisign: bump to version 0.12 patrick.oppenlander
@ 2025-01-24 20:29 ` Julien Olivain
2025-01-27 4:42 ` Patrick Oppenlander
0 siblings, 1 reply; 5+ messages in thread
From: Julien Olivain @ 2025-01-24 20:29 UTC (permalink / raw)
To: patrick.oppenlander; +Cc: buildroot
Hi Patrick,
Thanks for the patch.
On 21/01/2025 04:14, patrick.oppenlander@gmail.com wrote:
> From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Could you add a link to the change log in the commit log, please?
Something like:
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Also, reading it, I see that the libsodium is now an optional
dependency.
Do you think it is worth reflecting this change in the Buildroot recipe?
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> ---
> package/minisign/minisign.hash | 2 +-
> package/minisign/minisign.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/minisign/minisign.hash
> b/package/minisign/minisign.hash
> index 12cde42a43..74941163e9 100644
> --- a/package/minisign/minisign.hash
> +++ b/package/minisign/minisign.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> -sha256
> 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55
> minisign-0.11.tar.gz
> +sha256
> 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0
> minisign-0.12.tar.gz
> sha256
> d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
> LICENSE
Running "make minisign-legal-info" fails with output:
>>> minisign 0.12 Collecting legal info
ERROR: while checking hashes from package/minisign/minisign.hash
ERROR: LICENSE has wrong sha256 hash:
ERROR: expected:
d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
ERROR: got :
01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
Could you check what has changed in the license (you can provide a link
to the
upstream commit change, or describe the change) and send an updated
version of
this patch?
Best reagrds,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/minisign: bump to version 0.12
2025-01-24 20:29 ` Julien Olivain
@ 2025-01-27 4:42 ` Patrick Oppenlander
2025-01-27 22:15 ` [Buildroot] [PATCH v2] " patrick.oppenlander
0 siblings, 1 reply; 5+ messages in thread
From: Patrick Oppenlander @ 2025-01-27 4:42 UTC (permalink / raw)
To: Julien Olivain; +Cc: buildroot
Hi Julien,
On Sat, 25 Jan 2025 at 07:29, Julien Olivain <ju.o@free.fr> wrote:
>
> Hi Patrick,
>
> Thanks for the patch.
Thanks for the review!
>
> On 21/01/2025 04:14, patrick.oppenlander@gmail.com wrote:
> > From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
>
> Could you add a link to the change log in the commit log, please?
> Something like:
>
> Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Will do.
> Also, reading it, I see that the libsodium is now an optional
> dependency.
> Do you think it is worth reflecting this change in the Buildroot recipe?
It's only optional if minisign is built with a zig toolchain.
Unfortunately it's not optional if using cmake.
> > Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> > ---
> > package/minisign/minisign.hash | 2 +-
> > package/minisign/minisign.mk | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/minisign/minisign.hash
> > b/package/minisign/minisign.hash
> > index 12cde42a43..74941163e9 100644
> > --- a/package/minisign/minisign.hash
> > +++ b/package/minisign/minisign.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > -sha256
> > 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55
> > minisign-0.11.tar.gz
> > +sha256
> > 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0
> > minisign-0.12.tar.gz
> > sha256
> > d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
> > LICENSE
>
> Running "make minisign-legal-info" fails with output:
>
> >>> minisign 0.12 Collecting legal info
> ERROR: while checking hashes from package/minisign/minisign.hash
> ERROR: LICENSE has wrong sha256 hash:
> ERROR: expected:
> d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
> ERROR: got :
> 01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
>
> Could you check what has changed in the license (you can provide a link
> to the
> upstream commit change, or describe the change) and send an updated
> version of
> this patch?
It's just a date change:
https://github.com/jedisct1/minisign/commit/12333fd7d11180e90a473331fcd628452af061ed
Sorry, I forgot about the `make xxx-legal-info` step.
>
> Best reagrds,
>
> Julien.
Patrick
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/minisign: bump to version 0.12
2025-01-27 4:42 ` Patrick Oppenlander
@ 2025-01-27 22:15 ` patrick.oppenlander
2025-01-27 23:32 ` Julien Olivain
0 siblings, 1 reply; 5+ messages in thread
From: patrick.oppenlander @ 2025-01-27 22:15 UTC (permalink / raw)
To: buildroot; +Cc: Patrick Oppenlander
From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Upstream license changed to include 2025 in copyright years.
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
package/minisign/minisign.hash | 4 ++--
package/minisign/minisign.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/minisign/minisign.hash b/package/minisign/minisign.hash
index 12cde42a43..e918891aa8 100644
--- a/package/minisign/minisign.hash
+++ b/package/minisign/minisign.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55 minisign-0.11.tar.gz
-sha256 d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b LICENSE
+sha256 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0 minisign-0.12.tar.gz
+sha256 01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd LICENSE
diff --git a/package/minisign/minisign.mk b/package/minisign/minisign.mk
index 7cdce597f7..5cc8e14cba 100644
--- a/package/minisign/minisign.mk
+++ b/package/minisign/minisign.mk
@@ -4,7 +4,7 @@
#
################################################################################
-MINISIGN_VERSION = 0.11
+MINISIGN_VERSION = 0.12
MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION))
MINISIGN_LICENSE = ISC
MINISIGN_LICENSE_FILES = LICENSE
--
2.48.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2] package/minisign: bump to version 0.12
2025-01-27 22:15 ` [Buildroot] [PATCH v2] " patrick.oppenlander
@ 2025-01-27 23:32 ` Julien Olivain
0 siblings, 0 replies; 5+ messages in thread
From: Julien Olivain @ 2025-01-27 23:32 UTC (permalink / raw)
To: patrick.oppenlander; +Cc: buildroot
On 27/01/2025 23:15, patrick.oppenlander@gmail.com wrote:
> From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
>
> Upstream license changed to include 2025 in copyright years.
>
> Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-27 23:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-21 3:14 [Buildroot] [PATCH] package/minisign: bump to version 0.12 patrick.oppenlander
2025-01-24 20:29 ` Julien Olivain
2025-01-27 4:42 ` Patrick Oppenlander
2025-01-27 22:15 ` [Buildroot] [PATCH v2] " patrick.oppenlander
2025-01-27 23:32 ` Julien Olivain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.