* [PATCH] rust: init: use explicit ABI to clean warning in future compilers
@ 2025-01-21 20:09 Miguel Ojeda
2025-01-21 21:47 ` Miguel Ojeda
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Miguel Ojeda @ 2025-01-21 20:09 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross, rust-for-linux,
linux-kernel, patches
Starting with Rust 1.86.0 (currently in nightly, to be released on
2025-04-03), the `missing_abi` lint is warn-by-default [1]:
error: extern declarations without an explicit ABI are deprecated
--> rust/doctests_kernel_generated.rs:3158:1
|
3158 | extern {
| ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
|
= note: `-D missing-abi` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(missing_abi)]`
Thus clean it up.
Link: https://github.com/rust-lang/rust/pull/132397 [1]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
rust/kernel/init.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
index 347049df556b..c962029f96e1 100644
--- a/rust/kernel/init.rs
+++ b/rust/kernel/init.rs
@@ -854,7 +854,7 @@ pub unsafe trait PinInit<T: ?Sized, E = Infallible>: Sized {
/// use kernel::{types::Opaque, init::pin_init_from_closure};
/// #[repr(C)]
/// struct RawFoo([u8; 16]);
- /// extern {
+ /// extern "C" {
/// fn init_foo(_: *mut RawFoo);
/// }
///
base-commit: 100ceb4817a2ac650e29f107cf97161ce3e2289a
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: init: use explicit ABI to clean warning in future compilers
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
@ 2025-01-21 21:47 ` Miguel Ojeda
2025-01-22 9:09 ` Alice Ryhl
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Miguel Ojeda @ 2025-01-21 21:47 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
On Tue, Jan 21, 2025 at 9:10 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Starting with Rust 1.86.0 (currently in nightly, to be released on
> 2025-04-03), the `missing_abi` lint is warn-by-default [1]:
>
> error: extern declarations without an explicit ABI are deprecated
> --> rust/doctests_kernel_generated.rs:3158:1
> |
> 3158 | extern {
> | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
> |
> = note: `-D missing-abi` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(missing_abi)]`
>
> Thus clean it up.
>
> Link: https://github.com/rust-lang/rust/pull/132397 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Cc: <stable@vger.kernel.org> # Needed in 6.12.y only (Rust is pinned
in older LTSs).
And while there was nothing wrong back then with the commit, as usual:
Fixes: 7f8977a7fe6d ("rust: init: add `{pin_}chain` functions to
`{Pin}Init<T, E>`")
Cheers,
Miguel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: init: use explicit ABI to clean warning in future compilers
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
2025-01-21 21:47 ` Miguel Ojeda
@ 2025-01-22 9:09 ` Alice Ryhl
2025-01-22 13:16 ` Fiona Behrens
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Alice Ryhl @ 2025-01-22 9:09 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Trevor Gross, rust-for-linux,
linux-kernel, patches
On Tue, Jan 21, 2025 at 9:10 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Starting with Rust 1.86.0 (currently in nightly, to be released on
> 2025-04-03), the `missing_abi` lint is warn-by-default [1]:
>
> error: extern declarations without an explicit ABI are deprecated
> --> rust/doctests_kernel_generated.rs:3158:1
> |
> 3158 | extern {
> | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
> |
> = note: `-D missing-abi` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(missing_abi)]`
>
> Thus clean it up.
>
> Link: https://github.com/rust-lang/rust/pull/132397 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: init: use explicit ABI to clean warning in future compilers
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
2025-01-21 21:47 ` Miguel Ojeda
2025-01-22 9:09 ` Alice Ryhl
@ 2025-01-22 13:16 ` Fiona Behrens
2025-01-22 16:38 ` Gary Guo
2025-02-05 23:16 ` Miguel Ojeda
4 siblings, 0 replies; 6+ messages in thread
From: Fiona Behrens @ 2025-01-22 13:16 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
On 21 Jan 2025, at 21:09, Miguel Ojeda wrote:
> Starting with Rust 1.86.0 (currently in nightly, to be released on
> 2025-04-03), the `missing_abi` lint is warn-by-default [1]:
>
> error: extern declarations without an explicit ABI are deprecated
> --> rust/doctests_kernel_generated.rs:3158:1
> |
> 3158 | extern {
> | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
> |
> = note: `-D missing-abi` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(missing_abi)]`
>
> Thus clean it up.
>
> Link: https://github.com/rust-lang/rust/pull/132397 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Fiona Behrens <me@kloenk.dev>
> ---
> rust/kernel/init.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
> index 347049df556b..c962029f96e1 100644
> --- a/rust/kernel/init.rs
> +++ b/rust/kernel/init.rs
> @@ -854,7 +854,7 @@ pub unsafe trait PinInit<T: ?Sized, E = Infallible>: Sized {
> /// use kernel::{types::Opaque, init::pin_init_from_closure};
> /// #[repr(C)]
> /// struct RawFoo([u8; 16]);
> - /// extern {
> + /// extern "C" {
> /// fn init_foo(_: *mut RawFoo);
> /// }
> ///
>
> base-commit: 100ceb4817a2ac650e29f107cf97161ce3e2289a
> --
> 2.48.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: init: use explicit ABI to clean warning in future compilers
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
` (2 preceding siblings ...)
2025-01-22 13:16 ` Fiona Behrens
@ 2025-01-22 16:38 ` Gary Guo
2025-02-05 23:16 ` Miguel Ojeda
4 siblings, 0 replies; 6+ messages in thread
From: Gary Guo @ 2025-01-22 16:38 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross, rust-for-linux,
linux-kernel, patches
On Tue, 21 Jan 2025 21:09:34 +0100
Miguel Ojeda <ojeda@kernel.org> wrote:
> Starting with Rust 1.86.0 (currently in nightly, to be released on
> 2025-04-03), the `missing_abi` lint is warn-by-default [1]:
>
> error: extern declarations without an explicit ABI are deprecated
> --> rust/doctests_kernel_generated.rs:3158:1
> |
> 3158 | extern {
> | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
> |
> = note: `-D missing-abi` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(missing_abi)]`
>
> Thus clean it up.
>
> Link: https://github.com/rust-lang/rust/pull/132397 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> rust/kernel/init.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
> index 347049df556b..c962029f96e1 100644
> --- a/rust/kernel/init.rs
> +++ b/rust/kernel/init.rs
> @@ -854,7 +854,7 @@ pub unsafe trait PinInit<T: ?Sized, E = Infallible>: Sized {
> /// use kernel::{types::Opaque, init::pin_init_from_closure};
> /// #[repr(C)]
> /// struct RawFoo([u8; 16]);
> - /// extern {
> + /// extern "C" {
> /// fn init_foo(_: *mut RawFoo);
> /// }
> ///
>
> base-commit: 100ceb4817a2ac650e29f107cf97161ce3e2289a
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust: init: use explicit ABI to clean warning in future compilers
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
` (3 preceding siblings ...)
2025-01-22 16:38 ` Gary Guo
@ 2025-02-05 23:16 ` Miguel Ojeda
4 siblings, 0 replies; 6+ messages in thread
From: Miguel Ojeda @ 2025-02-05 23:16 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
On Tue, Jan 21, 2025 at 9:10 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Starting with Rust 1.86.0 (currently in nightly, to be released on
> 2025-04-03), the `missing_abi` lint is warn-by-default [1]:
>
> error: extern declarations without an explicit ABI are deprecated
> --> rust/doctests_kernel_generated.rs:3158:1
> |
> 3158 | extern {
> | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
> |
> = note: `-D missing-abi` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(missing_abi)]`
>
> Thus clean it up.
>
> Link: https://github.com/rust-lang/rust/pull/132397 [1]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Applied to `rust-fixes` -- thanks everyone!
[ Added 6.13.y to Cc: stable tag. - Miguel ]
Cheers,
Miguel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-05 23:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-21 20:09 [PATCH] rust: init: use explicit ABI to clean warning in future compilers Miguel Ojeda
2025-01-21 21:47 ` Miguel Ojeda
2025-01-22 9:09 ` Alice Ryhl
2025-01-22 13:16 ` Fiona Behrens
2025-01-22 16:38 ` Gary Guo
2025-02-05 23:16 ` Miguel Ojeda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.