From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: [PATCH v2 02/15] rib: annotate rib allocation functions
Date: Wed, 22 Jan 2025 09:32:46 -0800 [thread overview]
Message-ID: <20250122173521.305108-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20250122173521.305108-1-stephen@networkplumber.org>
Add function attributes to catch cases where rib is allocated
and not freed correctly.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/rib/rte_rib.h | 24 +++++++++++++-----------
lib/rib/rte_rib6.h | 24 +++++++++++++-----------
2 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/lib/rib/rte_rib.h b/lib/rib/rte_rib.h
index 2054d3cebd..f30b85d79a 100644
--- a/lib/rib/rte_rib.h
+++ b/lib/rib/rte_rib.h
@@ -230,6 +230,17 @@ rte_rib_get_nh(const struct rte_rib_node *node, uint64_t *nh);
int
rte_rib_set_nh(struct rte_rib_node *node, uint64_t nh);
+
+/**
+ * Free an RIB object.
+ *
+ * @param rib
+ * RIB object handle created with rte_rib_create().
+ * If rib is NULL, no operation is performed.
+ */
+void
+rte_rib_free(struct rte_rib *rib);
+
/**
* Create RIB
*
@@ -245,7 +256,8 @@ rte_rib_set_nh(struct rte_rib_node *node, uint64_t nh);
*/
struct rte_rib *
rte_rib_create(const char *name, int socket_id,
- const struct rte_rib_conf *conf);
+ const struct rte_rib_conf *conf)
+ __rte_malloc __rte_dealloc(rte_rib_free, 1);
/**
* Find an existing RIB object and return a pointer to it.
@@ -259,16 +271,6 @@ rte_rib_create(const char *name, int socket_id,
struct rte_rib *
rte_rib_find_existing(const char *name);
-/**
- * Free an RIB object.
- *
- * @param rib
- * RIB object handle created with rte_rib_create().
- * If rib is NULL, no operation is performed.
- */
-void
-rte_rib_free(struct rte_rib *rib);
-
#ifdef __cplusplus
}
#endif
diff --git a/lib/rib/rte_rib6.h b/lib/rib/rte_rib6.h
index a60756f798..d9514acf82 100644
--- a/lib/rib/rte_rib6.h
+++ b/lib/rib/rte_rib6.h
@@ -294,6 +294,17 @@ rte_rib6_get_nh(const struct rte_rib6_node *node, uint64_t *nh);
int
rte_rib6_set_nh(struct rte_rib6_node *node, uint64_t nh);
+
+/**
+ * Free an RIB object.
+ *
+ * @param rib
+ * RIB object handle created with rte_rib6_create().
+ * If rib is NULL, no operation is performed.
+ */
+void
+rte_rib6_free(struct rte_rib6 *rib);
+
/**
* Create RIB
*
@@ -309,7 +320,8 @@ rte_rib6_set_nh(struct rte_rib6_node *node, uint64_t nh);
*/
struct rte_rib6 *
rte_rib6_create(const char *name, int socket_id,
- const struct rte_rib6_conf *conf);
+ const struct rte_rib6_conf *conf)
+ __rte_malloc __rte_dealloc(rte_rib6_free, 1);
/**
* Find an existing RIB object and return a pointer to it.
@@ -323,16 +335,6 @@ rte_rib6_create(const char *name, int socket_id,
struct rte_rib6 *
rte_rib6_find_existing(const char *name);
-/**
- * Free an RIB object.
- *
- * @param rib
- * RIB object handle created with rte_rib6_create().
- * If rib is NULL, no operation is performed.
- */
-void
-rte_rib6_free(struct rte_rib6 *rib);
-
#ifdef __cplusplus
}
#endif
--
2.45.2
next prev parent reply other threads:[~2025-01-22 17:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 18:03 [PATCH 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 04/15] lpm: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 05/15] pipeline: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 06/15] acl: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 07/15] bitratestats: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 08/15] member: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 09/15] mempool: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 10/15] eventdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 11/15] ring: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 12/15] reorder: " Stephen Hemminger
2025-01-21 12:22 ` [EXTERNAL] " Volodymyr Fialko
2025-01-20 18:03 ` [PATCH 13/15] compressdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 14/15] telemetry: " Stephen Hemminger
2025-01-20 18:43 ` Bruce Richardson
2025-01-20 18:03 ` [PATCH 15/15] sched: " Stephen Hemminger
2025-01-20 18:40 ` [PATCH 00/15] Add attributes to allocation functions Bruce Richardson
2025-01-20 18:42 ` Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-22 17:32 ` Stephen Hemminger [this message]
2025-01-22 17:32 ` [PATCH v2 03/15] hash: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 04/15] lpm: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 05/15] pipeline: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 06/15] acl: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 07/15] bitratestats: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 08/15] member: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 09/15] mempool: " Stephen Hemminger
2025-01-22 20:17 ` Morten Brørup
2025-01-22 17:32 ` [PATCH v2 10/15] eventdev: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 11/15] ring: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 12/15] reorder: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 13/15] compressdev: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 14/15] telemetry: " Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 15/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 00/15] Add allocation annotation to more functions Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 04/15] lpm: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 05/15] acl: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 06/15] bitratestats: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 07/15] member: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 08/15] mempool: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 09/15] eventdev: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 10/15] ring: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 11/15] reorder: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 12/15] compressdev: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 13/15] telemetry: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 14/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 15/15] doc: add release note about allocation attributes Stephen Hemminger
2025-02-07 15:37 ` [PATCH v6 00/15] Add allocation annotation to more functions David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122173521.305108-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.