All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v6 12/15] compressdev: add allocation function attributes
Date: Sat, 25 Jan 2025 10:36:46 -0800	[thread overview]
Message-ID: <20250125184010.782330-13-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125184010.782330-1-stephen@networkplumber.org>

Use function attributes to catch cases where compressdev is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/compressdev/rte_comp.h | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
index d66a4b1cb9..827e3d25ed 100644
--- a/lib/compressdev/rte_comp.h
+++ b/lib/compressdev/rte_comp.h
@@ -11,6 +11,7 @@
  * RTE definitions for Data Compression Service
  */
 
+#include <rte_common.h>
 #include <rte_mbuf.h>
 
 #ifdef __cplusplus
@@ -480,6 +481,19 @@ struct __rte_cache_aligned rte_comp_op {
 	 */
 };
 
+
+/**
+ * Free operation structure
+ * If operation has been allocate from a rte_mempool, then the operation will
+ * be returned to the mempool.
+ *
+ * @param op
+ *   Compress operation pointer allocated from rte_comp_op_alloc()
+ *   If op is NULL, no operation is performed.
+ */
+void
+rte_comp_op_free(struct rte_comp_op *op);
+
 /**
  * Creates an operation pool
  *
@@ -501,7 +515,8 @@ struct __rte_cache_aligned rte_comp_op {
 struct rte_mempool *
 rte_comp_op_pool_create(const char *name,
 		unsigned int nb_elts, unsigned int cache_size,
-		uint16_t user_size, int socket_id);
+		uint16_t user_size, int socket_id)
+	__rte_malloc __rte_dealloc(rte_comp_op_free, 1);
 
 /**
  * Allocate an operation from a mempool with default parameters set
@@ -533,18 +548,6 @@ int
 rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
 		struct rte_comp_op **ops, uint16_t nb_ops);
 
-/**
- * Free operation structure
- * If operation has been allocate from a rte_mempool, then the operation will
- * be returned to the mempool.
- *
- * @param op
- *   Compress operation pointer allocated from rte_comp_op_alloc()
- *   If op is NULL, no operation is performed.
- */
-void
-rte_comp_op_free(struct rte_comp_op *op);
-
 /**
  * Bulk free operation structures
  * If operations have been allocated from an rte_mempool, then the operations
-- 
2.45.2


  parent reply	other threads:[~2025-01-25 18:41 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 18:03 [PATCH 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-20 18:03 ` [PATCH 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-20 18:03 ` [PATCH 04/15] lpm: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 05/15] pipeline: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 06/15] acl: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 07/15] bitratestats: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 08/15] member: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 09/15] mempool: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 10/15] eventdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 11/15] ring: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 12/15] reorder: " Stephen Hemminger
2025-01-21 12:22   ` [EXTERNAL] " Volodymyr Fialko
2025-01-20 18:03 ` [PATCH 13/15] compressdev: " Stephen Hemminger
2025-01-20 18:03 ` [PATCH 14/15] telemetry: " Stephen Hemminger
2025-01-20 18:43   ` Bruce Richardson
2025-01-20 18:03 ` [PATCH 15/15] sched: " Stephen Hemminger
2025-01-20 18:40 ` [PATCH 00/15] Add attributes to allocation functions Bruce Richardson
2025-01-20 18:42   ` Stephen Hemminger
2025-01-22 17:32 ` [PATCH v2 " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 04/15] lpm: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 05/15] pipeline: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 06/15] acl: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 07/15] bitratestats: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 08/15] member: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 09/15] mempool: " Stephen Hemminger
2025-01-22 20:17     ` Morten Brørup
2025-01-22 17:32   ` [PATCH v2 10/15] eventdev: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 11/15] ring: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 12/15] reorder: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 13/15] compressdev: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 14/15] telemetry: " Stephen Hemminger
2025-01-22 17:32   ` [PATCH v2 15/15] sched: " Stephen Hemminger
2025-01-25 18:36 ` [PATCH v6 00/15] Add allocation annotation to more functions Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 04/15] lpm: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 05/15] acl: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 06/15] bitratestats: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 07/15] member: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 08/15] mempool: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 09/15] eventdev: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 10/15] ring: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 11/15] reorder: " Stephen Hemminger
2025-01-25 18:36   ` Stephen Hemminger [this message]
2025-01-25 18:36   ` [PATCH v6 13/15] telemetry: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 14/15] sched: " Stephen Hemminger
2025-01-25 18:36   ` [PATCH v6 15/15] doc: add release note about allocation attributes Stephen Hemminger
2025-02-07 15:37   ` [PATCH v6 00/15] Add allocation annotation to more functions David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250125184010.782330-13-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.