All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "John Harrison" <John.C.Harrison@Intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>
Subject: [PATCH 3/3] drm/xe: Drop duplicated information about GT tile in devcoredump
Date: Thu, 23 Jan 2025 09:59:43 -0800	[thread overview]
Message-ID: <20250123180320.66198-4-jose.souza@intel.com> (raw)
In-Reply-To: <20250123180320.66198-1-jose.souza@intel.com>

The GT tile is already available but was added again in commit
c28fd6c358db ("drm/xe/devcoredump: Improve section headings and add tile info"),
so here deleting it.

Here a devcoredump example with the duplicated information:

**** Xe Device Coredump ****
Reason: Timedout job - seqno=4294967170, lrc_seqno=4294967170, guc_id=13, flags=0x0
kernel: 6.13.0-zeh-xe+
module: xe
Snapshot time: 1737573530.243521319
Uptime: 2588.041930284
Process: deqp-vk [8850]
PCI ID: 0x64a0
PCI revision: 0x04
GT id: 0
	Tile: 0
	Type: main
	IP ver: 20.4.4
	CS reference clock: 19200000
GT id: 1
	Tile: 0
	Type: media
	IP ver: 20.0.4
	CS reference clock: 19200000

**** GT #0 ****
	Tile: 0

**** GuC Log ****
....

Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 1c86e6456d60f..2996945ffee39 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -111,9 +111,6 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
 	drm_printf(&p, "Process: %s [%d]\n", ss->process_name, ss->pid);
 	xe_device_snapshot_print(xe, &p);
 
-	drm_printf(&p, "\n**** GT #%d ****\n", ss->gt->info.id);
-	drm_printf(&p, "\tTile: %d\n", ss->gt->tile->id);
-
 	drm_puts(&p, "\n**** GuC Log ****\n");
 	xe_guc_log_snapshot_print(ss->guc.log, &p);
 	drm_puts(&p, "\n**** GuC CT ****\n");
-- 
2.48.1


  parent reply	other threads:[~2025-01-23 18:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 17:59 [PATCH 0/3] Enable GuC log dump and minor fixes in devcoredump José Roberto de Souza
2025-01-23 17:59 ` [PATCH 1/3] drm/xe: Fix and re-enable xe_print_blob_ascii85() José Roberto de Souza
2025-01-23 18:20   ` John Harrison
2025-01-23 19:37   ` Lucas De Marchi
2025-01-23 17:59 ` [PATCH 2/3] drm/xe: Make GUC binaries dump consistent with other binaries in devcoredump José Roberto de Souza
2025-01-23 18:17   ` John Harrison
2025-01-23 18:45     ` Souza, Jose
2025-01-23 19:26       ` John Harrison
2025-01-23 19:12   ` Lucas De Marchi
2025-01-23 17:59 ` José Roberto de Souza [this message]
2025-01-23 18:18   ` [PATCH 3/3] drm/xe: Drop duplicated information about GT tile " John Harrison
2025-01-23 18:24     ` Souza, Jose
2025-01-23 18:30       ` John Harrison
2025-01-23 18:56         ` Souza, Jose
2025-01-23 19:27           ` John Harrison
2025-01-23 19:35             ` Souza, Jose
2025-01-23 20:59               ` John Harrison
2025-01-23 18:08 ` ✓ CI.Patch_applied: success for Enable GuC log dump and minor fixes " Patchwork
2025-01-23 18:08 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-23 18:09 ` ✓ CI.KUnit: success " Patchwork
2025-01-23 18:26 ` ✓ CI.Build: " Patchwork
2025-01-23 18:28 ` ✗ CI.Hooks: failure " Patchwork
2025-01-23 18:29 ` ✓ CI.checksparse: success " Patchwork
2025-01-23 18:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-24  5:25 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123180320.66198-4-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=John.C.Harrison@Intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.