[dwmw2:kexec-debug-6 5/7] arch/x86/kernel/early_printk.c:148:3: error: use of undeclared identifier 'kexec_debug_8250_port'

[dwmw2:kexec-debug-6 5/7] arch/x86/kernel/early_printk.c:148:3: error: use of undeclared identifier 'kexec_debug_8250_port'

[kernel test robot]

tree:   git://git.infradead.org/users/dwmw2/linux kexec-debug-6
head:   145ae55a8834381a4011861d8607cb4c0f9cf88e
commit: 3d8ea5d45b0a2079e58cd0c72e0a1ac28fd431ca [5/7] x86/kexec: Add 8250 serial port output
config: x86_64-randconfig-076-20250124 (https://download.01.org/0day-ci/archive/20250125/202501250944.JEBhawoz-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250125/202501250944.JEBhawoz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501250944.JEBhawoz-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/early_printk.c:4:
   In file included from include/linux/kexec.h:18:
   In file included from include/linux/vmcore_info.h:6:
   In file included from include/linux/elfcore.h:11:
   In file included from include/linux/ptrace.h:10:
   In file included from include/linux/pid_namespace.h:7:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> arch/x86/kernel/early_printk.c:148:3: error: use of undeclared identifier 'kexec_debug_8250_port'
     148 |                 kexec_debug_8250_port = early_serial_base;
         |                 ^
   1 warning and 1 error generated.


vim +/kexec_debug_8250_port +148 arch/x86/kernel/early_printk.c

   130	
   131	static __init void early_serial_hw_init(unsigned divisor)
   132	{
   133		unsigned char c;
   134	
   135		serial_out(early_serial_base, LCR, 0x3);	/* 8n1 */
   136		serial_out(early_serial_base, IER, 0);	/* no interrupt */
   137		serial_out(early_serial_base, FCR, 0);	/* no fifo */
   138		serial_out(early_serial_base, MCR, 0x3);	/* DTR + RTS */
   139	
   140		c = serial_in(early_serial_base, LCR);
   141		serial_out(early_serial_base, LCR, c | DLAB);
   142		serial_out(early_serial_base, DLL, divisor & 0xff);
   143		serial_out(early_serial_base, DLH, (divisor >> 8) & 0xff);
   144		serial_out(early_serial_base, LCR, c & ~DLAB);
   145	
   146	#ifdef CONFIG_KEXEC_DEBUG
   147		if (serial_in == io_serial_in)
 > 148			kexec_debug_8250_port = early_serial_base;
   149	#endif
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [dwmw2:kexec-debug-6 5/7] arch/x86/kernel/early_printk.c:148:3: error: use of undeclared identifier 'kexec_debug_8250_port'

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

On Sat, 2025-01-25 at 09:38 +0800, kernel test robot wrote:
> 
>    In file included from arch/x86/kernel/early_printk.c:4:
>    In file included from include/linux/kexec.h:18:
>    In file included from include/linux/vmcore_info.h:6:
>    In file included from include/linux/elfcore.h:11:
>    In file included from include/linux/ptrace.h:10:
>    In file included from include/linux/pid_namespace.h:7:
>    In file included from include/linux/mm.h:2223:
>    include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
>      518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
>          |                               ~~~~~~~~~~~ ^ ~~~

I don't believe that one's mine.

> > > arch/x86/kernel/early_printk.c:148:3: error: use of undeclared identifier 'kexec_debug_8250_port'
>      148 |                 kexec_debug_8250_port = early_serial_base;
>          |                 ^
>    1 warning and 1 error generated.

That one is though; turns out I was allowing CONFIG_KEXEC_DEBUG to be
set without KEXEC_CORE.

Rolling this into the next revision:

--- a/kernel/Kconfig.kexec
+++ b/kernel/Kconfig.kexec
@@ -100,7 +100,7 @@ config KEXEC_JUMP
 
 config KEXEC_DEBUG
        bool "Debug kexec transition"
-       depends on HAVE_KEXEC_DEBUG
+       depends on HAVE_KEXEC_DEBUG && KEXEC_CORE
        help
          Faults during kexec can be difficult to debug. This installs exception
          handlers and attempts to report faults. On x86_64 this would use the



[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]