All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com,
	david@redhat.com, jannh@google.com, hughd@google.com,
	willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev,
	akpm@linux-foundation.org, will@kernel.org,
	aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de,
	dave.hansen@linux.intel.com, rppt@kernel.org,
	alexghiti@rivosinc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-um@lists.infradead.org, x86@kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table()
Date: Mon, 27 Jan 2025 17:02:36 +0100	[thread overview]
Message-ID: <20250127160236.GJ16742@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <45651097-c056-49e3-9cc8-c289c1c0030d@bytedance.com>

On Fri, Jan 24, 2025 at 09:00:58PM +0800, Qi Zheng wrote:
> 
> 
> On 2025/1/24 19:38, Peter Zijlstra wrote:
> > On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote:
> > > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table()
> > > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use
> > > tlb_remove_table() unconditionally to free page table pages.
> > > 
> > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> > > Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > I think we can clean up more :-)
> 
> Yes, but Rik van Riel has already done the same thing in his patch series
> [1], so I was originally planning to wait for his patch to be
> merged into the linux-next branch, and then rebase this series onto his
> patch.

Duh, yeah, I've actually seen those patches and totally forgot he did
that... -ETOOMUCHEMAIL :/

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com,
	david@redhat.com, jannh@google.com, hughd@google.com,
	willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev,
	akpm@linux-foundation.org, will@kernel.org,
	aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de,
	dave.hansen@linux.intel.com, rppt@kernel.org,
	alexghiti@rivosinc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
	linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-um@lists.infradead.org, x86@kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table()
Date: Mon, 27 Jan 2025 17:02:36 +0100	[thread overview]
Message-ID: <20250127160236.GJ16742@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <45651097-c056-49e3-9cc8-c289c1c0030d@bytedance.com>

On Fri, Jan 24, 2025 at 09:00:58PM +0800, Qi Zheng wrote:
> 
> 
> On 2025/1/24 19:38, Peter Zijlstra wrote:
> > On Thu, Jan 23, 2025 at 09:26:17PM +0800, Qi Zheng wrote:
> > > If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table()
> > > will fall back to pagetable_dtor() + tlb_remove_page(). So let's use
> > > tlb_remove_table() unconditionally to free page table pages.
> > > 
> > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> > > Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > I think we can clean up more :-)
> 
> Yes, but Rik van Riel has already done the same thing in his patch series
> [1], so I was originally planning to wait for his patch to be
> merged into the linux-next branch, and then rebase this series onto his
> patch.

Duh, yeah, I've actually seen those patches and totally forgot he did
that... -ETOOMUCHEMAIL :/

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-01-27 16:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 13:26 [PATCH 0/5] remove tlb_remove_page_ptdesc() Qi Zheng
2025-01-23 13:26 ` Qi Zheng
2025-01-23 13:26 ` [PATCH 1/5] mm: pgtable: make generic tlb_remove_table() use struct ptdesc Qi Zheng
2025-01-23 13:26   ` Qi Zheng
2025-01-23 13:26 ` [PATCH 2/5] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() Qi Zheng
2025-01-23 13:26   ` Qi Zheng
2025-01-23 13:26 ` [PATCH 3/5] riscv: pgtable: unconditionally " Qi Zheng
2025-01-23 13:26   ` Qi Zheng
2025-01-23 13:26 ` [PATCH 4/5] x86: pgtable: unconditionally use tlb_remove_table() Qi Zheng
2025-01-23 13:26   ` Qi Zheng
2025-01-24 11:38   ` Peter Zijlstra
2025-01-24 11:38     ` Peter Zijlstra
2025-01-24 13:00     ` Qi Zheng
2025-01-24 13:00       ` Qi Zheng
2025-01-27 16:02       ` Peter Zijlstra [this message]
2025-01-27 16:02         ` Peter Zijlstra
2025-01-23 13:26 ` [PATCH 5/5] mm: pgtable: remove tlb_remove_page_ptdesc() Qi Zheng
2025-01-23 13:26   ` Qi Zheng
2025-01-24 11:47 ` [PATCH 0/5] " Peter Zijlstra
2025-01-24 11:47   ` Peter Zijlstra
2025-01-24 13:04   ` Qi Zheng
2025-01-24 13:04     ` Qi Zheng
2025-02-08  7:22   ` Matthew Wilcox
2025-02-08  7:22     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127160236.GJ16742@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=jannh@google.com \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=loongarch@lists.linux.dev \
    --cc=muchun.song@linux.dev \
    --cc=npiggin@gmail.com \
    --cc=riel@surriel.com \
    --cc=rppt@kernel.org \
    --cc=vishal.moola@gmail.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    --cc=yuzhao@google.com \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.