From: Justin Klaassen <justin@tidylabs.net>
To: u-boot@lists.denx.de
Cc: "Justin Klaassen" <justin@tidylabs.net>,
"Alexandre Vicenzi" <linux@alxd.me>,
"Caleb Connolly" <caleb.connolly@linaro.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Christopher Obbard" <christopher.obbard@linaro.org>,
"Deepak Das" <deepakdas.linux@gmail.com>,
"Dragan Simic" <dsimic@manjaro.org>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Jonas Karlman" <jonas@kwiboo.se>, Keerthy <j-keerthy@ti.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Marek Behún" <kabel@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Quentin Schulz" <quentin.schulz@cherry.de>,
"Raymond Mao" <raymond.mao@linaro.org>,
"Simon Glass" <sjg@chromium.org>, "Stefan Roese" <sr@denx.de>,
"Tom Rini" <trini@konsulko.com>,
"Wan Yee Lau" <wan.yee.lau@intel.com>,
"William Wu" <william.wu@rock-chips.com>,
"Xiaobo Tian" <peterwillcn@gmail.com>
Subject: [PATCH v2 0/5] rockchip: rk3399: rk3399-nanopi-4: Fix SD power initialization in SPL
Date: Tue, 28 Jan 2025 21:37:32 +0000 [thread overview]
Message-ID: <20250128213852.465664-1-justin@tidylabs.net> (raw)
The NanoPi RK3399 boards support UHS-I (up to SDR104) SD cards, however
using any of these 1.8v modes results in a boot failure in SPL upon soft
reboot.
The issue is that the "vcc_sdio" regulator is left at 1.8v on reboot and
the corresponding GPIO defaults to 3.3v. This prevents the SD card from
being reinitialized and read successfully.
This change series resolves this issue by allowing the proper
initialization and control of the "vcc3v0_sd" (vmmc-supply) and
"vcc_sdio" (vqmmc-supply) regulators and corresponding GPIO in SPL.
Changes in v2:
- Made added IO-domain driver logs verbose and consistent
- Added separate patch for added CONFIG_SPL_ROCKCHIP_IODOMAIN Kconfig
- Added separate patch for added CONFIG_SPL_REGULATOR_RK8XX Kconfig
- Added patch to remove device-tree properties that conflicted with MMC driver initialization
- Added defconfig changes for all NanoPi RK3399 boards
Justin Klaassen (5):
rockchip: io-domain: Add debug logging for regulators during probe
rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN
regulator: rk8xx: Add CONFIG_SPL_REGULATOR_RK8XX
rockchip: rk3399-nanopi-4: Allow MMC driver to control SD regulators
rockchip: rk3399-nanopi-4: Enable IO-domain driver in SPL
arch/arm/dts/rk3399-nanopi4-u-boot.dtsi | 12 ++++++++++++
configs/nanopc-t4-rk3399_defconfig | 7 +++++++
configs/nanopi-m4-2gb-rk3399_defconfig | 7 +++++++
configs/nanopi-m4-rk3399_defconfig | 7 +++++++
configs/nanopi-m4b-rk3399_defconfig | 7 +++++++
configs/nanopi-neo4-rk3399_defconfig | 7 +++++++
configs/nanopi-r4s-rk3399_defconfig | 7 +++++++
drivers/misc/Kconfig | 8 ++++++++
drivers/misc/rockchip-io-domain.c | 7 ++++++-
drivers/power/regulator/Kconfig | 9 +++++++++
drivers/power/regulator/rk8xx.c | 8 ++------
11 files changed, 79 insertions(+), 7 deletions(-)
--
2.45.3
next reply other threads:[~2025-01-28 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 21:37 Justin Klaassen [this message]
2025-01-28 21:37 ` [PATCH v2 1/5] rockchip: io-domain: Add debug logging for regulators during probe Justin Klaassen
2025-02-04 17:16 ` Quentin Schulz
2025-02-05 17:13 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 2/5] rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN Justin Klaassen
2025-02-04 17:20 ` Quentin Schulz
2025-02-05 17:14 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 3/5] regulator: rk8xx: Add CONFIG_SPL_REGULATOR_RK8XX Justin Klaassen
2025-02-04 17:30 ` Quentin Schulz
2025-02-04 17:30 ` Quentin Schulz
2025-02-05 17:23 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 4/5] rockchip: rk3399-nanopi-4: Allow MMC driver to control SD regulators Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 5/5] rockchip: rk3399-nanopi-4: Enable IO-domain driver in SPL Justin Klaassen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128213852.465664-1-justin@tidylabs.net \
--to=justin@tidylabs.net \
--cc=caleb.connolly@linaro.org \
--cc=christopher.obbard@linaro.org \
--cc=deepakdas.linux@gmail.com \
--cc=dsimic@manjaro.org \
--cc=j-keerthy@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=kabel@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=linux@alxd.me \
--cc=neil.armstrong@linaro.org \
--cc=peterwillcn@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=raymond.mao@linaro.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wan.yee.lau@intel.com \
--cc=wens@csie.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.