From: Justin Klaassen <justin@tidylabs.net>
To: u-boot@lists.denx.de
Cc: Justin Klaassen <justin@tidylabs.net>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Quentin Schulz <quentin.schulz@cherry.de>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: [PATCH v2 1/5] rockchip: io-domain: Add debug logging for regulators during probe
Date: Tue, 28 Jan 2025 21:37:33 +0000 [thread overview]
Message-ID: <20250128213852.465664-2-justin@tidylabs.net> (raw)
In-Reply-To: <20250128213852.465664-1-justin@tidylabs.net>
Log the value of the regulators during initialization of the IO-domain
driver to aid in debugging GPIO voltage configuration problems.
Signed-off-by: Justin Klaassen <justin@tidylabs.net>
---
Changes in v2:
- Made added IO-domain driver logs verbose and consistent
drivers/misc/rockchip-io-domain.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/rockchip-io-domain.c b/drivers/misc/rockchip-io-domain.c
index 025b6049a9f..fdefc9c5fe3 100644
--- a/drivers/misc/rockchip-io-domain.c
+++ b/drivers/misc/rockchip-io-domain.c
@@ -5,6 +5,8 @@
* Ported from linux drivers/soc/rockchip/io-domain.c
*/
+#define LOG_CATEGORY UCLASS_NOP
+
#include <dm.h>
#include <dm/device_compat.h>
#include <regmap.h>
@@ -344,8 +346,10 @@ static int rockchip_iodomain_probe(struct udevice *dev)
continue;
ret = device_get_supply_regulator(dev, supply_name, ®);
- if (ret)
+ if (ret) {
+ log_debug("%s: Regulator not found\n", supply_name);
continue;
+ }
ret = regulator_autoset(reg);
if (ret && ret != -EALREADY && ret != -EMEDIUMTYPE &&
@@ -353,6 +357,7 @@ static int rockchip_iodomain_probe(struct udevice *dev)
continue;
uV = regulator_get_value(reg);
+ log_debug("%s: Regulator %s at %d uV\n", supply_name, reg->name, uV);
if (uV <= 0)
continue;
--
2.45.3
next prev parent reply other threads:[~2025-01-28 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 21:37 [PATCH v2 0/5] rockchip: rk3399: rk3399-nanopi-4: Fix SD power initialization in SPL Justin Klaassen
2025-01-28 21:37 ` Justin Klaassen [this message]
2025-02-04 17:16 ` [PATCH v2 1/5] rockchip: io-domain: Add debug logging for regulators during probe Quentin Schulz
2025-02-05 17:13 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 2/5] rockchip: io-domain: Add CONFIG_SPL_ROCKCHIP_IODOMAIN Justin Klaassen
2025-02-04 17:20 ` Quentin Schulz
2025-02-05 17:14 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 3/5] regulator: rk8xx: Add CONFIG_SPL_REGULATOR_RK8XX Justin Klaassen
2025-02-04 17:30 ` Quentin Schulz
2025-02-04 17:30 ` Quentin Schulz
2025-02-05 17:23 ` Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 4/5] rockchip: rk3399-nanopi-4: Allow MMC driver to control SD regulators Justin Klaassen
2025-01-28 21:37 ` [PATCH v2 5/5] rockchip: rk3399-nanopi-4: Enable IO-domain driver in SPL Justin Klaassen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128213852.465664-2-justin@tidylabs.net \
--to=justin@tidylabs.net \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.