All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: "Conor Dooley" <conor@kernel.org>,
	"Aleksandar Rikalo" <arikalo@gmail.com>,
	linux-riscv@lists.infradead.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Christoph Müllner" <christoph.muellner@vrull.eu>,
	linux-kernel@vger.kernel.org,
	"Djordje Todorovic" <djordje.todorovic@htecgroup.com>
Subject: Re: [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700.
Date: Fri, 31 Jan 2025 08:20:45 +0100	[thread overview]
Message-ID: <20250131-3286dd5adf8e5ff083bcbda4@orel> (raw)
In-Reply-To: <Z5wgZHnvu9EeE4xq@ghost>

On Thu, Jan 30, 2025 at 04:59:16PM -0800, Charlie Jenkins wrote:
> On Fri, Jan 31, 2025 at 12:43:12AM +0000, Conor Dooley wrote:
> > On Thu, Jan 30, 2025 at 02:58:49PM -0800, Charlie Jenkins wrote:
> > > On Wed, Jan 29, 2025 at 04:19:58PM +0000, Conor Dooley wrote:
...
> > > > Why don't you use the same implementation as the !tools
> > > > copy of the header? (I'm not sure why they're different in the first
> > > > place).
> > > 
> > > It is different because the headers in tools are userspace so it doesn't
> > > make sense to have alternatives.
> > 
> > I assume that's an answer to the first part, and not the bit in
> > brackets since the "first place" difference is about using the .4byte
> > versus having an ifdef/else and you're talking about alternatives.
> > That looks to have been some sort of sync issue or oversight in
> > 6da111574baff, no?
> 
> Yeah it was a response to the first part.
> 
> As for the second part, yes it look it was a syncing issue.
>

I just forgot to update the tools copy at the time of 6da111574baff. We
should first sync it (but with s/RISCV_PAUSE/0x100000f/ to avoid the
need to include insn-def.h) before modifying it with this patch.

Thanks,
drew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: "Conor Dooley" <conor@kernel.org>,
	"Aleksandar Rikalo" <arikalo@gmail.com>,
	linux-riscv@lists.infradead.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Christoph Müllner" <christoph.muellner@vrull.eu>,
	linux-kernel@vger.kernel.org,
	"Djordje Todorovic" <djordje.todorovic@htecgroup.com>
Subject: Re: [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700.
Date: Fri, 31 Jan 2025 08:20:45 +0100	[thread overview]
Message-ID: <20250131-3286dd5adf8e5ff083bcbda4@orel> (raw)
In-Reply-To: <Z5wgZHnvu9EeE4xq@ghost>

On Thu, Jan 30, 2025 at 04:59:16PM -0800, Charlie Jenkins wrote:
> On Fri, Jan 31, 2025 at 12:43:12AM +0000, Conor Dooley wrote:
> > On Thu, Jan 30, 2025 at 02:58:49PM -0800, Charlie Jenkins wrote:
> > > On Wed, Jan 29, 2025 at 04:19:58PM +0000, Conor Dooley wrote:
...
> > > > Why don't you use the same implementation as the !tools
> > > > copy of the header? (I'm not sure why they're different in the first
> > > > place).
> > > 
> > > It is different because the headers in tools are userspace so it doesn't
> > > make sense to have alternatives.
> > 
> > I assume that's an answer to the first part, and not the bit in
> > brackets since the "first place" difference is about using the .4byte
> > versus having an ifdef/else and you're talking about alternatives.
> > That looks to have been some sort of sync issue or oversight in
> > 6da111574baff, no?
> 
> Yeah it was a response to the first part.
> 
> As for the second part, yes it look it was a syncing issue.
>

I just forgot to update the tools copy at the time of 6da111574baff. We
should first sync it (but with s/RISCV_PAUSE/0x100000f/ to avoid the
need to include insn-def.h) before modifying it with this patch.

Thanks,
drew

  reply	other threads:[~2025-01-31  7:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 13:17 [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700 Aleksandar Rikalo
2025-01-29 13:17 ` Aleksandar Rikalo
2025-01-29 16:19 ` Conor Dooley
2025-01-29 16:19   ` Conor Dooley
2025-01-30 22:58   ` Charlie Jenkins
2025-01-30 22:58     ` Charlie Jenkins
2025-01-31  0:43     ` Conor Dooley
2025-01-31  0:43       ` Conor Dooley
2025-01-31  0:59       ` Charlie Jenkins
2025-01-31  0:59         ` Charlie Jenkins
2025-01-31  7:20         ` Andrew Jones [this message]
2025-01-31  7:20           ` Andrew Jones
2025-01-30 23:00 ` Charlie Jenkins
2025-01-30 23:00   ` Charlie Jenkins
2025-02-05 15:44 ` Palmer Dabbelt
2025-02-05 15:44   ` Palmer Dabbelt
2025-03-19 12:26   ` Djordje Todorovic
2025-03-19 12:26     ` Djordje Todorovic
2025-03-25  9:12     ` Alexandre Ghiti
2025-03-25  9:12       ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250131-3286dd5adf8e5ff083bcbda4@orel \
    --to=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arikalo@gmail.com \
    --cc=charlie@rivosinc.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=conor@kernel.org \
    --cc=djordje.todorovic@htecgroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.