From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix memory leak in aRFS after reset
Date: Fri, 31 Jan 2025 10:12:59 +0000 [thread overview]
Message-ID: <20250131101259.GG24105@kernel.org> (raw)
In-Reply-To: <20250123081539.1814685-1-grzegorz.nitka@intel.com>
On Thu, Jan 23, 2025 at 09:15:39AM +0100, Grzegorz Nitka wrote:
> Fix aRFS (accelerated Receive Flow Steering) structures memory leak by
> adding a checker to verify if aRFS memory is already allocated while
> configuring VSI. aRFS objects are allocated in two cases:
> - as part of VSI initialization (at probe), and
> - as part of reset handling
>
> However, VSI reconfiguration executed during reset involves memory
> allocation one more time, without prior releasing already allocated
> resources. This led to the memory leak with the following signature:
>
> [root@os-delivery ~]# cat /sys/kernel/debug/kmemleak
> unreferenced object 0xff3c1ca7252e6000 (size 8192):
> comm "kworker/0:0", pid 8, jiffies 4296833052
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace (crc 0):
> [<ffffffff991ec485>] __kmalloc_cache_noprof+0x275/0x340
> [<ffffffffc0a6e06a>] ice_init_arfs+0x3a/0xe0 [ice]
> [<ffffffffc09f1027>] ice_vsi_cfg_def+0x607/0x850 [ice]
> [<ffffffffc09f244b>] ice_vsi_setup+0x5b/0x130 [ice]
> [<ffffffffc09c2131>] ice_init+0x1c1/0x460 [ice]
> [<ffffffffc09c64af>] ice_probe+0x2af/0x520 [ice]
> [<ffffffff994fbcd3>] local_pci_probe+0x43/0xa0
> [<ffffffff98f07103>] work_for_cpu_fn+0x13/0x20
> [<ffffffff98f0b6d9>] process_one_work+0x179/0x390
> [<ffffffff98f0c1e9>] worker_thread+0x239/0x340
> [<ffffffff98f14abc>] kthread+0xcc/0x100
> [<ffffffff98e45a6d>] ret_from_fork+0x2d/0x50
> [<ffffffff98e083ba>] ret_from_fork_asm+0x1a/0x30
> ...
>
> Fixes: 28bf26724fdb ("ice: Implement aRFS")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH iwl-net v1] ice: fix memory leak in aRFS after reset
Date: Fri, 31 Jan 2025 10:12:59 +0000 [thread overview]
Message-ID: <20250131101259.GG24105@kernel.org> (raw)
In-Reply-To: <20250123081539.1814685-1-grzegorz.nitka@intel.com>
On Thu, Jan 23, 2025 at 09:15:39AM +0100, Grzegorz Nitka wrote:
> Fix aRFS (accelerated Receive Flow Steering) structures memory leak by
> adding a checker to verify if aRFS memory is already allocated while
> configuring VSI. aRFS objects are allocated in two cases:
> - as part of VSI initialization (at probe), and
> - as part of reset handling
>
> However, VSI reconfiguration executed during reset involves memory
> allocation one more time, without prior releasing already allocated
> resources. This led to the memory leak with the following signature:
>
> [root@os-delivery ~]# cat /sys/kernel/debug/kmemleak
> unreferenced object 0xff3c1ca7252e6000 (size 8192):
> comm "kworker/0:0", pid 8, jiffies 4296833052
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace (crc 0):
> [<ffffffff991ec485>] __kmalloc_cache_noprof+0x275/0x340
> [<ffffffffc0a6e06a>] ice_init_arfs+0x3a/0xe0 [ice]
> [<ffffffffc09f1027>] ice_vsi_cfg_def+0x607/0x850 [ice]
> [<ffffffffc09f244b>] ice_vsi_setup+0x5b/0x130 [ice]
> [<ffffffffc09c2131>] ice_init+0x1c1/0x460 [ice]
> [<ffffffffc09c64af>] ice_probe+0x2af/0x520 [ice]
> [<ffffffff994fbcd3>] local_pci_probe+0x43/0xa0
> [<ffffffff98f07103>] work_for_cpu_fn+0x13/0x20
> [<ffffffff98f0b6d9>] process_one_work+0x179/0x390
> [<ffffffff98f0c1e9>] worker_thread+0x239/0x340
> [<ffffffff98f14abc>] kthread+0xcc/0x100
> [<ffffffff98e45a6d>] ret_from_fork+0x2d/0x50
> [<ffffffff98e083ba>] ret_from_fork_asm+0x1a/0x30
> ...
>
> Fixes: 28bf26724fdb ("ice: Implement aRFS")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-31 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 8:15 [Intel-wired-lan] [PATCH iwl-net v1] ice: fix memory leak in aRFS after reset Grzegorz Nitka
2025-01-23 8:15 ` Grzegorz Nitka
2025-01-31 10:12 ` Simon Horman [this message]
2025-01-31 10:12 ` Simon Horman
2025-02-26 6:03 ` [Intel-wired-lan] " Rinitha, SX
2025-02-26 6:03 ` Rinitha, SX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131101259.GG24105@kernel.org \
--to=horms@kernel.org \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.