From: Simon Horman <horms@kernel.org>
To: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
dan.carpenter@linaro.org, yuehaibing@huawei.com,
maciej.fijalkowski@intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference
Date: Fri, 31 Jan 2025 14:56:31 +0000 [thread overview]
Message-ID: <20250131145631.GA34138@kernel.org> (raw)
In-Reply-To: <20250131121450.11645-1-piotr.kwapulinski@intel.com>
On Fri, Jan 31, 2025 at 01:14:50PM +0100, Piotr Kwapulinski wrote:
> The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in
> ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status
> encoding. Propagate this logic to the ixgbe_put_rx_buffer().
>
> The commit also relaxed the skb NULL pointer check - caught by Smatch.
> Restore this check.
>
> Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
> ---
> v1 -> v2
> Provide extra details in commit message for motivation of this patch
> v2 -> v3
> Simplify the check condition
> v3 -> v4
> Rebase to net-queue
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
dan.carpenter@linaro.org, yuehaibing@huawei.com,
maciej.fijalkowski@intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference
Date: Fri, 31 Jan 2025 14:56:31 +0000 [thread overview]
Message-ID: <20250131145631.GA34138@kernel.org> (raw)
In-Reply-To: <20250131121450.11645-1-piotr.kwapulinski@intel.com>
On Fri, Jan 31, 2025 at 01:14:50PM +0100, Piotr Kwapulinski wrote:
> The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in
> ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status
> encoding. Propagate this logic to the ixgbe_put_rx_buffer().
>
> The commit also relaxed the skb NULL pointer check - caught by Smatch.
> Restore this check.
>
> Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
> ---
> v1 -> v2
> Provide extra details in commit message for motivation of this patch
> v2 -> v3
> Simplify the check condition
> v3 -> v4
> Rebase to net-queue
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-31 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 12:14 [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference Piotr Kwapulinski
2025-01-31 12:14 ` Piotr Kwapulinski
2025-01-31 14:56 ` Simon Horman [this message]
2025-01-31 14:56 ` Simon Horman
2025-01-31 15:15 ` [Intel-wired-lan] " Simon Horman
2025-01-31 15:15 ` Simon Horman
2025-02-03 21:21 ` [Intel-wired-lan] " Tony Nguyen
2025-02-11 9:36 ` Sanigani, SarithaX
2025-02-11 9:36 ` Sanigani, SarithaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131145631.GA34138@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.