* [PATCH] staging: comedi: add blank line after declarations
@ 2025-01-30 22:33 Ian To
2025-01-31 6:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ian To @ 2025-01-30 22:33 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org linux-kernel@vger.kernel.org
Bcc:
Subject: [PATCH] staging: comedi: add blank line after declarations
Reply-To:
Added blank lines after declarations. Reported by checkpatch.
Signed-off-by: Ian To <onlyian4981@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e85a99b68f31..3f70e5dfac39 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2169,6 +2169,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
break;
case COMEDI_CHANINFO: {
struct comedi_chaninfo it;
+
if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
rc = -EFAULT;
else
@@ -2177,6 +2178,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
}
case COMEDI_RANGEINFO: {
struct comedi_rangeinfo it;
+
if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
rc = -EFAULT;
else
@@ -2249,6 +2251,7 @@ static long comedi_unlocked_ioctl(struct file *file, unsigned int cmd,
}
case COMEDI_INSN: {
struct comedi_insn insn;
+
if (copy_from_user(&insn, (void __user *)arg, sizeof(insn)))
rc = -EFAULT;
else
--
2.45.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: comedi: add blank line after declarations
2025-01-30 22:33 [PATCH] staging: comedi: add blank line after declarations Ian To
@ 2025-01-31 6:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-01-31 6:48 UTC (permalink / raw)
To: Ian To; +Cc: abbotti, hsweeten, devel, linux-kernel
On Thu, Jan 30, 2025 at 02:33:27PM -0800, Ian To wrote:
> gregkh@linuxfoundation.org
> Cc: devel@driverdev.osuosl.org linux-kernel@vger.kernel.org
> Bcc:
> Subject: [PATCH] staging: comedi: add blank line after declarations
> Reply-To:
Something went wrong with your email submission here, please fix up and
try again.
Also:
> Added blank lines after declarations. Reported by checkpatch.
>
> Signed-off-by: Ian To <onlyian4981@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 3 +++
This file is not in the kernel tree right now, are you sure you are
working on the proper kernel version to do development with?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-31 6:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-30 22:33 [PATCH] staging: comedi: add blank line after declarations Ian To
2025-01-31 6:48 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.