From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
ecree.xilinx@gmail.com, gal@nvidia.com,
przemyslaw.kitszel@intel.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net 4/4] selftests: drv-net: rss_ctx: don't fail reconfigure test if queue offset not supported
Date: Fri, 31 Jan 2025 17:30:40 -0800 [thread overview]
Message-ID: <20250201013040.725123-5-kuba@kernel.org> (raw)
In-Reply-To: <20250201013040.725123-1-kuba@kernel.org>
Vast majority of drivers does not support queue offset.
Simply return if the rss context + queue ntuple fails.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
| 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
index 27e24e20749f..319aaa004c40 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
@@ -260,7 +260,12 @@ from lib.py import ethtool, ip, defer, GenerateTraffic, CmdExitFailure
# change the table to target queues 0 and 2
ethtool(f"-X {cfg.ifname} {ctx_ref} weight 1 0 1 0")
# ntuple rule therefore targets queues 1 and 3
- ntuple2 = ethtool_create(cfg, "-N", flow)
+ try:
+ ntuple2 = ethtool_create(cfg, "-N", flow)
+ except CmdExitFailure:
+ ksft_pr("Driver does not support rss + queue offset")
+ return
+
defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")
# should replace existing filter
ksft_eq(ntuple, ntuple2)
--
2.48.1
next prev parent reply other threads:[~2025-02-01 1:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 1:30 [PATCH net 0/4] ethtool: rss: minor fixes for recent RSS changes Jakub Kicinski
2025-02-01 1:30 ` [PATCH net 1/4] ethtool: rss: fix hiding unsupported fields in dumps Jakub Kicinski
2025-02-03 15:15 ` Gal Pressman
2025-02-03 21:11 ` Joe Damato
2025-02-01 1:30 ` [PATCH net 2/4] ethtool: ntuple: fix rss + ring_cookie check Jakub Kicinski
2025-02-03 15:06 ` Gal Pressman
2025-02-03 21:16 ` Joe Damato
2025-02-03 21:25 ` Jakub Kicinski
2025-02-03 21:30 ` Joe Damato
2025-02-03 21:39 ` Jakub Kicinski
2025-02-04 6:42 ` Gal Pressman
2025-02-01 1:30 ` [PATCH net 3/4] selftests: drv-net: rss_ctx: add missing cleanup in queue reconfigure Jakub Kicinski
2025-02-03 21:21 ` Joe Damato
2025-02-01 1:30 ` Jakub Kicinski [this message]
2025-02-03 21:21 ` [PATCH net 4/4] selftests: drv-net: rss_ctx: don't fail reconfigure test if queue offset not supported Joe Damato
2025-02-04 2:50 ` [PATCH net 0/4] ethtool: rss: minor fixes for recent RSS changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250201013040.725123-5-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.