From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, ecree.xilinx@gmail.com, gal@nvidia.com,
przemyslaw.kitszel@intel.com
Subject: Re: [PATCH net 2/4] ethtool: ntuple: fix rss + ring_cookie check
Date: Mon, 3 Feb 2025 13:25:19 -0800 [thread overview]
Message-ID: <20250203132519.67f97123@kernel.org> (raw)
In-Reply-To: <Z6EyPtp4rrCYSCTb@LQ3V64L9R2>
On Mon, 3 Feb 2025 13:16:46 -0800 Joe Damato wrote:
> On Fri, Jan 31, 2025 at 05:30:38PM -0800, Jakub Kicinski wrote:
> > The info.flow_type is for RXFH commands, ntuple flow_type is inside
> > the flow spec. The check currently does nothing, as info.flow_type
> > is 0 for ETHTOOL_SRXCLSRLINS.
>
> Agree with Gal; I think ethtool's stack allocated ethtool_rxnfc
> could result in some garbage value being passed in for
> info.flow_type.
I admit I haven't dug into the user space side, but in the kernel
my reading is that the entire struct ethtool_rxnfc, which includes
_both_ flow_type fields gets copied in. IOW struct ethtool_rxnfc
has two flow_type fields, one directly in the struct and one inside
the fs member.
next prev parent reply other threads:[~2025-02-03 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 1:30 [PATCH net 0/4] ethtool: rss: minor fixes for recent RSS changes Jakub Kicinski
2025-02-01 1:30 ` [PATCH net 1/4] ethtool: rss: fix hiding unsupported fields in dumps Jakub Kicinski
2025-02-03 15:15 ` Gal Pressman
2025-02-03 21:11 ` Joe Damato
2025-02-01 1:30 ` [PATCH net 2/4] ethtool: ntuple: fix rss + ring_cookie check Jakub Kicinski
2025-02-03 15:06 ` Gal Pressman
2025-02-03 21:16 ` Joe Damato
2025-02-03 21:25 ` Jakub Kicinski [this message]
2025-02-03 21:30 ` Joe Damato
2025-02-03 21:39 ` Jakub Kicinski
2025-02-04 6:42 ` Gal Pressman
2025-02-01 1:30 ` [PATCH net 3/4] selftests: drv-net: rss_ctx: add missing cleanup in queue reconfigure Jakub Kicinski
2025-02-03 21:21 ` Joe Damato
2025-02-01 1:30 ` [PATCH net 4/4] selftests: drv-net: rss_ctx: don't fail reconfigure test if queue offset not supported Jakub Kicinski
2025-02-03 21:21 ` Joe Damato
2025-02-04 2:50 ` [PATCH net 0/4] ethtool: rss: minor fixes for recent RSS changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203132519.67f97123@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.