* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 11:21 [PATCH 5.4 00/94] 5.4.290-rc2 review Greg Kroah-Hartman
@ 2025-01-31 12:56 ` Pavel Machek
2025-02-01 8:01 ` Greg Kroah-Hartman
2025-01-31 13:36 ` Jon Hunter
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Pavel Machek @ 2025-01-31 12:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]
Hi!
> This is the start of the stable review cycle for the 5.4.290 release.
> There are 94 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Still not ok.
In file included from ./arch/riscv/include/asm/ptrace.h:10,
1128
from ./arch/riscv/include/asm/processor.h:11,
1129
from ./arch/riscv/include/asm/irqflags.h:10,
1130
from ./include/linux/irqflags.h:16,
1131
from ./arch/riscv/include/asm/bitops.h:14,
1132
from ./include/linux/bitops.h:27,
1133
from ./include/linux/kernel.h:12,
1134
from ./include/linux/list.h:9,
1135
from ./include/linux/kobject.h:19,
1136
from ./include/linux/device.h:16,
1137
from ./include/linux/node.h:18,
1138
from ./include/linux/cpu.h:17,
1139
from arch/riscv/kernel/traps.c:6:
1140
arch/riscv/kernel/traps.c: In function 'trap_init':
1141
arch/riscv/kernel/traps.c:164:23: error: 'handle_exception' undeclared (first use in this function)
1142
164 | csr_write(CSR_TVEC, &handle_exception);
1143
| ^~~~~~~~~~~~~~~~
1144
./arch/riscv/include/asm/csr.h:166:38: note: in definition of macro 'csr_write'
1145
166 | unsigned long __v = (unsigned long)(val); \
1146
| ^~~
1147
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1650173074
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.4.y
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 12:56 ` Pavel Machek
@ 2025-02-01 8:01 ` Greg Kroah-Hartman
2025-02-01 13:30 ` Guenter Roeck
2025-02-01 15:03 ` Guenter Roeck
0 siblings, 2 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2025-02-01 8:01 UTC (permalink / raw)
To: Pavel Machek
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee,
srw, rwarsow, conor, hargar, broonie
On Fri, Jan 31, 2025 at 01:56:04PM +0100, Pavel Machek wrote:
> Hi!
>
> > This is the start of the stable review cycle for the 5.4.290 release.
> > There are 94 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
>
> Still not ok.
>
> In file included from ./arch/riscv/include/asm/ptrace.h:10,
> 1128
> from ./arch/riscv/include/asm/processor.h:11,
> 1129
> from ./arch/riscv/include/asm/irqflags.h:10,
> 1130
> from ./include/linux/irqflags.h:16,
> 1131
> from ./arch/riscv/include/asm/bitops.h:14,
> 1132
> from ./include/linux/bitops.h:27,
> 1133
> from ./include/linux/kernel.h:12,
> 1134
> from ./include/linux/list.h:9,
> 1135
> from ./include/linux/kobject.h:19,
> 1136
> from ./include/linux/device.h:16,
> 1137
> from ./include/linux/node.h:18,
> 1138
> from ./include/linux/cpu.h:17,
> 1139
> from arch/riscv/kernel/traps.c:6:
> 1140
> arch/riscv/kernel/traps.c: In function 'trap_init':
> 1141
> arch/riscv/kernel/traps.c:164:23: error: 'handle_exception' undeclared (first use in this function)
> 1142
> 164 | csr_write(CSR_TVEC, &handle_exception);
> 1143
> | ^~~~~~~~~~~~~~~~
> 1144
> ./arch/riscv/include/asm/csr.h:166:38: note: in definition of macro 'csr_write'
> 1145
> 166 | unsigned long __v = (unsigned long)(val); \
> 1146
> | ^~~
> 1147
What's it with the blank lines?
Anyway, are you all really caring about riscv on a 5.4.y kernel? Last I
checked, the riscv maintainers said not to even use that kernel for that
architecture. Do you all have real boards that care about this kernel
tree that you are insisting on keeping alive? Why not move them to a
newer LTS kernel?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-02-01 8:01 ` Greg Kroah-Hartman
@ 2025-02-01 13:30 ` Guenter Roeck
2025-02-01 15:03 ` Guenter Roeck
1 sibling, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2025-02-01 13:30 UTC (permalink / raw)
To: Greg Kroah-Hartman, Pavel Machek
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On 2/1/25 00:01, Greg Kroah-Hartman wrote:
> Anyway, are you all really caring about riscv on a 5.4.y kernel? Last I
> checked, the riscv maintainers said not to even use that kernel for that
> architecture. Do you all have real boards that care about this kernel
> tree that you are insisting on keeping alive? Why not move them to a
> newer LTS kernel?
>
That makes me wonder - is there a list of architectures and/or platforms
which should no longer be tested for older kernels ?
I am sure that could help free up test bed resources, and it would make
exchanges like this unnecessary.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-02-01 8:01 ` Greg Kroah-Hartman
2025-02-01 13:30 ` Guenter Roeck
@ 2025-02-01 15:03 ` Guenter Roeck
2025-02-01 15:34 ` Greg Kroah-Hartman
1 sibling, 1 reply; 12+ messages in thread
From: Guenter Roeck @ 2025-02-01 15:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, Pavel Machek
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On 2/1/25 00:01, Greg Kroah-Hartman wrote:
...
> Anyway, are you all really caring about riscv on a 5.4.y kernel? Last I
> checked, the riscv maintainers said not to even use that kernel for that
> architecture. Do you all have real boards that care about this kernel
> tree that you are insisting on keeping alive? Why not move them to a
> newer LTS kernel?
>
Looking into the 5.4 release candidate, I see:
$ git log --oneline v5.4.289.. arch/riscv/
98d26e0254ff RISC-V: Don't enable all interrupts in trap_init()
574c5efceb70 riscv: prefix IRQ_ macro names with an RV_ namespace
c57ffe372502 riscv: Fix sleeping in invalid context in die()
98c62ee8bc75 riscv: Avoid enabling interrupts in die()
88cb873873ff RISC-V: Avoid dereferening NULL regs in die()
2a83ad25311e riscv: remove unused handle_exception symbol
8652d51931cc riscv: abstract out CSR names for supervisor vs machine mode
Why do you backport riscv patches to 5.4.y if you think they should not be
tested ? Shouldn't your question imply that there won't be any further
backports into 5.4.y for architecture(s) which are no longer supported
in that branch ?
Confused.
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-02-01 15:03 ` Guenter Roeck
@ 2025-02-01 15:34 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2025-02-01 15:34 UTC (permalink / raw)
To: Guenter Roeck
Cc: Pavel Machek, stable, patches, linux-kernel, torvalds, akpm,
shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On Sat, Feb 01, 2025 at 07:03:33AM -0800, Guenter Roeck wrote:
> On 2/1/25 00:01, Greg Kroah-Hartman wrote:
> ...
> > Anyway, are you all really caring about riscv on a 5.4.y kernel? Last I
> > checked, the riscv maintainers said not to even use that kernel for that
> > architecture. Do you all have real boards that care about this kernel
> > tree that you are insisting on keeping alive? Why not move them to a
> > newer LTS kernel?
> >
>
> Looking into the 5.4 release candidate, I see:
>
> $ git log --oneline v5.4.289.. arch/riscv/
> 98d26e0254ff RISC-V: Don't enable all interrupts in trap_init()
> 574c5efceb70 riscv: prefix IRQ_ macro names with an RV_ namespace
> c57ffe372502 riscv: Fix sleeping in invalid context in die()
> 98c62ee8bc75 riscv: Avoid enabling interrupts in die()
> 88cb873873ff RISC-V: Avoid dereferening NULL regs in die()
> 2a83ad25311e riscv: remove unused handle_exception symbol
> 8652d51931cc riscv: abstract out CSR names for supervisor vs machine mode
I've dropped them all now, as that is what was causing the build
problems.
> Why do you backport riscv patches to 5.4.y if you think they should not be
> tested ? Shouldn't your question imply that there won't be any further
> backports into 5.4.y for architecture(s) which are no longer supported
> in that branch ?
I'm not implying they are not to be tested, it's just a real "is this
something that people actually care about" question. Last time we had
riscv problems in this branch the riscv maintainers said "don't worry
about it". I didn't notice that Sasha had queued these up here,
otherwise I would have probably just dropped them then like I did right
now :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 11:21 [PATCH 5.4 00/94] 5.4.290-rc2 review Greg Kroah-Hartman
2025-01-31 12:56 ` Pavel Machek
@ 2025-01-31 13:36 ` Jon Hunter
2025-01-31 17:22 ` Muhammad Usama Anjum
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2025-01-31 13:36 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
linux-tegra, stable
On Fri, 31 Jan 2025 12:21:41 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.290 release.
> There are 94 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.290-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v5.4:
10 builds: 10 pass, 0 fail
24 boots: 24 pass, 0 fail
54 tests: 54 pass, 0 fail
Linux version: 5.4.290-rc2-gb4cc7cb40189
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 11:21 [PATCH 5.4 00/94] 5.4.290-rc2 review Greg Kroah-Hartman
2025-01-31 12:56 ` Pavel Machek
2025-01-31 13:36 ` Jon Hunter
@ 2025-01-31 17:22 ` Muhammad Usama Anjum
2025-02-01 15:08 ` Naresh Kamboju
2025-02-02 13:31 ` Harshit Mogalapalli
4 siblings, 0 replies; 12+ messages in thread
From: Muhammad Usama Anjum @ 2025-01-31 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: Usama.Anjum, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On 1/31/25 4:21 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.290 release.
> There are 94 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.290-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
OVERVIEW
Builds: 29 passed, 5 failed
Boot tests: 452 passed, 0 failed
CI systems: broonie, maestro
REVISION
Commit
name: v5.4.289-95-gb4cc7cb40189
hash: b4cc7cb40189a3206ae81247a0596c4a2b4a9f69
Checked out from
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
BUILDS
Failures
-arm64 (defconfig)
Build detail: https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=broonie:b4cc7cb40189a3206ae81247a0596c4a2b4a9f69-arm64-defconfig
CI system: broonie
-i386 (i386_defconfig+allmodconfig)
Build detail: https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=maestro:679cb54a65fae3351e33ff93
Build error: AR mm/built-in.a
-riscv (defconfig)
Build detail: https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=maestro:679cb55865fae3351e33ffa0
Build error: arch/riscv/kernel/traps.c:164:30: error: ‘handle_exception’ undeclared (first use in this function)
-arm64 (defconfig)
Build detail: https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=maestro:679cb54365fae3351e33ff8d
Build error: ./arch/arm64/include/asm/memory.h:85:50: error: ‘KASAN_SHADOW_SCALE_SHIFT’ undeclared (first use in this function)
-arm64 (cros://chromeos-5.4/arm64/chromiumos-qualcomm.flavour.config)
Build detail: https://kcidb.kernelci.org/d/build/build?orgId=1&var-id=maestro:679cb56f65fae3351e33ffb6
Build error: make: *** [arch/arm64/Makefile:170: vdso_prepare] Error 2
CI system: maestro
BOOT TESTS
No boot failures found
See complete and up-to-date report at:
https://kcidb.kernelci.org/d/revision/revision?orgId=1&var-git_commit_hash=b4cc7cb40189a3206ae81247a0596c4a2b4a9f69&var-patchset_hash=
Tested-by: kernelci.org bot <bot@kernelci.org>
Thanks,
KernelCI team
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 11:21 [PATCH 5.4 00/94] 5.4.290-rc2 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2025-01-31 17:22 ` Muhammad Usama Anjum
@ 2025-02-01 15:08 ` Naresh Kamboju
2025-02-01 15:34 ` Greg Kroah-Hartman
2025-02-01 15:43 ` Guenter Roeck
2025-02-02 13:31 ` Harshit Mogalapalli
4 siblings, 2 replies; 12+ messages in thread
From: Naresh Kamboju @ 2025-02-01 15:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On Fri, 31 Jan 2025 at 16:51, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.4.290 release.
> There are 94 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.290-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
As other reported,
the riscv build failed with defconfig with gcc and clang toolchain on the
stable-rc 5.4.290-rc1 and 5.4.290-rc2
* riscv, build
- clang-19-allnoconfig
- clang-19-allyesconfig
- clang-19-defconfig
- clang-19-tinyconfig
- gcc-12-allnoconfig
- gcc-12-allyesconfig
- gcc-12-defconfig
- gcc-12-tinyconfig
- gcc-8-allnoconfig
- gcc-8-allyesconfig
- gcc-8-defconfig
- gcc-8-tinyconfig
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build regression: riscv kernel traps.c error: use of undeclared
identifier 'handle_exception'
Build error:
---
arch/riscv/kernel/traps.c:164:23: error: use of undeclared identifier
'handle_exception'
164 | csr_write(CSR_TVEC, &handle_exception);
| ^
1 warning and 1 error generated
Links:
---
build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.289-95-gb4cc7cb40189/testrun/27103461/suite/build/test/clang-19-defconfig/log
history: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.289-95-gb4cc7cb40189/testrun/27103461/suite/build/test/clang-19-defconfig/history/
build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2sOPMVgFZtEG3dgzhD7rgdCoAsj/
kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2sOPMVgFZtEG3dgzhD7rgdCoAsj/config
## Build
* kernel: 5.4.290-rc2
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: b4cc7cb40189a3206ae81247a0596c4a2b4a9f69
* git describe: v5.4.289-95-gb4cc7cb40189
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.289-95-gb4cc7cb40189
## Test Regressions (compared to v5.4.288-94-g0578e8d64d90)
* riscv, build
- clang-19-allnoconfig
- clang-19-allyesconfig
- clang-19-defconfig
- clang-19-tinyconfig
- gcc-12-allnoconfig
- gcc-12-allyesconfig
- gcc-12-defconfig
- gcc-12-tinyconfig
- gcc-8-allnoconfig
- gcc-8-allyesconfig
- gcc-8-defconfig
- gcc-8-tinyconfig
## Metric Regressions (compared to v5.4.288-94-g0578e8d64d90)
## Test Fixes (compared to v5.4.288-94-g0578e8d64d90)
## Metric Fixes (compared to v5.4.288-94-g0578e8d64d90)
## Test result summary
total: 44418, pass: 28423, fail: 4303, skip: 11414, xfail: 278
## Build Summary
* arc: 6 total, 5 passed, 1 failed
* arm: 136 total, 136 passed, 0 failed
* arm64: 37 total, 35 passed, 2 failed
* i386: 22 total, 16 passed, 6 failed
* mips: 29 total, 27 passed, 2 failed
* parisc: 4 total, 0 passed, 4 failed
* powerpc: 30 total, 28 passed, 2 failed
* riscv: 12 total, 0 passed, 12 failed
* s390: 8 total, 8 passed, 0 failed
* sh: 12 total, 10 passed, 2 failed
* sparc: 8 total, 7 passed, 1 failed
* x86_64: 33 total, 33 passed, 0 failed
## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-02-01 15:08 ` Naresh Kamboju
@ 2025-02-01 15:34 ` Greg Kroah-Hartman
2025-02-01 15:43 ` Guenter Roeck
1 sibling, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2025-02-01 15:34 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On Sat, Feb 01, 2025 at 08:38:48PM +0530, Naresh Kamboju wrote:
> On Fri, 31 Jan 2025 at 16:51, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.4.290 release.
> > There are 94 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.290-rc2.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> As other reported,
> the riscv build failed with defconfig with gcc and clang toolchain on the
> stable-rc 5.4.290-rc1 and 5.4.290-rc2
>
> * riscv, build
> - clang-19-allnoconfig
> - clang-19-allyesconfig
> - clang-19-defconfig
> - clang-19-tinyconfig
> - gcc-12-allnoconfig
> - gcc-12-allyesconfig
> - gcc-12-defconfig
> - gcc-12-tinyconfig
> - gcc-8-allnoconfig
> - gcc-8-allyesconfig
> - gcc-8-defconfig
> - gcc-8-tinyconfig
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Build regression: riscv kernel traps.c error: use of undeclared
> identifier 'handle_exception'
>
> Build error:
> ---
> arch/riscv/kernel/traps.c:164:23: error: use of undeclared identifier
> 'handle_exception'
> 164 | csr_write(CSR_TVEC, &handle_exception);
> | ^
> 1 warning and 1 error generated
Offending commits now dropped, thanks.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-02-01 15:08 ` Naresh Kamboju
2025-02-01 15:34 ` Greg Kroah-Hartman
@ 2025-02-01 15:43 ` Guenter Roeck
1 sibling, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2025-02-01 15:43 UTC (permalink / raw)
To: Naresh Kamboju, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On 2/1/25 07:08, Naresh Kamboju wrote:
> On Fri, 31 Jan 2025 at 16:51, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.4.290 release.
>> There are 94 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.290-rc2.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> As other reported,
> the riscv build failed with defconfig with gcc and clang toolchain on the
> stable-rc 5.4.290-rc1 and 5.4.290-rc2
>
> * riscv, build
> - clang-19-allnoconfig
> - clang-19-allyesconfig
> - clang-19-defconfig
> - clang-19-tinyconfig
> - gcc-12-allnoconfig
> - gcc-12-allyesconfig
> - gcc-12-defconfig
> - gcc-12-tinyconfig
> - gcc-8-allnoconfig
> - gcc-8-allyesconfig
> - gcc-8-defconfig
> - gcc-8-tinyconfig
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Build regression: riscv kernel traps.c error: use of undeclared
> identifier 'handle_exception'
>
> Build error:
> ---
> arch/riscv/kernel/traps.c:164:23: error: use of undeclared identifier
> 'handle_exception'
> 164 | csr_write(CSR_TVEC, &handle_exception);
> | ^
> 1 warning and 1 error generated
>
FWIW: Reverting the riscv patches fixes the problem.
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5.4 00/94] 5.4.290-rc2 review
2025-01-31 11:21 [PATCH 5.4 00/94] 5.4.290-rc2 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2025-02-01 15:08 ` Naresh Kamboju
@ 2025-02-02 13:31 ` Harshit Mogalapalli
4 siblings, 0 replies; 12+ messages in thread
From: Harshit Mogalapalli @ 2025-02-02 13:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, Darren Kenny, Vegard Nossum
Hi Greg,
On 31/01/25 16:51, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.290 release.
> There are 94 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 02 Feb 2025 11:20:53 +0000.
> Anything received after that time might be too late.
No problems seen on x86_64 and aarch64 with our testing.
Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thanks,
Harshit
^ permalink raw reply [flat|nested] 12+ messages in thread