* [merged mm-hotfixes-stable] mm-zsmalloc-add-__maybe_unused-attribute-for-is_first_zpdesc.patch removed from -mm tree
@ 2025-02-01 11:53 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2025-02-01 11:53 UTC (permalink / raw)
To: mm-commits, senozhatsky, minchan, lkp, alexs, 42.hyeyoo, akpm
The quilt patch titled
Subject: mm/zsmalloc: add __maybe_unused attribute for is_first_zpdesc()
has been removed from the -mm tree. Its filename was
mm-zsmalloc-add-__maybe_unused-attribute-for-is_first_zpdesc.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: mm/zsmalloc: add __maybe_unused attribute for is_first_zpdesc()
Date: Tue, 28 Jan 2025 08:16:31 +0900
Commit c1b3bb73d55e ("mm/zsmalloc: use zpdesc in
trylock_zspage()/lock_zspage()") introduces is_first_zpdesc() function.
However, the function is only used when CONFIG_DEBUG_VM=y.
When building with LLVM=1 and W=1 option, the following warning is
generated:
$ make -j12 W=1 LLVM=1 mm/zsmalloc.o
mm/zsmalloc.c:455:20: error: function 'is_first_zpdesc' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
455 | static inline bool is_first_zpdesc(struct zpdesc *zpdesc)
| ^~~~~~~~~~~~~~~
1 error generated.
Fix the warning by adding __maybe_unused attribute to the function.
No functional change intended.
Link: https://lkml.kernel.org/r/20250127231631.4363-1-42.hyeyoo@gmail.com
Fixes: c1b3bb73d55e ("mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage()")
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501240958.4ILzuBrH-lkp@intel.com/
Cc: Alex Shi <alexs@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/zsmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/zsmalloc.c~mm-zsmalloc-add-__maybe_unused-attribute-for-is_first_zpdesc
+++ a/mm/zsmalloc.c
@@ -452,7 +452,7 @@ static DEFINE_PER_CPU(struct mapping_are
.lock = INIT_LOCAL_LOCK(lock),
};
-static inline bool is_first_zpdesc(struct zpdesc *zpdesc)
+static inline bool __maybe_unused is_first_zpdesc(struct zpdesc *zpdesc)
{
return PagePrivate(zpdesc_page(zpdesc));
}
_
Patches currently in -mm which might be from 42.hyeyoo@gmail.com are
mm-zswap-fix-inconsistency-when-zswap_store_page-fails.patch
mm-zswap-fix-inconsistency-when-zswap_store_page-fails-fix.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-02-01 11:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-01 11:53 [merged mm-hotfixes-stable] mm-zsmalloc-add-__maybe_unused-attribute-for-is_first_zpdesc.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.