All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
	linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC
Date: Sat, 1 Feb 2025 21:05:49 +0530	[thread overview]
Message-ID: <20250201153549.dusrfjrxxrizmcfa@thinkpad> (raw)
In-Reply-To: <1737428427-32393-8-git-send-email-shawn.lin@rock-chips.com>

On Tue, Jan 21, 2025 at 11:00:27AM +0800, Shawn Lin wrote:
> Add ufshc node to rk3576.dtsi, so the board using UFS could
> enable it.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Small nit below.

> 
> ---
> 
> Changes in v6:
> - remove comments suggested by Mani
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 4dde954..bb786bd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1221,6 +1221,30 @@
>  			};
>  		};
>  
> +		ufshc: ufshc@2a2d0000 {
> +			compatible = "rockchip,rk3576-ufshc";
> +			reg = <0x0 0x2a2d0000 0 0x10000>,
> +			      <0x0 0x2b040000 0 0x10000>,
> +			      <0x0 0x2601f000 0 0x1000>,
> +			      <0x0 0x2603c000 0 0x1000>,
> +			      <0x0 0x2a2e0000 0 0x10000>;

Use 0x0 for consistency.

- Mani

-- 
மணிவண்ணன் சதாசிவம்

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
	linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC
Date: Sat, 1 Feb 2025 21:05:49 +0530	[thread overview]
Message-ID: <20250201153549.dusrfjrxxrizmcfa@thinkpad> (raw)
In-Reply-To: <1737428427-32393-8-git-send-email-shawn.lin@rock-chips.com>

On Tue, Jan 21, 2025 at 11:00:27AM +0800, Shawn Lin wrote:
> Add ufshc node to rk3576.dtsi, so the board using UFS could
> enable it.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Small nit below.

> 
> ---
> 
> Changes in v6:
> - remove comments suggested by Mani
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 4dde954..bb786bd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1221,6 +1221,30 @@
>  			};
>  		};
>  
> +		ufshc: ufshc@2a2d0000 {
> +			compatible = "rockchip,rk3576-ufshc";
> +			reg = <0x0 0x2a2d0000 0 0x10000>,
> +			      <0x0 0x2b040000 0 0x10000>,
> +			      <0x0 0x2601f000 0 0x1000>,
> +			      <0x0 0x2603c000 0 0x1000>,
> +			      <0x0 0x2a2e0000 0 0x10000>;

Use 0x0 for consistency.

- Mani

-- 
மணிவண்ணன் சதாசிவம்

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-02-01 15:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  3:00 [PATCH v6 0/7] Initial support for RK3576 UFS controller Shawn Lin
2025-01-21  3:00 ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 1/7] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-01-21  4:34   ` Rob Herring (Arm)
2025-01-21  4:34     ` Rob Herring (Arm)
2025-01-21  8:02   ` Krzysztof Kozlowski
2025-01-21  8:02     ` Krzysztof Kozlowski
2025-01-22  1:01     ` Shawn Lin
2025-01-22  1:01       ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 2/7] soc: rockchip: add header for suspend mode SIP interface Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 3/7] pmdomain: core: Introduce dev_pm_genpd_rpm_always_on() Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 4/7] pmdomain: rockchip: Add smc call to inform firmware Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 5/7] scsi: ufs: core: Export ufshcd_dme_reset() and ufshcd_dme_enable() Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-01-21  3:00 ` [PATCH v6 6/7] scsi: ufs: rockchip: initial support for UFS Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-02-01 15:34   ` Manivannan Sadhasivam
2025-02-01 15:34     ` Manivannan Sadhasivam
2025-01-21  3:00 ` [PATCH v6 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC Shawn Lin
2025-01-21  3:00   ` Shawn Lin
2025-02-01 15:35   ` Manivannan Sadhasivam [this message]
2025-02-01 15:35     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250201153549.dusrfjrxxrizmcfa@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=cl@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=zyf@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.