From: Conor Dooley <conor@kernel.org>
To: Basharath Hussain Khaja <basharath@couthit.com>
Cc: nm <nm@ti.com>, vigneshr <vigneshr@ti.com>,
tony <tony@atomide.com>, edumazet <edumazet@google.com>,
krishna <krishna@couthit.com>, pmohan <pmohan@couthit.com>,
diogo ivo <diogo.ivo@siemens.com>, Rob Herring <robh@kernel.org>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
praneeth <praneeth@ti.com>, m-karicheri2 <m-karicheri2@ti.com>,
jacob e keller <jacob.e.keller@intel.com>, kuba <kuba@kernel.org>,
pabeni <pabeni@redhat.com>,
devicetree <devicetree@vger.kernel.org>,
conor+dt <conor+dt@kernel.org>, schnelle <schnelle@linux.ibm.com>,
mohan <mohan@couthit.com>,
richardcochran <richardcochran@gmail.com>,
prajith <prajith@ti.com>, rogerq <rogerq@kernel.org>,
ssantosh <ssantosh@kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
rogerq <rogerq@ti.com>, srk <srk@ti.com>,
pratheesh <pratheesh@ti.com>, m-malladi <m-malladi@ti.com>,
netdev <netdev@vger.kernel.org>, rdunlap <rdunlap@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
danishanwar <danishanwar@ti.com>, afd <afd@ti.com>,
andrew+netdev <andrew+netdev@lunn.ch>,
parvathi <parvathi@couthit.com>, horms <horms@kernel.org>,
krzk+dt <krzk+dt@kernel.org>, davem <davem@davemloft.net>
Subject: Re: [RFC v2 PATCH 01/10] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs
Date: Tue, 4 Feb 2025 18:16:17 +0000 [thread overview]
Message-ID: <20250204-mutilated-throwing-59cabf18f187@spud> (raw)
In-Reply-To: <2028988664.494856.1738585795471.JavaMail.zimbra@couthit.local>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Mon, Feb 03, 2025 at 05:59:55PM +0530, Basharath Hussain Khaja wrote:
> >> >> + $ref: /schemas/types.yaml#/definitions/phandle
> >> >> + description:
> >> >> + phandle to Enhanced Capture (eCAP) event for ICSS
> >> >
> >> > Why do you need phandles for these things, can they not be looked up by
> >> > compatible? (e.g. multiple devices on one SoC).
> >> >
> >>
> >> ecap is another peripheral similar to IEP in ICSSM/ICSSG. We have created a
> >> separate driver for possible reuse with ICSSG in future.
> >
> > That's not an answer to my question.
> >
>
> We can use compatible if we have only one instance of a peripheral in the SOC.
> On the AM57x SOC we have two identical ICSS instances(ICSS1 and ICSS2). So we
> use phandles to differentiate between the two instances. Currently this patch
> series adds support for ICSS2 instance on the AM57x SOC. Support for ICSS1 instance
> will be added in subsequent patches.
Cool, that's an acceptance answer, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Basharath Hussain Khaja <basharath@couthit.com>
Cc: danishanwar <danishanwar@ti.com>, rogerq <rogerq@kernel.org>,
andrew+netdev <andrew+netdev@lunn.ch>,
davem <davem@davemloft.net>, edumazet <edumazet@google.com>,
kuba <kuba@kernel.org>, pabeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>, krzk+dt <krzk+dt@kernel.org>,
conor+dt <conor+dt@kernel.org>, nm <nm@ti.com>,
ssantosh <ssantosh@kernel.org>, tony <tony@atomide.com>,
richardcochran <richardcochran@gmail.com>,
parvathi <parvathi@couthit.com>,
schnelle <schnelle@linux.ibm.com>,
rdunlap <rdunlap@infradead.org>,
diogo ivo <diogo.ivo@siemens.com>,
m-karicheri2 <m-karicheri2@ti.com>, horms <horms@kernel.org>,
jacob e keller <jacob.e.keller@intel.com>,
m-malladi <m-malladi@ti.com>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
afd <afd@ti.com>, s-anna <s-anna@ti.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
pratheesh <pratheesh@ti.com>, prajith <prajith@ti.com>,
vigneshr <vigneshr@ti.com>, praneeth <praneeth@ti.com>,
srk <srk@ti.com>, rogerq <rogerq@ti.com>,
krishna <krishna@couthit.com>, pmohan <pmohan@couthit.com>,
mohan <mohan@couthit.com>
Subject: Re: [RFC v2 PATCH 01/10] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs
Date: Tue, 4 Feb 2025 18:16:17 +0000 [thread overview]
Message-ID: <20250204-mutilated-throwing-59cabf18f187@spud> (raw)
In-Reply-To: <2028988664.494856.1738585795471.JavaMail.zimbra@couthit.local>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Mon, Feb 03, 2025 at 05:59:55PM +0530, Basharath Hussain Khaja wrote:
> >> >> + $ref: /schemas/types.yaml#/definitions/phandle
> >> >> + description:
> >> >> + phandle to Enhanced Capture (eCAP) event for ICSS
> >> >
> >> > Why do you need phandles for these things, can they not be looked up by
> >> > compatible? (e.g. multiple devices on one SoC).
> >> >
> >>
> >> ecap is another peripheral similar to IEP in ICSSM/ICSSG. We have created a
> >> separate driver for possible reuse with ICSSG in future.
> >
> > That's not an answer to my question.
> >
>
> We can use compatible if we have only one instance of a peripheral in the SOC.
> On the AM57x SOC we have two identical ICSS instances(ICSS1 and ICSS2). So we
> use phandles to differentiate between the two instances. Currently this patch
> series adds support for ICSS2 instance on the AM57x SOC. Support for ICSS1 instance
> will be added in subsequent patches.
Cool, that's an acceptance answer, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-02-04 18:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 12:23 [RFC v2 PATCH 00/10] PRU-ICSSM Ethernet Driver Basharath Hussain Khaja
2025-01-24 12:23 ` [RFC v2 PATCH 01/10] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs Basharath Hussain Khaja
2025-01-24 16:39 ` Conor Dooley
2025-01-24 16:39 ` Conor Dooley
2025-01-29 5:16 ` Basharath Hussain Khaja
2025-01-29 5:16 ` Basharath Hussain Khaja
2025-01-29 17:48 ` Conor Dooley
2025-01-29 17:48 ` Conor Dooley
2025-02-03 12:29 ` Basharath Hussain Khaja
2025-02-03 12:29 ` Basharath Hussain Khaja
2025-02-04 18:16 ` Conor Dooley [this message]
2025-02-04 18:16 ` Conor Dooley
2025-01-24 12:23 ` [RFC v2 PATCH 02/10] net: ti: prueth: Adds ICSSM Ethernet driver Basharath Hussain Khaja
2025-01-30 11:41 ` Simon Horman
2025-01-30 11:41 ` Simon Horman
2025-02-01 13:25 ` Basharath Hussain Khaja
2025-02-01 13:25 ` Basharath Hussain Khaja
2025-01-24 12:23 ` [RFC v2 PATCH 03/10] net: ti: prueth: Adds PRUETH HW and SW configuration Basharath Hussain Khaja
2025-01-30 15:47 ` Simon Horman
2025-01-30 15:47 ` Simon Horman
2025-02-01 13:34 ` Basharath Hussain Khaja
2025-02-01 13:34 ` Basharath Hussain Khaja
2025-01-24 12:37 ` [RFC v2 PATCH 04/10] net: ti: prueth: Adds link detection, RX and TX support Basharath Hussain Khaja
2025-01-24 23:13 ` Joe Damato
2025-01-24 23:13 ` Joe Damato
2025-01-29 5:41 ` Basharath Hussain Khaja
2025-01-29 5:41 ` Basharath Hussain Khaja
2025-01-30 16:45 ` Simon Horman
2025-01-30 16:45 ` Simon Horman
2025-02-01 13:37 ` Basharath Hussain Khaja
2025-02-01 13:37 ` Basharath Hussain Khaja
2025-01-24 13:40 ` Basharath Hussain Khaja
2025-01-24 23:20 ` Joe Damato
2025-01-24 23:20 ` Joe Damato
2025-01-29 5:43 ` Basharath Hussain Khaja
2025-01-29 5:43 ` Basharath Hussain Khaja
2025-01-24 13:40 ` [RFC v2 PATCH 05/10] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver Basharath Hussain Khaja
2025-01-30 17:23 ` Simon Horman
2025-01-30 17:23 ` Simon Horman
2025-02-01 13:48 ` Basharath Hussain Khaja
2025-02-01 13:48 ` Basharath Hussain Khaja
2025-01-24 13:40 ` [RFC v2 PATCH 06/10] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module Basharath Hussain Khaja
2025-01-31 10:33 ` Simon Horman
2025-01-31 10:33 ` Simon Horman
2025-02-05 12:24 ` Basharath Hussain Khaja
2025-02-05 12:24 ` Basharath Hussain Khaja
2025-01-24 13:40 ` [RFC v2 PATCH 07/10] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS Basharath Hussain Khaja
2025-01-24 14:45 ` [RFC v2 PATCH 08/10] net: ti: prueth: Adds support for RX interrupt coalescing/pacing Basharath Hussain Khaja
2025-01-24 14:45 ` [RFC v2 PATCH 09/10] net: ti: prueth: Adds power management support for PRU-ICSS Basharath Hussain Khaja
2025-01-24 14:45 ` [RFC v2 PATCH 10/10] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance Basharath Hussain Khaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204-mutilated-throwing-59cabf18f187@spud \
--to=conor@kernel.org \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=schnelle@linux.ibm.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.