From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Ovchinnikov Vitalii" <vitalii.ovchinnikov@auriga.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jared Mauch" <jared+home@puck.nether.net>,
"Fabiano Rosas" <farosas@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
devel@lists.libvirt.org
Subject: [PATCH v2 07/12] hw/arm/raspi: Check ramsize is within chipset aperture
Date: Tue, 4 Feb 2025 01:22:35 +0100 [thread overview]
Message-ID: <20250204002240.97830-8-philmd@linaro.org> (raw)
In-Reply-To: <20250204002240.97830-1-philmd@linaro.org>
Add the 'max_ramsize' field to the soc_property[] array,
corresponding to the maximum DRAM size a SoC can map.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/raspi.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
index 68332fba027..d44277001ee 100644
--- a/hw/arm/raspi.c
+++ b/hw/arm/raspi.c
@@ -76,11 +76,12 @@ typedef enum RaspiProcessorId {
static const struct {
const char *type;
int cores_count;
+ uint64_t max_ramsize;
} soc_property[] = {
- [PROCESSOR_ID_BCM2835] = {TYPE_BCM2835, 1},
- [PROCESSOR_ID_BCM2836] = {TYPE_BCM2836, BCM283X_NCPUS},
- [PROCESSOR_ID_BCM2837] = {TYPE_BCM2837, BCM283X_NCPUS},
- [PROCESSOR_ID_BCM2838] = {TYPE_BCM2838, BCM283X_NCPUS},
+ [PROCESSOR_ID_BCM2835] = {TYPE_BCM2835, 1, 512 * MiB},
+ [PROCESSOR_ID_BCM2836] = {TYPE_BCM2836, BCM283X_NCPUS, 1 * GiB},
+ [PROCESSOR_ID_BCM2837] = {TYPE_BCM2837, BCM283X_NCPUS, 1 * GiB},
+ [PROCESSOR_ID_BCM2838] = {TYPE_BCM2838, BCM283X_NCPUS, 8 * GiB},
};
static const struct {
@@ -133,6 +134,11 @@ static int cores_count(uint32_t board_rev)
return soc_property[board_processor_id(board_rev)].cores_count;
}
+static uint64_t ramsize_max(uint32_t board_rev)
+{
+ return soc_property[board_processor_id(board_rev)].max_ramsize;
+}
+
static const char *board_type(uint32_t board_rev)
{
assert(FIELD_EX32(board_rev, REV_CODE, STYLE)); /* Only new style */
@@ -294,6 +300,7 @@ void raspi_base_machine_init(MachineState *machine,
BlockBackend *blk;
BusState *bus;
DeviceState *carddev;
+ uint64_t max_ramsize;
if (machine->ram_size != ram_size) {
char *size_str = size_to_str(ram_size);
@@ -301,6 +308,12 @@ void raspi_base_machine_init(MachineState *machine,
g_free(size_str);
exit(1);
}
+ max_ramsize = ramsize_max(board_rev);
+ if (ram_size > max_ramsize) {
+ g_autofree char *max_ramsize_str = size_to_str(max_ramsize);
+ error_report("At most %s of RAM can be used", max_ramsize_str);
+ exit(1);
+ }
/* FIXME: Remove when we have custom CPU address space support */
memory_region_add_subregion_overlap(get_system_memory(), 0,
--
2.47.1
next prev parent reply other threads:[~2025-02-04 0:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 0:22 [PATCH v2 00/12] hw/arm/raspi: Allow creating any Raspberry Pi machine Philippe Mathieu-Daudé
2025-02-04 0:22 ` [PATCH v2 01/12] hw/arm/raspi: Access SoC parent object using BCM283X_BASE() macro Philippe Mathieu-Daudé
2025-02-04 0:22 ` Philippe Mathieu-Daudé
2025-02-04 15:01 ` Peter Maydell
2025-02-04 0:22 ` [PATCH v2 02/12] hw/arm/raspi: Merge model 4B with other models Philippe Mathieu-Daudé
2025-02-04 15:02 ` Peter Maydell
2025-02-04 0:22 ` [PATCH v2 03/12] hw/arm/raspi: Unify RASPI_MACHINE types Philippe Mathieu-Daudé
2025-02-04 15:06 ` Peter Maydell
2025-02-04 0:22 ` [PATCH v2 04/12] hw/arm/raspi: Pass board_rev as argument to raspi_base_machine_init() Philippe Mathieu-Daudé
2025-02-04 0:22 ` [PATCH v2 05/12] hw/arm/raspi: Consider processor id in types[] array Philippe Mathieu-Daudé
2025-02-04 15:08 ` Peter Maydell
2025-02-04 0:22 ` [PATCH v2 06/12] hw/arm/raspi: Consider network interface for B models Philippe Mathieu-Daudé
2025-02-04 15:09 ` Peter Maydell
2025-02-04 0:22 ` Philippe Mathieu-Daudé [this message]
2025-02-04 15:10 ` [PATCH v2 07/12] hw/arm/raspi: Check ramsize is within chipset aperture Peter Maydell
2025-02-04 0:22 ` [PATCH v2 08/12] hw/arm/raspi: Introduce generic Raspberry Pi machine Philippe Mathieu-Daudé
2025-02-04 0:22 ` [PATCH v2 09/12] hw/arm/raspi: Have the generic machine take a 'revision' property Philippe Mathieu-Daudé
2025-02-04 0:22 ` [PATCH v2 10/12] hw/arm/raspi: List models creatable by the generic 'raspi' machine Philippe Mathieu-Daudé
2025-02-04 0:22 ` [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names Philippe Mathieu-Daudé
2025-02-04 9:22 ` Peter Maydell
2025-02-04 9:51 ` Philippe Mathieu-Daudé
2025-02-04 9:57 ` Daniel P. Berrangé
2025-02-04 10:48 ` Philippe Mathieu-Daudé
2025-02-04 10:51 ` Daniel P. Berrangé
2025-02-04 11:13 ` Peter Maydell
2025-02-04 13:40 ` Philippe Mathieu-Daudé
2025-02-04 13:52 ` Peter Maydell
2025-02-04 14:59 ` Philippe Mathieu-Daudé
2025-02-04 9:58 ` BALATON Zoltan
2025-02-22 21:57 ` Jared Mauch
2025-02-04 0:22 ` [PATCH v2 12/12] hw/arm/raspi: Support more models Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204002240.97830-8-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=farosas@suse.de \
--cc=jared+home@puck.nether.net \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vitalii.ovchinnikov@auriga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.