[PATCH rdma-next] RDMA/bnxt_re: Fix the error due to the array depth

[PATCH rdma-next] RDMA/bnxt_re: Fix the error due to the array depth

[Selvin Xavier]

Fixing the issue reported by kernel test robot

drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope

Using the fixed size depth for the array.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502041114.K8XQYeJg-lkp@intel.com/
Fixes: a3c71713d954 ("RDMA/bnxt_re: Congestion control settings using debugfs hook")
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/debugfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/debugfs.h b/drivers/infiniband/hw/bnxt_re/debugfs.h
index 3374097..8f101df 100644
--- a/drivers/infiniband/hw/bnxt_re/debugfs.h
+++ b/drivers/infiniband/hw/bnxt_re/debugfs.h
@@ -21,7 +21,7 @@ void bnxt_re_unregister_debugfs(void);
 #define CC_CONFIG_GEN_EXT(x, y)	(((x) << 16) | (y))
 #define CC_CONFIG_GEN0_EXT0  CC_CONFIG_GEN_EXT(0, 0)
 
-#define BNXT_RE_CC_PARAM_GEN0	__ffs(CMDQ_MODIFY_ROCE_CC_MODIFY_MASK_INACTIVITY_CP)
+#define BNXT_RE_CC_PARAM_GEN0  14
 
 struct bnxt_re_cc_param {
 	struct bnxt_re_dev *rdev;
@@ -31,6 +31,6 @@ struct bnxt_re_cc_param {
 };
 
 struct bnxt_re_dbg_cc_config_params {
-	struct bnxt_re_cc_param        gen0_parms[BNXT_RE_CC_PARAM_GEN0];
+	struct bnxt_re_cc_param	gen0_parms[BNXT_RE_CC_PARAM_GEN0];
 };
 #endif
-- 
2.5.5

Re: [PATCH rdma-next] RDMA/bnxt_re: Fix the error due to the array depth

[Leon Romanovsky]

On Tue, Feb 04, 2025 at 01:06:06AM -0800, Selvin Xavier wrote:
> Fixing the issue reported by kernel test robot
> 
> drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope
> 
> Using the fixed size depth for the array.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502041114.K8XQYeJg-lkp@intel.com/
> Fixes: a3c71713d954 ("RDMA/bnxt_re: Congestion control settings using debugfs hook")
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/debugfs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, I squashed this patch into "RDMA/bnxt_re: Congestion control
settings using debugfs hook".

Re: [PATCH rdma-next] RDMA/bnxt_re: Fix the error due to the array depth

[Selvin Xavier]

On Tue, Feb 4, 2025 at 3:26 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Tue, Feb 04, 2025 at 01:06:06AM -0800, Selvin Xavier wrote:
> > Fixing the issue reported by kernel test robot
> >
> > drivers/infiniband/hw/bnxt_re/debugfs.h:34:40: error: variably modified 'gen0_parms' at file scope
> >
> > Using the fixed size depth for the array.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202502041114.K8XQYeJg-lkp@intel.com/
> > Fixes: a3c71713d954 ("RDMA/bnxt_re: Congestion control settings using debugfs hook")
> > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> > ---
> >  drivers/infiniband/hw/bnxt_re/debugfs.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks, I squashed this patch into "RDMA/bnxt_re: Congestion control
> settings using debugfs hook".
Sure thanks