From: Brian Foster <bfoster@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: [PATCH v4 06/10] iomap: export iomap_iter_advance() and return remaining length
Date: Tue, 4 Feb 2025 08:30:40 -0500 [thread overview]
Message-ID: <20250204133044.80551-7-bfoster@redhat.com> (raw)
In-Reply-To: <20250204133044.80551-1-bfoster@redhat.com>
As a final step for generic iter advance, export the helper and
update it to return the remaining length of the current iteration
after the advance. This will usually be 0 in the iomap_iter() case,
but will be useful for the various operations that iterate on their
own and will be updated to advance as they progress.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
fs/iomap/iter.c | 28 ++++++++++++----------------
include/linux/iomap.h | 1 +
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
index 04bd39ee5d47..cdba24dbbfd7 100644
--- a/fs/iomap/iter.c
+++ b/fs/iomap/iter.c
@@ -15,22 +15,16 @@ static inline void iomap_iter_reset_iomap(struct iomap_iter *iter)
}
/*
- * Advance to the next range we need to map.
- *
- * If the iomap is marked IOMAP_F_STALE, it means the existing map was not fully
- * processed - it was aborted because the extent the iomap spanned may have been
- * changed during the operation. In this case, the iteration behaviour is to
- * remap the unprocessed range of the iter, and that means we may need to remap
- * even when we've made no progress (i.e. count = 0). Hence the "finished
- * iterating" case needs to distinguish between (count = 0) meaning we are done
- * and (count = 0 && stale) meaning we need to remap the entire remaining range.
+ * Advance the current iterator position and return the length remaining for the
+ * current mapping.
*/
-static inline int iomap_iter_advance(struct iomap_iter *iter, s64 count)
+int iomap_iter_advance(struct iomap_iter *iter, u64 *count)
{
- if (WARN_ON_ONCE(count > iomap_length(iter)))
+ if (WARN_ON_ONCE(*count > iomap_length(iter)))
return -EIO;
- iter->pos += count;
- iter->len -= count;
+ iter->pos += *count;
+ iter->len -= *count;
+ *count = iomap_length(iter);
return 0;
}
@@ -64,6 +58,7 @@ static inline void iomap_iter_done(struct iomap_iter *iter)
int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)
{
bool stale = iter->iomap.flags & IOMAP_F_STALE;
+ s64 processed;
int ret;
trace_iomap_iter(iter, ops, _RET_IP_);
@@ -79,9 +74,10 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)
return ret;
}
- if (iter->processed < 0) {
+ processed = iter->processed;
+ if (processed < 0) {
iomap_iter_reset_iomap(iter);
- return iter->processed;
+ return processed;
}
/*
@@ -91,7 +87,7 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)
* advanced at all (i.e. no work was done for some reason) unless the
* mapping has been marked stale and needs to be reprocessed.
*/
- ret = iomap_iter_advance(iter, iter->processed);
+ ret = iomap_iter_advance(iter, &processed);
if (!ret && iter->len > 0)
ret = 1;
if (ret > 0 && !iter->processed && !stale)
diff --git a/include/linux/iomap.h b/include/linux/iomap.h
index f5ca71ac2fa2..f304c602e5fe 100644
--- a/include/linux/iomap.h
+++ b/include/linux/iomap.h
@@ -229,6 +229,7 @@ struct iomap_iter {
};
int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops);
+int iomap_iter_advance(struct iomap_iter *iter, u64 *count);
/**
* iomap_length_trim - trimmed length of the current iomap iteration
--
2.48.1
next prev parent reply other threads:[~2025-02-04 13:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:30 [PATCH v4 00/10] iomap: incremental per-operation iter advance Brian Foster
2025-02-04 13:30 ` [PATCH v4 01/10] iomap: factor out iomap length helper Brian Foster
2025-02-04 13:30 ` [PATCH v4 02/10] iomap: split out iomap check and reset logic from iter advance Brian Foster
2025-02-04 19:30 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 03/10] iomap: refactor iomap_iter() length check and tracepoint Brian Foster
2025-02-04 13:50 ` Christoph Hellwig
2025-02-04 13:30 ` [PATCH v4 04/10] iomap: lift error code check out of iomap_iter_advance() Brian Foster
2025-02-04 13:51 ` Christoph Hellwig
2025-02-04 19:23 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 05/10] iomap: lift iter termination logic from iomap_iter_advance() Brian Foster
2025-02-04 13:51 ` Christoph Hellwig
2025-02-04 19:52 ` Darrick J. Wong
2025-02-04 20:15 ` Brian Foster
2025-02-04 13:30 ` Brian Foster [this message]
2025-02-04 13:52 ` [PATCH v4 06/10] iomap: export iomap_iter_advance() and return remaining length Christoph Hellwig
2025-02-04 13:30 ` [PATCH v4 07/10] iomap: support incremental iomap_iter advances Brian Foster
2025-02-04 13:30 ` [PATCH v4 08/10] iomap: advance the iter directly on buffered writes Brian Foster
2025-02-04 13:30 ` [PATCH v4 09/10] iomap: advance the iter directly on unshare range Brian Foster
2025-02-04 13:30 ` [PATCH v4 10/10] iomap: advance the iter directly on zero range Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204133044.80551-7-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.