From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v4 06/10] iomap: export iomap_iter_advance() and return remaining length
Date: Tue, 4 Feb 2025 05:52:20 -0800 [thread overview]
Message-ID: <Z6IblMMbjCONHPDj@infradead.org> (raw)
In-Reply-To: <20250204133044.80551-7-bfoster@redhat.com>
On Tue, Feb 04, 2025 at 08:30:40AM -0500, Brian Foster wrote:
> As a final step for generic iter advance, export the helper and
> update it to return the remaining length of the current iteration
> after the advance. This will usually be 0 in the iomap_iter() case,
> but will be useful for the various operations that iterate on their
> own and will be updated to advance as they progress.
Normally we use export for adding EXPORT_SYMBOL*, so the subject
confused me a bit. The patch itself looks good, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-02-04 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:30 [PATCH v4 00/10] iomap: incremental per-operation iter advance Brian Foster
2025-02-04 13:30 ` [PATCH v4 01/10] iomap: factor out iomap length helper Brian Foster
2025-02-04 13:30 ` [PATCH v4 02/10] iomap: split out iomap check and reset logic from iter advance Brian Foster
2025-02-04 19:30 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 03/10] iomap: refactor iomap_iter() length check and tracepoint Brian Foster
2025-02-04 13:50 ` Christoph Hellwig
2025-02-04 13:30 ` [PATCH v4 04/10] iomap: lift error code check out of iomap_iter_advance() Brian Foster
2025-02-04 13:51 ` Christoph Hellwig
2025-02-04 19:23 ` Darrick J. Wong
2025-02-04 19:48 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 05/10] iomap: lift iter termination logic from iomap_iter_advance() Brian Foster
2025-02-04 13:51 ` Christoph Hellwig
2025-02-04 19:52 ` Darrick J. Wong
2025-02-04 20:15 ` Brian Foster
2025-02-04 13:30 ` [PATCH v4 06/10] iomap: export iomap_iter_advance() and return remaining length Brian Foster
2025-02-04 13:52 ` Christoph Hellwig [this message]
2025-02-04 13:30 ` [PATCH v4 07/10] iomap: support incremental iomap_iter advances Brian Foster
2025-02-04 13:30 ` [PATCH v4 08/10] iomap: advance the iter directly on buffered writes Brian Foster
2025-02-04 13:30 ` [PATCH v4 09/10] iomap: advance the iter directly on unshare range Brian Foster
2025-02-04 13:30 ` [PATCH v4 10/10] iomap: advance the iter directly on zero range Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6IblMMbjCONHPDj@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.