Re: [brauner-vfs:vfs-6.15.misc 2/3] mm/gup.c:2270: warning: Function parameter or struct member 'locked' not described in 'get_dump_page'

[Christian Brauner <brauner@kernel.org>]

On Wed, Feb 05, 2025 at 01:35:26PM +0100, Mateusz Guzik wrote:
> On Wed, Feb 5, 2025 at 1:20 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs-6.15.misc
> > head:   625aec60ff1462a0620753deeec4a38ddd032e29
> > commit: 62801d0e24907a20b4724b58ce174bc9a2fc3b4c [2/3] fs: avoid mmap sem relocks when coredumping with many missing pages
> > config: i386-buildonly-randconfig-003-20250205 (https://download.01.org/0day-ci/archive/20250205/202502052058.brmQ0100-lkp@intel.com/config)
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250205/202502052058.brmQ0100-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202502052058.brmQ0100-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> mm/gup.c:2270: warning: Function parameter or struct member 'locked' not described in 'get_dump_page'
> >
> 
> how about this:
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 3883b307780e..66d2aec76d99 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -2254,6 +2254,7 @@ EXPORT_SYMBOL(fault_in_readable);
>  /**
>   * get_dump_page() - pin user page in memory while writing it to core dump
>   * @addr: user address
> + * @locked: a pointer to an int denoting whether the mmap sem is held
>   *
>   * Returns struct page pointer of user page pinned for dump,
>   * to be freed afterwards by put_page().
> 
> I presume I can avoid sending a full v2 :)

Yes, I already folded your fix. :)