From: kernel test robot <lkp@intel.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Christian Brauner <christianvanbrauner@gmail.com>,
Christian Brauner <brauner@kernel.org>
Subject: [brauner-vfs:vfs-6.15.misc 2/3] mm/gup.c:2270: warning: Function parameter or struct member 'locked' not described in 'get_dump_page'
Date: Wed, 5 Feb 2025 20:20:22 +0800 [thread overview]
Message-ID: <202502052058.brmQ0100-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs-6.15.misc
head: 625aec60ff1462a0620753deeec4a38ddd032e29
commit: 62801d0e24907a20b4724b58ce174bc9a2fc3b4c [2/3] fs: avoid mmap sem relocks when coredumping with many missing pages
config: i386-buildonly-randconfig-003-20250205 (https://download.01.org/0day-ci/archive/20250205/202502052058.brmQ0100-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250205/202502052058.brmQ0100-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502052058.brmQ0100-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> mm/gup.c:2270: warning: Function parameter or struct member 'locked' not described in 'get_dump_page'
vim +2270 mm/gup.c
bb523b406c849e Andreas Gruenbacher 2021-08-02 2253
8f942eea12ae8c Jann Horn 2020-10-15 2254 /**
8f942eea12ae8c Jann Horn 2020-10-15 2255 * get_dump_page() - pin user page in memory while writing it to core dump
8f942eea12ae8c Jann Horn 2020-10-15 2256 * @addr: user address
8f942eea12ae8c Jann Horn 2020-10-15 2257 *
8f942eea12ae8c Jann Horn 2020-10-15 2258 * Returns struct page pointer of user page pinned for dump,
8f942eea12ae8c Jann Horn 2020-10-15 2259 * to be freed afterwards by put_page().
8f942eea12ae8c Jann Horn 2020-10-15 2260 *
8f942eea12ae8c Jann Horn 2020-10-15 2261 * Returns NULL on any kind of failure - a hole must then be inserted into
8f942eea12ae8c Jann Horn 2020-10-15 2262 * the corefile, to preserve alignment with its headers; and also returns
8f942eea12ae8c Jann Horn 2020-10-15 2263 * NULL wherever the ZERO_PAGE, or an anonymous pte_none, has been found -
8f942eea12ae8c Jann Horn 2020-10-15 2264 * allowing a hole to be left in the corefile to save disk space.
8f942eea12ae8c Jann Horn 2020-10-15 2265 *
7f3bfab52cab96 Jann Horn 2020-10-15 2266 * Called without mmap_lock (takes and releases the mmap_lock by itself).
8f942eea12ae8c Jann Horn 2020-10-15 2267 */
8f942eea12ae8c Jann Horn 2020-10-15 2268 #ifdef CONFIG_ELF_CORE
62801d0e24907a Mateusz Guzik 2025-01-19 2269 struct page *get_dump_page(unsigned long addr, int *locked)
8f942eea12ae8c Jann Horn 2020-10-15 @2270 {
8f942eea12ae8c Jann Horn 2020-10-15 2271 struct page *page;
7f3bfab52cab96 Jann Horn 2020-10-15 2272 int ret;
8f942eea12ae8c Jann Horn 2020-10-15 2273
62801d0e24907a Mateusz Guzik 2025-01-19 2274 ret = __get_user_pages_locked(current->mm, addr, 1, &page, locked,
7f3bfab52cab96 Jann Horn 2020-10-15 2275 FOLL_FORCE | FOLL_DUMP | FOLL_GET);
7f3bfab52cab96 Jann Horn 2020-10-15 2276 return (ret == 1) ? page : NULL;
8f942eea12ae8c Jann Horn 2020-10-15 2277 }
8f942eea12ae8c Jann Horn 2020-10-15 2278 #endif /* CONFIG_ELF_CORE */
8f942eea12ae8c Jann Horn 2020-10-15 2279
:::::: The code at line 2270 was first introduced by commit
:::::: 8f942eea12ae8c5a7cde85c145234b25e38de959 binfmt_elf_fdpic: stop using dump_emit() on user pointers on !MMU
:::::: TO: Jann Horn <jannh@google.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-02-05 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 12:20 kernel test robot [this message]
2025-02-05 12:35 ` [brauner-vfs:vfs-6.15.misc 2/3] mm/gup.c:2270: warning: Function parameter or struct member 'locked' not described in 'get_dump_page' Mateusz Guzik
2025-02-05 13:50 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502052058.brmQ0100-lkp@intel.com \
--to=lkp@intel.com \
--cc=brauner@kernel.org \
--cc=christianvanbrauner@gmail.com \
--cc=mjguzik@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.