Re: [Buildroot] [PATCH] package/lxc: add libapparmor optional dependency

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Ian,

Thanks for your patch!

On Wed, 29 Jan 2025 19:46:22 +0000
Ian Merin via buildroot <buildroot@buildroot.org> wrote:

> From e56f77419a6516fef7f63746120755400948e5d3 Mon Sep 17 00:00:00 2001
> From: Ian Merin <Ian.Merin@ncipher.com>
> Date: Wed, 29 Jan 2025 11:15:20 -0500
> Subject: [PATCH] package/lxc: add libapparmor optional dependency

You didn't use git send-email to send your patch, which made it
difficult to apply. Indeed, it looks like you pasted the output of "git
format-patch" into the body of an e-mail, making the resulting e-mail
unapplicable by "git am".

> diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
> index b2afb978e6..d2227c3760 100644
> --- a/package/lxc/lxc.mk
> +++ b/package/lxc/lxc.mk
> @@ -13,7 +13,6 @@ LXC_DEPENDENCIES = host-pkgconf
> LXC_INSTALL_STAGING = YES
> 
> LXC_CONF_OPTS = \
> -       -Dapparmor=false \
>        -Dexamples=false \
>        -Dman=false
> 
> @@ -21,6 +20,13 @@ ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
> LXC_DEPENDENCIES += bash-completion
> endif
> 
> +ifeq ($(BR2_PACKAGE_APPARMOR),y)

           ^^^^^^^^ This option doesn't exist, so this never triggers.
           The option is named BR2_PACKAGE_LIBAPPARMOR.

I fixed both issues and applied. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot