From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Ian Merin <Ian.Merin@entrust.com>
Cc: Ian Merin via buildroot <buildroot@buildroot.org>,
"jezz@sysmic.org" <jezz@sysmic.org>
Subject: Re: [Buildroot] [EXTERNAL] Re: [PATCH] package/lxc: add libapparmor optional dependency
Date: Wed, 5 Feb 2025 16:00:43 +0100 [thread overview]
Message-ID: <20250205160043.288fabbf@windsurf> (raw)
In-Reply-To: <BN7PR11MB2788EEDD81A7788DA6F9FC2AFFF72@BN7PR11MB2788.namprd11.prod.outlook.com>
Hello Ian,
On Wed, 5 Feb 2025 14:49:37 +0000
Ian Merin <Ian.Merin@entrust.com> wrote:
> BR2_PACKAGE_APPARMOR certainly does exist, and the patch works for me as written:
>
> https://github.com/buildroot/buildroot/blob/master/package/apparmor/Config.in#L1
>
> BR2_PACKAGE_LIBAPPARMOR is selected as a dependency of BR2_PACKAGE_APPARMOR
Sorry, I missed that. I had only enabled BR2_PACKAGE_LIBAPPARMOR in my
configuration. However, it doesn't really make sense to have a
condition on option XYZ and then depend on another package. Here the
dependency that's needed by lxc is indeed libapparmor, which is the
dependency you added in LXC_DEPENDENCIES:
+LXC_DEPENDENCIES += libapparmor
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-02-05 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 19:46 [Buildroot] [PATCH] package/lxc: add libapparmor optional dependency Ian Merin via buildroot
2025-02-05 14:33 ` Thomas Petazzoni via buildroot
2025-02-05 14:49 ` [Buildroot] [EXTERNAL] " Ian Merin via buildroot
2025-02-05 15:00 ` Thomas Petazzoni [this message]
2025-02-05 15:19 ` Ian Merin via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205160043.288fabbf@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=Ian.Merin@entrust.com \
--cc=buildroot@buildroot.org \
--cc=jezz@sysmic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.