Re: [Buildroot] [PATCHv2 1/2] package/avahi: add missing dependency.

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 27 Jan 2025 10:17:10 +0100
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> libavahi-client is not built if dbus is not installed.
> 
> Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
> ---
>  package/avahi/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/avahi/Config.in b/package/avahi/Config.in
> index 728bc4fdd1..ae53aaf156 100644
> --- a/package/avahi/Config.in
> +++ b/package/avahi/Config.in
> @@ -39,6 +39,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
>  config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
>  	bool
>  	default y if BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_DBUS

I understand your idea, but this is not what this option is about. This
option is not a typical visible option, with a prompt in menuconfig to
enable/disable avahi-client.

Instead it's a blind option that other packages can observe (but not
select!) to know if libavahi-client will be available or not.

And indeed, as soon as D-Bus is enabled,
BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT becomes true, telling other packages
that libavahi-client will be there.

So your PATCH 2/2 needs to select BR2_PACKAGE_AVAHI and
BR2_PACKAGE_DBUS, which will ensure libavahi-client gets built.

The problem with having an option is that we can't disable it. So if we
make it a visible option, and a user keeps it disabled... we have no
way to tell avahi to not build libavahi-client: as soon as D-Bus is
there, libavahi-client will be built.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot