[Buildroot] [PATCHv2 1/2] package/avahi: add missing dependency.

[Buildroot] [PATCHv2 1/2] package/avahi: add missing dependency.

[Guillaume Chaye]

libavahi-client is not built if dbus is not installed.

Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
---
 package/avahi/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/avahi/Config.in b/package/avahi/Config.in
index 728bc4fdd1..ae53aaf156 100644
--- a/package/avahi/Config.in
+++ b/package/avahi/Config.in
@@ -39,6 +39,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
 config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
 	bool
 	default y if BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_DBUS
 
 config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 	bool "libdns_sd compatibility (Bonjour)"
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCHv2 2/2] package/sane-airscan: add new package.

[Guillaume Chaye]

Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
---
 DEVELOPERS                             |  3 +++
 package/Config.in                      |  1 +
 package/sane-airscan/Config.in         | 20 ++++++++++++++++++++
 package/sane-airscan/sane-airscan.hash |  3 +++
 package/sane-airscan/sane-airscan.mk   | 13 +++++++++++++
 5 files changed, 40 insertions(+)
 create mode 100644 package/sane-airscan/Config.in
 create mode 100644 package/sane-airscan/sane-airscan.hash
 create mode 100644 package/sane-airscan/sane-airscan.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 059383d364..6879d868f2 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1330,6 +1330,9 @@ F:	package/python-rpi-ws281x/
 F:	package/python-wtforms/
 F:	package/rpi-rgb-led-matrix/
 
+N:	Guillaume Chaye
+F:	package/sane-airscan/
+
 N:	Guillaume William Brs <guillaume.bressaix@gmail.com>
 F:	package/libnids/
 F:	package/libxcrypt/
diff --git a/package/Config.in b/package/Config.in
index 400183516e..0ce6dfe420 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -611,6 +611,7 @@ endmenu
 	source "package/rtl8821au/Config.in"
 	source "package/rtl8821cu/Config.in"
 	source "package/rtl8822cs/Config.in"
+	source "package/sane-airscan/Config.in"
 	source "package/sane-backends/Config.in"
 	source "package/sdparm/Config.in"
 	source "package/sedutil/Config.in"
diff --git a/package/sane-airscan/Config.in b/package/sane-airscan/Config.in
new file mode 100644
index 0000000000..d5d02f9948
--- /dev/null
+++ b/package/sane-airscan/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_SANE_AIRSCAN
+	bool "sane-airscan"
+	select BR2_PACKAGE_SANE_BACKENDS
+	select BR2_PACKAGE_AVAHI
+	select BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
+	select BR2_PACKAGE_GNUTLS
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_TIFF
+
+	help
+	  SANE backend for AirScan (eSCL) and WSD document scanners
+
+	  https://github.com/alexpevzner/sane-airscan
+
+	  Similar to how most modern network printers support
+	  "driverless" printing, using the universal vendor-neutral
+	  printing protocol, many modern network scanners and MFPs
+	  support "driverless" scanning.
diff --git a/package/sane-airscan/sane-airscan.hash b/package/sane-airscan/sane-airscan.hash
new file mode 100644
index 0000000000..6600cab3b8
--- /dev/null
+++ b/package/sane-airscan/sane-airscan.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  67782be6a4fd36e753fc4766b8989d75f806bc6d1d2e92f617ea686be2924c14  sane-airscan-0.99.31.tar.gz
+sha256  a2631c1b81992bd6f66db6be8b009ed7e3e998d1e2db4de497fa82d65011d373  LICENSE
diff --git a/package/sane-airscan/sane-airscan.mk b/package/sane-airscan/sane-airscan.mk
new file mode 100644
index 0000000000..d19dde232c
--- /dev/null
+++ b/package/sane-airscan/sane-airscan.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# sane-airscan
+#
+################################################################################
+
+SANE_AIRSCAN_VERSION = 0.99.31
+SANE_AIRSCAN_SITE = $(call github,alexpevzner,sane-airscan,$(SANE_AIRSCAN_VERSION))
+SANE_AIRSCAN_DEPENDENCIES=  sane-backends avahi gnutls libxml2 jpeg libpng tiff
+SANE_AIRSCAN_LICENSE = GPLv2
+SANE_AIRSCAN_LICENSE_FILES = LICENSE
+
+$(eval $(meson-package))
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCHv2 1/2] package/avahi: add missing dependency.

[Thomas Petazzoni via buildroot]

Hello,

On Mon, 27 Jan 2025 10:17:10 +0100
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> libavahi-client is not built if dbus is not installed.
> 
> Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
> ---
>  package/avahi/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/avahi/Config.in b/package/avahi/Config.in
> index 728bc4fdd1..ae53aaf156 100644
> --- a/package/avahi/Config.in
> +++ b/package/avahi/Config.in
> @@ -39,6 +39,7 @@ config BR2_PACKAGE_AVAHI_DAEMON
>  config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
>  	bool
>  	default y if BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_DBUS

I understand your idea, but this is not what this option is about. This
option is not a typical visible option, with a prompt in menuconfig to
enable/disable avahi-client.

Instead it's a blind option that other packages can observe (but not
select!) to know if libavahi-client will be available or not.

And indeed, as soon as D-Bus is enabled,
BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT becomes true, telling other packages
that libavahi-client will be there.

So your PATCH 2/2 needs to select BR2_PACKAGE_AVAHI and
BR2_PACKAGE_DBUS, which will ensure libavahi-client gets built.

The problem with having an option is that we can't disable it. So if we
make it a visible option, and a user keeps it disabled... we have no
way to tell avahi to not build libavahi-client: as soon as D-Bus is
there, libavahi-client will be built.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot