From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "Eric Dumazet" <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Daniel Xu" <dxu@dxuuu.xyz>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Toke Høiland-Jørgensen" <toke@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH net-next v4 1/8] net: gro: decouple GRO from the NAPI layer
Date: Wed, 5 Feb 2025 18:56:45 -0800 [thread overview]
Message-ID: <20250205185645.51fd5f1f@kernel.org> (raw)
In-Reply-To: <CANn89iJjCOThDqwsK4v2O8LfcwAB55YohNZ8T2sR40uM2ZoX5w@mail.gmail.com>
On Wed, 5 Feb 2025 18:48:50 +0100 Eric Dumazet wrote:
> > + struct_group_tagged(gro_node, gro,
> > + unsigned long bitmask;
> > + struct gro_list hash[GRO_HASH_BUCKETS];
> > + struct list_head rx_list; /* Pending GRO_NORMAL skbs */
> > + int rx_count; /* length of rx_list */
> > + u32 napi_id; /* protected by netdev_lock */
> > +
>
> I am old school, I would prefer a proper/standalone old C construct.
+1, fwiw, I thought it was just me..
next prev parent reply other threads:[~2025-02-06 2:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:36 [PATCH net-next v4 0/8] bpf: cpumap: enable GRO for XDP_PASS frames Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 1/8] net: gro: decouple GRO from the NAPI layer Alexander Lobakin
2025-02-05 17:48 ` Eric Dumazet
2025-02-06 2:56 ` Jakub Kicinski [this message]
2025-02-06 12:12 ` Alexander Lobakin
2025-02-06 18:35 ` Eric Dumazet
2025-02-07 11:56 ` Alexander Lobakin
2025-02-07 14:21 ` Przemek Kitszel
2025-02-07 14:55 ` Eric Dumazet
2025-02-07 15:18 ` Alexander Lobakin
2025-02-07 15:28 ` Eric Dumazet
2025-02-07 15:43 ` Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 2/8] net: gro: expose GRO init/cleanup to use outside of NAPI Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list() Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 4/8] bpf: cpumap: reuse skb array instead of a linked list to chain skbs Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 5/8] net: skbuff: introduce napi_skb_cache_get_bulk() Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 6/8] bpf: cpumap: switch to napi_skb_cache_get_bulk() Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 7/8] veth: use napi_skb_cache_get_bulk() instead of xdp_alloc_skb_bulk() Alexander Lobakin
2025-02-05 16:36 ` [PATCH net-next v4 8/8] xdp: remove xdp_alloc_skb_bulk() Alexander Lobakin
2025-02-10 14:05 ` [PATCH net-next v4 0/8] bpf: cpumap: enable GRO for XDP_PASS frames Alexander Lobakin
2025-02-10 15:31 ` Eric Dumazet
2025-02-10 15:31 ` Alexander Lobakin
2025-02-11 0:35 ` Jakub Kicinski
2025-02-12 14:22 ` Alexander Lobakin
2025-02-12 15:55 ` Alexander Lobakin
2025-02-12 18:29 ` Jakub Kicinski
2025-02-14 15:43 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205185645.51fd5f1f@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.