* Re: [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors
@ 2025-02-07 6:11 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-02-07 6:11 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250205233016.1600517-3-swboyd@chromium.org>
References: <20250205233016.1600517-3-swboyd@chromium.org>
TO: Stephen Boyd <swboyd@chromium.org>
TO: Konrad Dybcio <konradybcio@kernel.org>
TO: Bjorn Andersson <andersson@kernel.org>
CC: linux-kernel@vger.kernel.org
CC: linux-arm-msm@vger.kernel.org
CC: patches@lists.linux.dev
CC: cros-qcom-dts-watchers@chromium.org
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: devicetree@vger.kernel.org
CC: "Pin-yen Lin" <treapking@chromium.org>
Hi Stephen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 2014c95afecee3e76ca4a56956a936e23283f05b]
url: https://github.com/intel-lab-lkp/linux/commits/Stephen-Boyd/dt-bindings-chrome-Add-binding-for-ChromeOS-Pogo-pin-connector/20250206-073318
base: 2014c95afecee3e76ca4a56956a936e23283f05b
patch link: https://lore.kernel.org/r/20250205233016.1600517-3-swboyd%40chromium.org
patch subject: [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: arm64-randconfig-052-20250207 (https://download.01.org/0day-ci/archive/20250207/202502071322.hWsz0XWw-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
dtschema version: 2024.12.dev6+gc4da38d
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250207/202502071322.hWsz0XWw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202502071322.hWsz0XWw-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/pm6150.dtsi:135.30-143.5: Warning (avoid_unnecessary_addr_size): /soc@0/spmi@c440000/pmic@0/adc-tm@3500: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/pm6150.dtsi:135.30-143.5: Warning (avoid_unnecessary_addr_size): /soc@0/spmi@c440000/pmic@0/adc-tm@3500: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180.dtsi:3265.27-3336.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
--
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1002.21-1042.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@1: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:1045.21-1086.4: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a6f8800/usb@a600000/hub@2: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb: rsc@18200000: 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml#
vim +1002 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
7ec3e67307f861 Rob Clark 2020-08-28 995
7ec3e67307f861 Rob Clark 2020-08-28 996 &usb_1_dwc3 {
7ec3e67307f861 Rob Clark 2020-08-28 997 dr_mode = "host";
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 998 #address-cells = <1>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 999 #size-cells = <0>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1000
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1001 /* 2.x hub on port 1 */
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 @1002 usb_hub_2_x: hub@1 {
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1003 compatible = "usbbda,5411";
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1004 reg = <1>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1005 vdd-supply = <&pp3300_hub>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1006 peer-hub = <&usb_hub_3_x>;
736131f7d7617a Stephen Boyd 2025-02-05 1007
736131f7d7617a Stephen Boyd 2025-02-05 1008 #address-cells = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1009 #size-cells = <0>;
736131f7d7617a Stephen Boyd 2025-02-05 1010
736131f7d7617a Stephen Boyd 2025-02-05 1011 usb_hub_2_x_ports: ports {
736131f7d7617a Stephen Boyd 2025-02-05 1012 #address-cells = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1013 #size-cells = <0>;
736131f7d7617a Stephen Boyd 2025-02-05 1014
736131f7d7617a Stephen Boyd 2025-02-05 1015 port@1 {
736131f7d7617a Stephen Boyd 2025-02-05 1016 reg = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1017 usb_hub_dfp1_hs: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1018 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1019 };
736131f7d7617a Stephen Boyd 2025-02-05 1020 };
736131f7d7617a Stephen Boyd 2025-02-05 1021 port@2 {
736131f7d7617a Stephen Boyd 2025-02-05 1022 reg = <2>;
736131f7d7617a Stephen Boyd 2025-02-05 1023 usb_hub_dfp2_hs: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1024 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1025 };
736131f7d7617a Stephen Boyd 2025-02-05 1026 };
736131f7d7617a Stephen Boyd 2025-02-05 1027
736131f7d7617a Stephen Boyd 2025-02-05 1028 port@3 {
736131f7d7617a Stephen Boyd 2025-02-05 1029 reg = <3>;
736131f7d7617a Stephen Boyd 2025-02-05 1030 usb_hub_dfp3_hs: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1031 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1032 };
736131f7d7617a Stephen Boyd 2025-02-05 1033 };
736131f7d7617a Stephen Boyd 2025-02-05 1034
736131f7d7617a Stephen Boyd 2025-02-05 1035 port@4 {
736131f7d7617a Stephen Boyd 2025-02-05 1036 reg = <4>;
736131f7d7617a Stephen Boyd 2025-02-05 1037 usb_hub_dfp4_hs: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1038 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1039 };
736131f7d7617a Stephen Boyd 2025-02-05 1040 };
736131f7d7617a Stephen Boyd 2025-02-05 1041 };
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1042 };
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1043
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1044 /* 3.x hub on port 2 */
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1045 usb_hub_3_x: hub@2 {
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1046 compatible = "usbbda,411";
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1047 reg = <2>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1048 vdd-supply = <&pp3300_hub>;
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1049 peer-hub = <&usb_hub_2_x>;
736131f7d7617a Stephen Boyd 2025-02-05 1050
736131f7d7617a Stephen Boyd 2025-02-05 1051 #address-cells = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1052 #size-cells = <0>;
736131f7d7617a Stephen Boyd 2025-02-05 1053
736131f7d7617a Stephen Boyd 2025-02-05 1054 usb_hub_3_x_ports: ports {
736131f7d7617a Stephen Boyd 2025-02-05 1055 #address-cells = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1056 #size-cells = <0>;
736131f7d7617a Stephen Boyd 2025-02-05 1057
736131f7d7617a Stephen Boyd 2025-02-05 1058 port@1 {
736131f7d7617a Stephen Boyd 2025-02-05 1059 reg = <1>;
736131f7d7617a Stephen Boyd 2025-02-05 1060 usb_hub_dfp1_ss: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1061 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1062 };
736131f7d7617a Stephen Boyd 2025-02-05 1063 };
736131f7d7617a Stephen Boyd 2025-02-05 1064
736131f7d7617a Stephen Boyd 2025-02-05 1065 port@2 {
736131f7d7617a Stephen Boyd 2025-02-05 1066 reg = <2>;
736131f7d7617a Stephen Boyd 2025-02-05 1067 usb_hub_dfp2_ss: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1068 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1069 };
736131f7d7617a Stephen Boyd 2025-02-05 1070 };
736131f7d7617a Stephen Boyd 2025-02-05 1071
736131f7d7617a Stephen Boyd 2025-02-05 1072 port@3 {
736131f7d7617a Stephen Boyd 2025-02-05 1073 reg = <3>;
736131f7d7617a Stephen Boyd 2025-02-05 1074 usb_hub_dfp3_ss: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1075 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1076 };
736131f7d7617a Stephen Boyd 2025-02-05 1077 };
736131f7d7617a Stephen Boyd 2025-02-05 1078
736131f7d7617a Stephen Boyd 2025-02-05 1079 port@4 {
736131f7d7617a Stephen Boyd 2025-02-05 1080 reg = <4>;
736131f7d7617a Stephen Boyd 2025-02-05 1081 usb_hub_dfp4_ss: endpoint {
736131f7d7617a Stephen Boyd 2025-02-05 1082 /* Endpoint filled in by board */
736131f7d7617a Stephen Boyd 2025-02-05 1083 };
736131f7d7617a Stephen Boyd 2025-02-05 1084 };
736131f7d7617a Stephen Boyd 2025-02-05 1085 };
a73dd03bb2e028 Matthias Kaehlcke 2022-07-22 1086 };
7ec3e67307f861 Rob Clark 2020-08-28 1087 };
7ec3e67307f861 Rob Clark 2020-08-28 1088
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH v2 0/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB
@ 2025-02-05 23:30 Stephen Boyd
2025-02-05 23:30 ` [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2025-02-05 23:30 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson
Cc: linux-kernel, linux-arm-msm, patches, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Benson Leung, devicetree,
chrome-platform, Pin-yen Lin, cros-qcom-dts-watchers
Wiring up the USB hub to the connectors allows us to gain the proper
'connect_type' and 'removable' values in sysfs for the USB devices on
sc7180 trogdor devices. These two patches are split off of a larger
series[1] so they can land faster and because we've come to the
conclusion that the DisplayPort path is going to connect to the
cros-ec-typec node.
The first patch adds the pogo pin binding to describe the detachable
keyboards found on some trogdor devices (actually strongbad). The second
patch is the dts changes required to wire up all the USB stuff. This is
sufficient to set the connect_type and removable sysfs properties of USB
devices.
Changes from v1 https://lore.kernel.org/r/20240210070934.2549994-1-swboyd@chromium.org
* Split out of larger series
* Added description to DT binding
* Removed DP part of dts changes
[1] https://lore.kernel.org/r/20240210070934.2549994-1-swboyd@chromium.org
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Benson Leung <bleung@chromium.org>
Cc: <devicetree@vger.kernel.org>
Cc: <chrome-platform@lists.linux.dev>
Cc: Pin-yen Lin <treapking@chromium.org>
Cc: <cros-qcom-dts-watchers@chromium.org>
Stephen Boyd (2):
dt-bindings: chrome: Add binding for ChromeOS Pogo pin connector
arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors
.../chrome/google,pogo-pin-connector.yaml | 68 +++++++++++
.../dts/qcom/sc7180-trogdor-clamshell.dtsi | 21 ++++
.../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 47 ++++++++
.../dts/qcom/sc7180-trogdor-detachable.dtsi | 15 +++
.../dts/qcom/sc7180-trogdor-homestar.dtsi | 47 ++++++++
.../dts/qcom/sc7180-trogdor-kingoftown.dts | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 44 +++++++
.../qcom/sc7180-trogdor-quackingstick.dtsi | 31 +++++
.../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 56 ++++++++-
.../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 47 ++++++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 109 ++++++++++++++++++
13 files changed, 648 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/chrome/google,pogo-pin-connector.yaml
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
--
https://chromeos.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors
2025-02-05 23:30 [PATCH v2 0/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB Stephen Boyd
@ 2025-02-05 23:30 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2025-02-05 23:30 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson
Cc: linux-kernel, linux-arm-msm, patches, cros-qcom-dts-watchers,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
Pin-yen Lin
Fully describe the USB type-c on sc7180 Trogdor devices. Most Trogdor
devices have two USB type-c ports (i.e. usb-c-connector nodes), but
Quackingstick only has one. Also, clamshell devices such as Lazor have a
USB webcam connected to the USB hub, while detachable devices such as
Wormdingler don't have a webcam, or a USB type-a connector. Instead they
have the pogo pins for the detachable keyboard.
Fully describing the topology like this will let us expose information
about what devices are connected to which physical USB connector (type-A
or type-C).
Cc: <cros-qcom-dts-watchers@chromium.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>
Cc: <devicetree@vger.kernel.org>
Cc: Pin-yen Lin <treapking@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
.../dts/qcom/sc7180-trogdor-clamshell.dtsi | 21 ++++
.../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 47 ++++++++
.../dts/qcom/sc7180-trogdor-detachable.dtsi | 15 +++
.../dts/qcom/sc7180-trogdor-homestar.dtsi | 47 ++++++++
.../dts/qcom/sc7180-trogdor-kingoftown.dts | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 55 +++++++++
.../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 44 +++++++
.../qcom/sc7180-trogdor-quackingstick.dtsi | 31 +++++
.../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 56 ++++++++-
.../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 47 ++++++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 109 ++++++++++++++++++
12 files changed, 580 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi
index d91533b80e76..4e4f0b239f3c 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi
@@ -7,3 +7,24 @@
/* This file must be included after sc7180-trogdor.dtsi to modify cros_ec */
#include <arm/cros-ec-keyboard.dtsi>
+
+/ {
+ usb-a-connector {
+ compatible = "usb-a-connector";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usb_a0_hs: endpoint@0 {
+ reg = <0>;
+ /* Endpoint filled in by board */
+ };
+
+ usb_a0_ss: endpoint@1 {
+ reg = <1>;
+ /* Endpoint filled in by board */
+ };
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
index 25b17b0425f2..548d6c1ee050 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
@@ -134,6 +134,17 @@ skin-temp-thermistor@1 {
};
};
+&pogo_pins {
+ keyboard@4 {
+ compatible = "usb18d1,504c";
+ reg = <4>;
+ };
+};
+
+&pogo_pins_in {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
&pp1800_uf_cam {
status = "okay";
};
@@ -175,6 +186,42 @@ &sound_multimedia0_codec {
sound-dai = <&adau7002>;
};
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp1_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp1_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_hub_dfp1_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp1_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&pogo_pins_in>;
+};
+
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
&en_pp3300_dx_edp {
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi
index 7c5d8a57ef7f..a863295356e9 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi
@@ -6,6 +6,21 @@
*/
/* This file must be included after sc7180-trogdor.dtsi to modify cros_ec */
+
+/ {
+ pogo_pins: pogo-pin-connector {
+ compatible = "google,pogo-pin-connector";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* Detachable keyboard populated for each board */
+ port {
+ pogo_pins_in: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ };
+};
+
&cros_ec {
keyboard-controller {
compatible = "google,cros-ec-keyb-switches";
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
index f57976906d63..09c4a30d96ef 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
@@ -159,6 +159,17 @@ skin-temp-thermistor@1 {
};
};
+&pogo_pins {
+ keyboard@3 {
+ compatible = "usb18d1,5052";
+ reg = <3>;
+ };
+};
+
+&pogo_pins_in {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
&pp1800_uf_cam {
status = "okay";
};
@@ -187,6 +198,42 @@ &sound_multimedia1_codec {
sound-dai = <&max98360a>, <&max98360a_1>, <&max98360a_2>, <&max98360a_3> ;
};
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp4_ss>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&pogo_pins_in>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp4_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
&wifi {
qcom,ath10k-calibration-variant = "GO_HOMESTAR";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts
index 655bea928e52..d4ff26fba3be 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts
@@ -78,6 +78,61 @@ &pp3300_dx_edp {
gpio = <&tlmm 67 GPIO_ACTIVE_HIGH>;
};
+&usb_a0_hs {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
+&usb_a0_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp1_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp1_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_hub_2_x {
+ camera@4 {
+ compatible = "usb4f2,b75a";
+ reg = <4>;
+ };
+};
+
+&usb_hub_dfp1_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp1_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&usb_a0_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_a0_ss>;
+};
+
&wifi {
qcom,ath10k-calibration-variant = "GO_KINGOFTOWN";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
index c3fd6760de7a..7b545ae5791b 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
@@ -68,6 +68,61 @@ &trackpad {
interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
};
+&usb_a0_hs {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
+&usb_a0_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp4_ss>;
+};
+
+&usb_hub_2_x {
+ camera@1 {
+ compatible = "usb408,a092";
+ reg = <1>;
+ };
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&usb_a0_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_a0_ss>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp4_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
&wifi {
qcom,ath10k-calibration-variant = "GO_LAZOR";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
index cc2c5610a279..9523843f06ab 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi
@@ -82,6 +82,61 @@ &pp3300_dx_edp {
gpio = <&tlmm 67 GPIO_ACTIVE_HIGH>;
};
+&usb_a0_hs {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
+&usb_a0_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp1_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp1_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_hub_2_x {
+ camera@4 {
+ compatible = "usb5c8,b03";
+ reg = <4>;
+ };
+};
+
+&usb_hub_dfp1_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp1_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&usb_a0_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_a0_ss>;
+};
+
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
&en_pp3300_dx_edp {
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
index f7300ffbb451..4cc1a155d999 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
@@ -176,10 +176,54 @@ &sound {
dmic-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
};
+&usb_a0_hs {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
+&usb_a0_ss {
+ remote-endpoint = <&usb_hub_dfp4_ss>;
+};
+
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
&usb_c1 {
status = "disabled";
};
+&usb_hub_2_x {
+ camera@1 {
+ compatible = "usb4f2,b718";
+ reg = <1>;
+ };
+
+ camera@2 {
+ compatible = "usb13d3,56e9";
+ reg = <2>;
+ };
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&usb_a0_hs>;
+};
+
+&usb_hub_dfp4_ss {
+ remote-endpoint = <&usb_a0_ss>;
+};
+
&wifi {
qcom,ath10k-calibration-variant = "GO_POMPOM";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
index ff8996b4de4e..174efd3abfa5 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi
@@ -105,6 +105,17 @@ &sdhc_2 {
status = "okay";
};
+&pogo_pins {
+ keyboard@1 {
+ compatible = "usb18d1,505b";
+ reg = <1>;
+ };
+};
+
+&pogo_pins_in {
+ remote-endpoint = <&usb_hub_dfp1_hs>;
+};
+
&pp1800_uf_cam {
status = "okay";
};
@@ -129,11 +140,31 @@ pp3300_disp_on: &pp3300_dx_edp {
gpio = <&tlmm 67 GPIO_ACTIVE_HIGH>;
};
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
/* This board only has 1 USB Type-C port. */
&usb_c1 {
status = "disabled";
};
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp1_hs {
+ remote-endpoint = <&pogo_pins_in>;
+};
+
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
/*
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
index d393a2712ce6..dddf92c04c4d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
@@ -52,12 +52,64 @@ &trackpad {
interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
};
+&usb_a0_hs {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
+&usb_a0_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp4_ss>;
+};
+
&usb_hub_2_x {
- vdd-supply = <&pp3300_l7c>;
+ vdd-supply = <&pp3300_l7c>;
+ camera@1 {
+ compatible = "usb4f2,b567";
+ reg = <1>;
+ };
};
&usb_hub_3_x {
- vdd-supply = <&pp3300_l7c>;
+ vdd-supply = <&pp3300_l7c>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&usb_a0_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_a0_ss>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp4_ss {
+ remote-endpoint = <&usb_c1_ss>;
};
/* PINCTRL - modifications to sc7180-trogdor.dtsi */
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
index d4925be3b1fc..59cdf8eea647 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
@@ -179,6 +179,17 @@ skin-temp-thermistor@1 {
};
};
+&pogo_pins {
+ keyboard@3 {
+ compatible = "usb18d1,5057";
+ reg = <3>;
+ };
+};
+
+&pogo_pins_in {
+ remote-endpoint = <&usb_hub_dfp3_hs>;
+};
+
&pp1800_uf_cam {
status = "okay";
};
@@ -195,6 +206,42 @@ &pp2800_wf_cam {
status = "okay";
};
+&usb_c0_hs {
+ remote-endpoint = <&usb_hub_dfp2_hs>;
+};
+
+&usb_c0_ss {
+ remote-endpoint = <&usb_hub_dfp2_ss>;
+};
+
+&usb_c1_hs {
+ remote-endpoint = <&usb_hub_dfp4_hs>;
+};
+
+&usb_c1_ss {
+ remote-endpoint = <&usb_hub_dfp3_ss>;
+};
+
+&usb_hub_dfp2_hs {
+ remote-endpoint = <&usb_c0_hs>;
+};
+
+&usb_hub_dfp2_ss {
+ remote-endpoint = <&usb_c0_ss>;
+};
+
+&usb_hub_dfp4_hs {
+ remote-endpoint = <&usb_c1_hs>;
+};
+
+&usb_hub_dfp3_ss {
+ remote-endpoint = <&usb_c1_ss>;
+};
+
+&usb_hub_dfp3_hs {
+ remote-endpoint = <&pogo_pins_in>;
+};
+
&wifi {
qcom,ath10k-calibration-variant = "GO_WORMDINGLER";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 74ab321d3333..af866cdd4fef 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -673,6 +673,25 @@ usb_c0: connector@0 {
power-role = "dual";
data-role = "host";
try-power-role = "source";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ usb_c0_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ usb_c0_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ };
};
usb_c1: connector@1 {
@@ -682,6 +701,25 @@ usb_c1: connector@1 {
power-role = "dual";
data-role = "host";
try-power-role = "source";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ usb_c1_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ usb_c1_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ };
};
};
};
@@ -966,6 +1004,41 @@ usb_hub_2_x: hub@1 {
reg = <1>;
vdd-supply = <&pp3300_hub>;
peer-hub = <&usb_hub_3_x>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usb_hub_2_x_ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ reg = <1>;
+ usb_hub_dfp1_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ port@2 {
+ reg = <2>;
+ usb_hub_dfp2_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@3 {
+ reg = <3>;
+ usb_hub_dfp3_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@4 {
+ reg = <4>;
+ usb_hub_dfp4_hs: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ };
};
/* 3.x hub on port 2 */
@@ -974,6 +1047,42 @@ usb_hub_3_x: hub@2 {
reg = <2>;
vdd-supply = <&pp3300_hub>;
peer-hub = <&usb_hub_2_x>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usb_hub_3_x_ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ reg = <1>;
+ usb_hub_dfp1_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ usb_hub_dfp2_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@3 {
+ reg = <3>;
+ usb_hub_dfp3_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+
+ port@4 {
+ reg = <4>;
+ usb_hub_dfp4_ss: endpoint {
+ /* Endpoint filled in by board */
+ };
+ };
+ };
};
};
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-07 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 6:11 [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-02-05 23:30 [PATCH v2 0/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB Stephen Boyd
2025-02-05 23:30 ` [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Wire up USB to usb-c-connectors Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.