[RESEND PATCH] sctp: Remove commented out code

[RESEND PATCH] sctp: Remove commented out code

[Thorsten Blum]

Remove commented out code.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 include/linux/sctp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/sctp.h b/include/linux/sctp.h
index 836a7e200f39..812011d8b67e 100644
--- a/include/linux/sctp.h
+++ b/include/linux/sctp.h
@@ -222,7 +222,6 @@ struct sctp_datahdr {
 	__be16 stream;
 	__be16 ssn;
 	__u32 ppid;
-	/* __u8  payload[]; */
 };
 
 struct sctp_data_chunk {
-- 
2.48.1

Re: [RESEND PATCH] sctp: Remove commented out code

[Marcelo Ricardo Leitner]

On Sun, Feb 09, 2025 at 10:00:24PM +0100, Thorsten Blum wrote:
> Remove commented out code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Hi Thorsten,

SCTP patches are picked up on the generic networking mailing list.
You need to send this patch towards netdev@vger.kernel.org.
Thanks for your patch, but please post it over there.

Best,
Marcelo

Re: [RESEND PATCH] sctp: Remove commented out code

[Thorsten Blum]

On 10. Feb 2025, at 13:51, Marcelo Ricardo Leitner wrote:
> On Sun, Feb 09, 2025 at 10:00:24PM +0100, Thorsten Blum wrote:
>> Remove commented out code.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> SCTP patches are picked up on the generic networking mailing list.
> You need to send this patch towards netdev@vger.kernel.org.
> Thanks for your patch, but please post it over there.

Hm, the get_maintainer script doesn't mention netdev@vger.kernel.org

$ ./scripts/get_maintainer.pl -f include/linux/sctp.h
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> (maintainer:SCTP PROTOCOL)
Xin Long <lucien.xin@gmail.com> (maintainer:SCTP PROTOCOL)
linux-sctp@vger.kernel.org (open list:SCTP PROTOCOL)
linux-kernel@vger.kernel.org (open list)

Should this be fixed?

Thanks,
Thorsten

Re: [RESEND PATCH] sctp: Remove commented out code

[Marcelo Ricardo Leitner]

On Mon, Feb 10, 2025 at 02:07:18PM +0100, Thorsten Blum wrote:
> On 10. Feb 2025, at 13:51, Marcelo Ricardo Leitner wrote:
> > On Sun, Feb 09, 2025 at 10:00:24PM +0100, Thorsten Blum wrote:
> >> Remove commented out code.
> >> 
> >> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > 
> > SCTP patches are picked up on the generic networking mailing list.
> > You need to send this patch towards netdev@vger.kernel.org.
> > Thanks for your patch, but please post it over there.
> 
> Hm, the get_maintainer script doesn't mention netdev@vger.kernel.org
> 
> $ ./scripts/get_maintainer.pl -f include/linux/sctp.h
> Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> (maintainer:SCTP PROTOCOL)
> Xin Long <lucien.xin@gmail.com> (maintainer:SCTP PROTOCOL)
> linux-sctp@vger.kernel.org (open list:SCTP PROTOCOL)
> linux-kernel@vger.kernel.org (open list)
> 
> Should this be fixed?

Yes. I'll send a patch for it. I believe the changes below are what is
needed.

$ ./scripts/get_maintainer.pl -f include/linux/sctp.h
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> (maintainer:SCTP PROTOCOL)
Xin Long <lucien.xin@gmail.com> (maintainer:SCTP PROTOCOL)
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL])
Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING [GENERAL])
Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING [GENERAL])
Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING [GENERAL])
linux-sctp@vger.kernel.org (open list:SCTP PROTOCOL)
netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
linux-kernel@vger.kernel.org (open list)

Thanks,
Marcelo

---8<---
diff --git a/MAINTAINERS b/MAINTAINERS
index 560a65b85297..eee8d442a4eb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16182,6 +16182,7 @@ F:	include/linux/netdev*
 F:	include/linux/netlink.h
 F:	include/linux/netpoll.h
 F:	include/linux/rtnetlink.h
+F:	include/linux/sctp.h
 F:	include/linux/seq_file_net.h
 F:	include/linux/skbuff*
 F:	include/net/
@@ -16197,6 +16198,7 @@ F:	include/uapi/linux/netdev*
 F:	include/uapi/linux/netlink.h
 F:	include/uapi/linux/netlink_diag.h
 F:	include/uapi/linux/rtnetlink.h
+F:	include/uapi/linux/sctp.h
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/