From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
andersson@kernel.org, konradybcio@kernel.org, rafael@kernel.org,
ulf.hansson@linaro.org
Subject: Re: [PATCH] nvme-pci: Use NVME_QUIRK_SIMPLE_SUSPEND for Qualcomm Snapdragon 8cx Gen 3 platforms
Date: Mon, 10 Feb 2025 05:04:46 +0100 [thread overview]
Message-ID: <20250210040446.GA2823@lst.de> (raw)
In-Reply-To: <20250208185124.GA1120888@bhelgaas>
On Sat, Feb 08, 2025 at 12:51:24PM -0600, Bjorn Helgaas wrote:
> > + /*
> > + * Qualcomm Snapdragon 8cx Gen 3 (SC8280XP) platforms doesn't retain
> > + * power to the PCIe bus after entering low power CX power collapse
> > + * state during system suspend. So shutdown the NVMe devices to have a
> > + * working system suspend on these platforms.
> > + */
> > + if (dmi_match(DMI_PRODUCT_FAMILY, "SCP_MAKENA") ||
> > + dmi_match(DMI_PRODUCT_FAMILY, "ThinkPad X13s Gen 1"))
> > + return NVME_QUIRK_SIMPLE_SUSPEND;
>
> I certainly acknowledge that this is a big problem for users. At the
> same time, this seems like a maintenance nightmare of
> platform-specific hacks scattered through endpoint drivers.
Yes. And it's what we stated that we won't do multiple times.
This needs to be taken on in the firmware or at least core PCI/PM
code.
next prev parent reply other threads:[~2025-02-10 4:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 5:03 [PATCH] nvme-pci: Use NVME_QUIRK_SIMPLE_SUSPEND for Qualcomm Snapdragon 8cx Gen 3 platforms Manivannan Sadhasivam
2025-02-04 16:03 ` Ulf Hansson
2025-02-07 18:06 ` Manivannan Sadhasivam
2025-02-08 18:51 ` Bjorn Helgaas
2025-02-10 4:04 ` Christoph Hellwig [this message]
2025-02-10 6:36 ` Manivannan Sadhasivam
2025-02-13 7:10 ` Christoph Hellwig
2025-02-10 6:39 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210040446.GA2823@lst.de \
--to=hch@lst.de \
--cc=andersson@kernel.org \
--cc=axboe@kernel.dk \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.