All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Bjorn Helgaas <helgaas@kernel.org>,
	kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	andersson@kernel.org, konradybcio@kernel.org, rafael@kernel.org,
	ulf.hansson@linaro.org
Subject: Re: [PATCH] nvme-pci: Use NVME_QUIRK_SIMPLE_SUSPEND for Qualcomm Snapdragon 8cx Gen 3 platforms
Date: Thu, 13 Feb 2025 08:10:43 +0100	[thread overview]
Message-ID: <20250213071043.GA21238@lst.de> (raw)
In-Reply-To: <20250210063605.yp5rkraain5oqxka@thinkpad>

On Mon, Feb 10, 2025 at 12:06:05PM +0530, Manivannan Sadhasivam wrote:
> Multiple times? As I stated in the commit message, this quirk is *not* going to
> be extended for any Qcom platforms as the rest of them can retain the PCIe power
> state during CX Power Collapse.
> 
> And we don't need this quirk in any other endpoint drivers as this chipset is
> mostly used in Laptop form factors and only the NVMe driver is found to be
> causing the issues. Rest of the endpoint drivers (WLAN, Modem) are all coping
> with PCIe power going down during system suspend.

No matter where you need it - the place is the core and not the driver.



  reply	other threads:[~2025-02-13  7:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26  5:03 [PATCH] nvme-pci: Use NVME_QUIRK_SIMPLE_SUSPEND for Qualcomm Snapdragon 8cx Gen 3 platforms Manivannan Sadhasivam
2025-02-04 16:03 ` Ulf Hansson
2025-02-07 18:06   ` Manivannan Sadhasivam
2025-02-08 18:51 ` Bjorn Helgaas
2025-02-10  4:04   ` Christoph Hellwig
2025-02-10  6:36     ` Manivannan Sadhasivam
2025-02-13  7:10       ` Christoph Hellwig [this message]
2025-02-10  6:39   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250213071043.GA21238@lst.de \
    --to=hch@lst.de \
    --cc=andersson@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=helgaas@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rafael@kernel.org \
    --cc=sagi@grimberg.me \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.