[PATCH v1] board: verdin-am62: add dram_init_banksize

[PATCH v1] board: verdin-am62: add dram_init_banksize

[Stefan Eichenberger]

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Add the dram_init_banksize function to the board file to properly set
DRAM memory sizes during boot.

The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
common location and Fixup DDR size when ECC is enabled") relocated the
dram_init_banksize function from architecture specific initialization to
the TI board initialization code. As a result, boards relying on the
previous setup now require this function to be defined within their
board file to handle DRAM sizing correctly.

Without this function defined the following error appears during boot:
    ERROR: Failed to allocate 0x1000 bytes below 0x0.

Fixes: bc07851897bd ("board: ti: Pull redundant DDR functions to a common location and Fixup DDR size when ECC is enabled")
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
 board/toradex/verdin-am62/verdin-am62.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/board/toradex/verdin-am62/verdin-am62.c b/board/toradex/verdin-am62/verdin-am62.c
index e948fc16ba9..b80b39b6767 100644
--- a/board/toradex/verdin-am62/verdin-am62.c
+++ b/board/toradex/verdin-am62/verdin-am62.c
@@ -35,6 +35,17 @@ int dram_init(void)
 	return 0;
 }
 
+int dram_init_banksize(void)
+{
+	s32 ret;
+
+	ret = fdtdec_setup_memory_banksize();
+	if (ret)
+		printf("Error setting up memory banksize. %d\n", ret);
+
+	return ret;
+}
+
 /*
  * Avoid relocated U-Boot clash with Linux reserved-memory on 512 MB SoM
  */
-- 
2.45.2

Re: [PATCH v1] board: verdin-am62: add dram_init_banksize

[Francesco Dolcini]

On Mon, Feb 10, 2025 at 08:27:47AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> Add the dram_init_banksize function to the board file to properly set
> DRAM memory sizes during boot.
> 
> The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> common location and Fixup DDR size when ECC is enabled") relocated the
> dram_init_banksize function from architecture specific initialization to
> the TI board initialization code. As a result, boards relying on the
> previous setup now require this function to be defined within their
> board file to handle DRAM sizing correctly.
> 
> Without this function defined the following error appears during boot:
>     ERROR: Failed to allocate 0x1000 bytes below 0x0.
> 
> Fixes: bc07851897bd ("board: ti: Pull redundant DDR functions to a common location and Fixup DDR size when ECC is enabled")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Re: [PATCH v1] board: verdin-am62: add dram_init_banksize

[Tom Rini]

On Mon, 10 Feb 2025 08:27:47 +0100, Stefan Eichenberger wrote:

> Add the dram_init_banksize function to the board file to properly set
> DRAM memory sizes during boot.
> 
> The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> common location and Fixup DDR size when ECC is enabled") relocated the
> dram_init_banksize function from architecture specific initialization to
> the TI board initialization code. As a result, boards relying on the
> previous setup now require this function to be defined within their
> board file to handle DRAM sizing correctly.
> 
> [...]

Applied to u-boot/next, thanks!

-- 
Tom

Re: [PATCH v1] board: verdin-am62: add dram_init_banksize

[Francesco Dolcini]

Hello Tom,

On Tue, Feb 18, 2025 at 08:04:49PM -0600, Tom Rini wrote:
> On Mon, 10 Feb 2025 08:27:47 +0100, Stefan Eichenberger wrote:
> 
> > Add the dram_init_banksize function to the board file to properly set
> > DRAM memory sizes during boot.
> > 
> > The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> > common location and Fixup DDR size when ECC is enabled") relocated the
> > dram_init_banksize function from architecture specific initialization to
> > the TI board initialization code. As a result, boards relying on the
> > previous setup now require this function to be defined within their
> > board file to handle DRAM sizing correctly.
> > 
> > [...]
> 
> Applied to u-boot/next, thanks!

This fix is needed in master, without it verdin-am62 is not booting at
all, can you pick it also in master?

We should have been more explicit on this, next time we'll do better.

Thanks,
Francesco

Re: [PATCH v1] board: verdin-am62: add dram_init_banksize

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Wed, Feb 19, 2025 at 10:25:46AM +0100, Francesco Dolcini wrote:
> Hello Tom,
> 
> On Tue, Feb 18, 2025 at 08:04:49PM -0600, Tom Rini wrote:
> > On Mon, 10 Feb 2025 08:27:47 +0100, Stefan Eichenberger wrote:
> > 
> > > Add the dram_init_banksize function to the board file to properly set
> > > DRAM memory sizes during boot.
> > > 
> > > The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> > > common location and Fixup DDR size when ECC is enabled") relocated the
> > > dram_init_banksize function from architecture specific initialization to
> > > the TI board initialization code. As a result, boards relying on the
> > > previous setup now require this function to be defined within their
> > > board file to handle DRAM sizing correctly.
> > > 
> > > [...]
> > 
> > Applied to u-boot/next, thanks!
> 
> This fix is needed in master, without it verdin-am62 is not booting at
> all, can you pick it also in master?
> 
> We should have been more explicit on this, next time we'll do better.

Yes, I'll take care of it, thanks for explaining.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH v1] board: verdin-am62: add dram_init_banksize

[Tom Rini]

On Mon, 10 Feb 2025 08:27:47 +0100, Stefan Eichenberger wrote:

> Add the dram_init_banksize function to the board file to properly set
> DRAM memory sizes during boot.
> 
> The commit bc07851897bd ("board: ti: Pull redundant DDR functions to a
> common location and Fixup DDR size when ECC is enabled") relocated the
> dram_init_banksize function from architecture specific initialization to
> the TI board initialization code. As a result, boards relying on the
> previous setup now require this function to be defined within their
> board file to handle DRAM sizing correctly.
> 
> [...]

Applied to u-boot/master, thanks!

-- 
Tom