From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
tariqt@nvidia.com, hawk@kernel.org
Subject: Re: [PATCH net-next 0/4] eth: mlx4: use the page pool for Rx buffers
Date: Tue, 11 Feb 2025 10:50:01 -0800 [thread overview]
Message-ID: <20250211105001.73b220fb@kernel.org> (raw)
In-Reply-To: <1c187a13-977d-4dae-a9eb-18ef602f5682@gmail.com>
On Tue, 11 Feb 2025 20:05:01 +0200 Tariq Toukan wrote:
> On 06/02/2025 17:58, Jakub Kicinski wrote:
> > On Thu, 6 Feb 2025 14:57:59 +0200 Tariq Toukan wrote:
> >> Thanks for your patches.
> >>
> >> As this series touches critical data-path area, and you had no real
> >> option of testing it, we are taking it through a regression cycle, in
> >> parallel to the code review.
> >>
> >> We should have results early next week. We'll update.
> >
> > Sounds good, could you repost once ready?
> > I'll mark it as awaiting upstream in patchwork for now.
> > And feel free to drop the line pointed out by Ido, no real
> > preference either way there.
>
> Hi,
>
> Patches passed functional tests.
>
> Overall, the patches look good.
Thanks!
> Only a few comments:
> 1. Nit by Ido.
> 2. pool size.
> 3. xdp xmit support description.
>
> How do you want to proceed?
> Do you want to fix and re-spin?
Sure thing, will do.
prev parent reply other threads:[~2025-02-11 18:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 3:12 [PATCH net-next 0/4] eth: mlx4: use the page pool for Rx buffers Jakub Kicinski
2025-02-05 3:12 ` [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx Jakub Kicinski
2025-02-06 19:44 ` Tariq Toukan
2025-02-06 23:04 ` Jakub Kicinski
2025-02-11 18:01 ` Tariq Toukan
2025-02-11 19:06 ` Jakub Kicinski
2025-02-11 19:11 ` Tariq Toukan
2025-02-11 19:21 ` Tariq Toukan
2025-02-11 19:23 ` Jakub Kicinski
2025-02-11 19:38 ` Tariq Toukan
2025-02-11 19:18 ` Tariq Toukan
2025-02-11 19:44 ` Jakub Kicinski
2025-02-05 3:12 ` [PATCH net-next 2/4] eth: mlx4: don't try to complete XDP frames in netpoll Jakub Kicinski
2025-02-06 19:50 ` Tariq Toukan
2025-02-06 23:05 ` Jakub Kicinski
2025-02-05 3:12 ` [PATCH net-next 3/4] eth: mlx4: remove the local XDP fast-recycling ring Jakub Kicinski
2025-02-05 3:12 ` [PATCH net-next 4/4] eth: mlx4: use the page pool for Rx buffers Jakub Kicinski
2025-02-05 18:05 ` Ido Schimmel
2025-02-05 19:11 ` Jakub Kicinski
2025-02-06 12:57 ` [PATCH net-next 0/4] " Tariq Toukan
2025-02-06 15:58 ` Jakub Kicinski
2025-02-11 18:05 ` Tariq Toukan
2025-02-11 18:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211105001.73b220fb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.