Re: [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 11 Feb 2025 21:18:46 +0200 Tariq Toukan wrote:
> > -	if (xdp_rxq_info_reg(&ring->xdp_rxq, priv->dev, queue_index, 0) < 0)
> > +	pp.flags = PP_FLAG_DMA_MAP;
> > +	pp.pool_size = MLX4_EN_MAX_RX_SIZE;
> > +	pp.nid = node;
> > +	pp.napi = &priv->rx_cq[queue_index]->napi;
> > +	pp.netdev = priv->dev;
> > +	pp.dev = &mdev->dev->persist->pdev->dev;
> > +	pp.dma_dir = DMA_BIDIRECTIONAL;  
> 
> I just noticed one more thing, here we better take the value from 
> priv->dma_dir, as it could be DMA_FROM_DEVICE or DMA_BIDIRECTIONAL 
> depending on XDP program presence.

ack!