From: SeongJae Park <sj@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: SeongJae Park <sj@kernel.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Linux PM" <linux-pm@vger.kernel.org>, rcu <rcu@vger.kernel.org>,
"LTP List" <ltp@lists.linux.it>,
"Linux Regressions" <regressions@lists.linux.dev>,
lkft-triage@lists.linaro.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Anders Roxell" <anders.roxell@linaro.org>
Subject: Re: next-20250210: WARNING: at include/linux/rwsem.h:85 madvise_unlock
Date: Tue, 11 Feb 2025 10:35:31 -0800 [thread overview]
Message-ID: <20250211183531.4359-1-sj@kernel.org> (raw)
In-Reply-To: <fa1a7a10-f892-4e7e-acb4-0b058aa53d88@app.fastmail.com>
On Tue, 11 Feb 2025 10:32:55 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:
> On Tue, Feb 11, 2025, at 10:23, Naresh Kamboju wrote:
> > Regressions on arm64 Juno-r2 device while running LTP syscalls tests
> > madvise01 warnings on the Linux next-20250210 tag.
> >
> > First seen on next-20250210
> > Good: next-20250207
> > Bad: next-20250210
>
> Cc SeongJae Park <sj@kernel.org>
[...]
> This is mmap_write_unlock() triggering
> rwsem_assert_held_write(&mm->mmap_lock);
>
> That code was changed in these commits:
>
> 415553982a1e mm-madvise-remove-redundant-mmap_lock-operations-from-process_madvise-fix
> ec68fbd9e99f mm/madvise: remove redundant mmap_lock operations from process_madvise()
> f19c9d7b57cf mm/madvise: split out madvise() behavior execution
> a4d5a73cdc14 mm/madvise: split out madvise input validity check
> 948a0a9ea070 mm/madvise: split out mmap locking operations for madvise()
>
> You could try reverting them to see if that fixes it again.
Thank you for kindly Cc-ing me and further providing this nice information,
Arnd! I posted a fix and continuing discussion there:
https://lore.kernel.org/20250211063201.5106-1-sj@kernel.org
Thanks,
SJ
[...]
WARNING: multiple messages have this Message-ID (diff)
From: SeongJae Park via ltp <ltp@lists.linux.it>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: SeongJae Park <sj@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Linux Regressions <regressions@lists.linux.dev>,
"Paul E. McKenney" <paulmck@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
lkft-triage@lists.linaro.org, rcu <rcu@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] next-20250210: WARNING: at include/linux/rwsem.h:85 madvise_unlock
Date: Tue, 11 Feb 2025 10:35:31 -0800 [thread overview]
Message-ID: <20250211183531.4359-1-sj@kernel.org> (raw)
In-Reply-To: <fa1a7a10-f892-4e7e-acb4-0b058aa53d88@app.fastmail.com>
On Tue, 11 Feb 2025 10:32:55 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:
> On Tue, Feb 11, 2025, at 10:23, Naresh Kamboju wrote:
> > Regressions on arm64 Juno-r2 device while running LTP syscalls tests
> > madvise01 warnings on the Linux next-20250210 tag.
> >
> > First seen on next-20250210
> > Good: next-20250207
> > Bad: next-20250210
>
> Cc SeongJae Park <sj@kernel.org>
[...]
> This is mmap_write_unlock() triggering
> rwsem_assert_held_write(&mm->mmap_lock);
>
> That code was changed in these commits:
>
> 415553982a1e mm-madvise-remove-redundant-mmap_lock-operations-from-process_madvise-fix
> ec68fbd9e99f mm/madvise: remove redundant mmap_lock operations from process_madvise()
> f19c9d7b57cf mm/madvise: split out madvise() behavior execution
> a4d5a73cdc14 mm/madvise: split out madvise input validity check
> 948a0a9ea070 mm/madvise: split out mmap locking operations for madvise()
>
> You could try reverting them to see if that fixes it again.
Thank you for kindly Cc-ing me and further providing this nice information,
Arnd! I posted a fix and continuing discussion there:
https://lore.kernel.org/20250211063201.5106-1-sj@kernel.org
Thanks,
SJ
[...]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-02-11 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 9:23 next-20250210: WARNING: at include/linux/rwsem.h:85 madvise_unlock Naresh Kamboju
2025-02-11 9:23 ` [LTP] " Naresh Kamboju
2025-02-11 9:32 ` Arnd Bergmann
2025-02-11 9:32 ` [LTP] " Arnd Bergmann
2025-02-11 18:35 ` SeongJae Park [this message]
2025-02-11 18:35 ` SeongJae Park via ltp
2025-02-11 10:08 ` Naresh Kamboju
2025-02-11 10:08 ` [LTP] " Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211183531.4359-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=ltp@lists.linux.it \
--cc=naresh.kamboju@linaro.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.