All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-arm@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v6 10/11] tests/functional: Remove sleep() kludges from microblaze tests
Date: Wed, 12 Feb 2025 12:24:12 +0100	[thread overview]
Message-ID: <20250212112413.37553-11-philmd@linaro.org> (raw)
In-Reply-To: <20250212112413.37553-1-philmd@linaro.org>

Commit f0ec14c78c4 ("tests/avocado: Fix console data loss") fixed
QEMUMachine's problem with console, we don't need to use the sleep()
kludges.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250206131052.30207-15-philmd@linaro.org>
---
 tests/functional/test_microblazeel_s3adsp1800.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/functional/test_microblazeel_s3adsp1800.py b/tests/functional/test_microblazeel_s3adsp1800.py
index 1f0812eec63..d50b98342d7 100755
--- a/tests/functional/test_microblazeel_s3adsp1800.py
+++ b/tests/functional/test_microblazeel_s3adsp1800.py
@@ -7,8 +7,7 @@
 # This work is licensed under the terms of the GNU GPL, version 2 or
 # later. See the COPYING file in the top-level directory.
 
-import time
-from qemu_test import exec_command, exec_command_and_wait_for_pattern
+from qemu_test import exec_command_and_wait_for_pattern
 from qemu_test import QemuSystemTest, Asset
 from qemu_test import wait_for_console_pattern
 
@@ -32,9 +31,8 @@ def do_xmaton_le_test(self, machine):
         self.vm.add_args('-nic', f'user,tftp={tftproot}')
         self.vm.launch()
         wait_for_console_pattern(self, 'QEMU Advent Calendar 2023')
-        time.sleep(0.1)
-        exec_command(self, 'root')
-        time.sleep(0.1)
+        wait_for_console_pattern(self, 'buildroot login:')
+        exec_command_and_wait_for_pattern(self, 'root', '#')
         exec_command_and_wait_for_pattern(self,
                 'tftp -g -r xmaton.png 10.0.2.2 ; md5sum xmaton.png',
                 '821cd3cab8efd16ad6ee5acc3642a8ea')
-- 
2.47.1



  parent reply	other threads:[~2025-02-12 11:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 11:24 [PATCH v6 00/11] hw/microblaze: Allow running cross-endian vCPUs Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 01/11] hw/qdev-properties-system: Introduce EndianMode QAPI enum Philippe Mathieu-Daudé
2025-02-12 11:37   ` Thomas Huth
2025-02-12 11:43     ` Philippe Mathieu-Daudé
2025-02-12 12:02       ` Philippe Mathieu-Daudé
2025-02-12 12:11         ` Daniel P. Berrangé
2025-02-12 12:56       ` BALATON Zoltan
2025-02-12 13:53         ` Philippe Mathieu-Daudé
2025-02-12 14:03           ` Philippe Mathieu-Daudé
2025-02-12 16:23             ` BALATON Zoltan
2025-02-12 18:17               ` Philippe Mathieu-Daudé
2025-02-12 22:34                 ` BALATON Zoltan
2025-02-13  7:07                   ` Thomas Huth
2025-02-13 13:59                     ` BALATON Zoltan
2025-02-13 14:24                       ` Philippe Mathieu-Daudé
2025-02-13 14:33                       ` Thomas Huth
2025-02-13 14:56                         ` BALATON Zoltan
2025-02-12 11:24 ` [PATCH v6 02/11] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-12 11:42   ` Thomas Huth
2025-02-12 11:44     ` Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 03/11] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 04/11] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 05/11] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 06/11] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 07/11] tests/functional: Avoid using www.qemu-advent-calendar.org URL Philippe Mathieu-Daudé
2025-02-12 11:49   ` Thomas Huth
2025-02-12 11:53     ` Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 08/11] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-12 11:24 ` [PATCH v6 09/11] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-12 11:24 ` Philippe Mathieu-Daudé [this message]
2025-02-12 11:24 ` [PATCH v6 11/11] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
2025-02-12 11:46   ` Thomas Huth
2025-02-12 11:55     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212112413.37553-11-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.