[melver:cap-analysis 29/29] include/linux/irq.h:1226:1: warning: raw_spinlock 'gc->lock' is still held at the end of function

[melver:cap-analysis 29/29] include/linux/irq.h:1226:1: warning: raw_spinlock 'gc->lock' is still held at the end of function

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/melver/linux.git cap-analysis
head:   62e4de14389b44299be85eea5a580e6b497fdf43
commit: 62e4de14389b44299be85eea5a580e6b497fdf43 [29/29] DO-NOT-SEND: drivers: Assorted enablement and annotations
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250212/202502121639.Ib6bcPCB-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502121639.Ib6bcPCB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502121639.Ib6bcPCB-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/xlnx/zynqmp_dpsub.c:13:
   In file included from include/linux/dma-mapping.h:5:
   In file included from include/linux/device.h:32:
   In file included from include/linux/device/driver.h:21:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/s390/include/asm/elf.h:181:
   In file included from arch/s390/include/asm/mmu_context.h:11:
   In file included from arch/s390/include/asm/pgalloc.h:18:
   In file included from include/linux/mm.h:2227:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/xlnx/zynqmp_dpsub.c:24:
   In file included from include/drm/drm_module.h:6:
   In file included from include/linux/pci.h:2099:
   In file included from arch/s390/include/asm/pci.h:7:
   In file included from include/linux/iommu.h:1506:
   In file included from include/linux/msi.h:24:
>> include/linux/irq.h:1226:1: warning: raw_spinlock 'gc->lock' is still held at the end of function [-Wthread-safety-analysis]
    1226 | }
         | ^
   include/linux/irq.h:1225:2: note: raw_spinlock acquired here
    1225 |         raw_spin_lock(&gc->lock);
         |         ^
   include/linux/spinlock.h:218:29: note: expanded from macro 'raw_spin_lock'
     218 | #define raw_spin_lock(lock)     _raw_spin_lock(lock)
         |                                 ^
   In file included from drivers/gpu/drm/xlnx/zynqmp_dpsub.c:24:
   In file included from include/drm/drm_module.h:6:
   In file included from include/linux/pci.h:2099:
   In file included from arch/s390/include/asm/pci.h:7:
   In file included from include/linux/iommu.h:1506:
   In file included from include/linux/msi.h:24:
>> include/linux/irq.h:1230:2: warning: releasing raw_spinlock 'gc->lock' that was not held [-Wthread-safety-analysis]
    1230 |         raw_spin_unlock(&gc->lock);
         |         ^
   include/linux/spinlock.h:277:32: note: expanded from macro 'raw_spin_unlock'
     277 | #define raw_spin_unlock(lock)           _raw_spin_unlock(lock)
         |                                         ^
   5 warnings generated.


vim +1226 include/linux/irq.h

7d8280624797bb Thomas Gleixner 2011-04-03  1221  
7d8280624797bb Thomas Gleixner 2011-04-03  1222  #ifdef CONFIG_SMP
7d8280624797bb Thomas Gleixner 2011-04-03  1223  static inline void irq_gc_lock(struct irq_chip_generic *gc)
7d8280624797bb Thomas Gleixner 2011-04-03  1224  {
7d8280624797bb Thomas Gleixner 2011-04-03  1225  	raw_spin_lock(&gc->lock);
7d8280624797bb Thomas Gleixner 2011-04-03 @1226  }
7d8280624797bb Thomas Gleixner 2011-04-03  1227  
7d8280624797bb Thomas Gleixner 2011-04-03  1228  static inline void irq_gc_unlock(struct irq_chip_generic *gc)
7d8280624797bb Thomas Gleixner 2011-04-03  1229  {
7d8280624797bb Thomas Gleixner 2011-04-03 @1230  	raw_spin_unlock(&gc->lock);
7d8280624797bb Thomas Gleixner 2011-04-03  1231  }
7d8280624797bb Thomas Gleixner 2011-04-03  1232  #else
7d8280624797bb Thomas Gleixner 2011-04-03  1233  static inline void irq_gc_lock(struct irq_chip_generic *gc) { }
7d8280624797bb Thomas Gleixner 2011-04-03  1234  static inline void irq_gc_unlock(struct irq_chip_generic *gc) { }
7d8280624797bb Thomas Gleixner 2011-04-03  1235  #endif
7d8280624797bb Thomas Gleixner 2011-04-03  1236  

:::::: The code at line 1226 was first introduced by commit
:::::: 7d8280624797bbe2f5170bd3c85c75a8c9c74242 genirq: Implement a generic interrupt chip

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@linutronix.de>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki