All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, ardb@kernel.org
Subject: Re: [PATCH v3] riscv: Optimize crct10dif with zbc extension
Date: Wed, 12 Feb 2025 11:52:08 -0800	[thread overview]
Message-ID: <20250212195208.GA128826@sol.localdomain> (raw)
In-Reply-To: <f827cbb0-f6ad-4397-9f30-ca43223c4853@gmail.com>

On Wed, Feb 12, 2025 at 04:08:51PM +0800, Zhihang Shao wrote:
> On 2025/2/6 0:30, Eric Biggers wrote:
> 
> > Maybe use 'const __be64 *' and 'const __be32 *' for the pointer, and use
> > be64_to_cpu() and be32_to_cpu().  Then the __force cast won't be needed.
> Maybe this problem seems dumb, but I have no idea to adapt both riscv32 and
> riscv64. I have tried to use 'const __be64 *' and 'const __be32 *' pointer
> in patch v4, but I forgot to test them in riscv32, and it turns out the code
> failed to compile due to my mistake of defining 'const __be64 * p_ul' and of
> course it wouldn't be work for riscv32. Maybe I need some inspiration for
> this problem, or I still think it better to use 'unsigned long const *'
> since it works fine in both riscv64 and riscv32.
> 
> Looking forward to your reply and guidance.
> 
> Yours,
> 
> Zhihang
> 

I'm working on this patch and am going to send out a cleaned-up version.

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, ardb@kernel.org
Subject: Re: [PATCH v3] riscv: Optimize crct10dif with zbc extension
Date: Wed, 12 Feb 2025 11:52:08 -0800	[thread overview]
Message-ID: <20250212195208.GA128826@sol.localdomain> (raw)
In-Reply-To: <f827cbb0-f6ad-4397-9f30-ca43223c4853@gmail.com>

On Wed, Feb 12, 2025 at 04:08:51PM +0800, Zhihang Shao wrote:
> On 2025/2/6 0:30, Eric Biggers wrote:
> 
> > Maybe use 'const __be64 *' and 'const __be32 *' for the pointer, and use
> > be64_to_cpu() and be32_to_cpu().  Then the __force cast won't be needed.
> Maybe this problem seems dumb, but I have no idea to adapt both riscv32 and
> riscv64. I have tried to use 'const __be64 *' and 'const __be32 *' pointer
> in patch v4, but I forgot to test them in riscv32, and it turns out the code
> failed to compile due to my mistake of defining 'const __be64 * p_ul' and of
> course it wouldn't be work for riscv32. Maybe I need some inspiration for
> this problem, or I still think it better to use 'unsigned long const *'
> since it works fine in both riscv64 and riscv32.
> 
> Looking forward to your reply and guidance.
> 
> Yours,
> 
> Zhihang
> 

I'm working on this patch and am going to send out a cleaned-up version.

- Eric

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-02-12 19:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05  6:58 [PATCH v3] riscv: Optimize crct10dif with zbc extension Zhihang Shao
2025-02-05  6:58 ` Zhihang Shao
2025-02-05 16:30 ` Eric Biggers
2025-02-05 16:30   ` Eric Biggers
2025-02-06 20:19   ` Eric Biggers
2025-02-06 20:19     ` Eric Biggers
2025-02-10 20:35     ` Eric Biggers
2025-02-10 20:35       ` Eric Biggers
2025-02-12  8:08   ` Zhihang Shao
2025-02-12  8:08     ` Zhihang Shao
2025-02-12 19:52     ` Eric Biggers [this message]
2025-02-12 19:52       ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212195208.GA128826@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ardb@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=zhihang.shao.iscas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.