+ filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch added to mm-unstable branch

+ filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch added to mm-unstable branch

[Andrew Morton]

The patch titled
     Subject: filemap: remove redundant folio_test_large check in filemap_free_folio
has been added to the -mm mm-unstable branch.  Its filename is
     filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Guanjun <guanjun@linux.alibaba.com>
Subject: filemap: remove redundant folio_test_large check in filemap_free_folio
Date: Thu, 13 Feb 2025 13:56:12 +0800

The folio_test_large() check in filemap_free_folio() is unnecessary
because folio_nr_pages(), which is called internally already performs this
check.  Removing the redundant condition simplifies the code and avoids
double validation.

This change improves code readability and reduces unnecessary operations
in the folio freeing path.

Link: https://lkml.kernel.org/r/20250213055612.490993-1-guanjun@linux.alibaba.com
Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/filemap.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/mm/filemap.c~filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio
+++ a/mm/filemap.c
@@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio
 void filemap_free_folio(struct address_space *mapping, struct folio *folio)
 {
 	void (*free_folio)(struct folio *);
-	int refs = 1;
 
 	free_folio = mapping->a_ops->free_folio;
 	if (free_folio)
 		free_folio(folio);
 
-	if (folio_test_large(folio))
-		refs = folio_nr_pages(folio);
-	folio_put_refs(folio, refs);
+	folio_put_refs(folio, folio_nr_pages(folio));
 }
 
 /**
_

Patches currently in -mm which might be from guanjun@linux.alibaba.com are

filemap-remove-redundant-folio_test_large-check-in-filemap_free_folio.patch