[paulmckrcu:dev.2025.02.12a 73/77] kernel/rcu/rcutorture.c:2440:42: sparse: sparse: symbol 'updownreaders' was not declared. Should it be static?

[paulmckrcu:dev.2025.02.12a 73/77] kernel/rcu/rcutorture.c:2440:42: sparse: sparse: symbol 'updownreaders' was not declared. Should it be static?

[kernel test robot]

tree:   https://github.com/paulmckrcu/linux dev.2025.02.12a
head:   9909b31f911e4cb67bb84cd07c5172c0823ac549
commit: bc33cbe9ab89abc9ae3d33843c3d84e383ac8677 [73/77] rcutorture: Add tests for SRCU up/down reader primitives
config: nios2-randconfig-r112-20250213 (https://download.01.org/0day-ci/archive/20250214/202502140113.iZOFajfB-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20250214/202502140113.iZOFajfB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502140113.iZOFajfB-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/rcu/rcutorture.c:2440:42: sparse: sparse: symbol 'updownreaders' was not declared. Should it be static?
   kernel/rcu/rcutorture.c:444:12: sparse: sparse: context imbalance in 'rcu_torture_read_lock' - wrong count at exit
   kernel/rcu/rcutorture.c:484:13: sparse: sparse: context imbalance in 'rcu_torture_read_unlock' - unexpected unlock
   kernel/rcu/rcutorture.c:763:38: sparse: sparse: context imbalance in 'srcu_torture_read_unlock' - unexpected unlock
   kernel/rcu/rcutorture.c:813:34: sparse: sparse: context imbalance in 'srcu_torture_up_read' - unexpected unlock
   kernel/rcu/rcutorture.c:2118:9: sparse: sparse: context imbalance in 'rcutorture_one_extend' - different lock contexts for basic block
   kernel/rcu/rcutorture.c:4165:41: sparse: sparse: context imbalance in 'rcu_torture_init_srcu_lockdep' - unexpected unlock

vim +/updownreaders +2440 kernel/rcu/rcutorture.c

  2439	
> 2440	struct rcu_torture_one_read_state_updown *updownreaders;
  2441	static DEFINE_TORTURE_RANDOM(rcu_torture_updown_rand);
  2442	static int rcu_torture_updown(void *arg);
  2443	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [paulmckrcu:dev.2025.02.12a 73/77] kernel/rcu/rcutorture.c:2440:42: sparse: sparse: symbol 'updownreaders' was not declared. Should it be static?

[Paul E. McKenney]

On Fri, Feb 14, 2025 at 01:45:58AM +0800, kernel test robot wrote:
> tree:   https://github.com/paulmckrcu/linux dev.2025.02.12a
> head:   9909b31f911e4cb67bb84cd07c5172c0823ac549
> commit: bc33cbe9ab89abc9ae3d33843c3d84e383ac8677 [73/77] rcutorture: Add tests for SRCU up/down reader primitives
> config: nios2-randconfig-r112-20250213 (https://download.01.org/0day-ci/archive/20250214/202502140113.iZOFajfB-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 14.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20250214/202502140113.iZOFajfB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502140113.iZOFajfB-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> kernel/rcu/rcutorture.c:2440:42: sparse: sparse: symbol 'updownreaders' was not declared. Should it be static?
>    kernel/rcu/rcutorture.c:444:12: sparse: sparse: context imbalance in 'rcu_torture_read_lock' - wrong count at exit
>    kernel/rcu/rcutorture.c:484:13: sparse: sparse: context imbalance in 'rcu_torture_read_unlock' - unexpected unlock
>    kernel/rcu/rcutorture.c:763:38: sparse: sparse: context imbalance in 'srcu_torture_read_unlock' - unexpected unlock
>    kernel/rcu/rcutorture.c:813:34: sparse: sparse: context imbalance in 'srcu_torture_up_read' - unexpected unlock
>    kernel/rcu/rcutorture.c:2118:9: sparse: sparse: context imbalance in 'rcutorture_one_extend' - different lock contexts for basic block
>    kernel/rcu/rcutorture.c:4165:41: sparse: sparse: context imbalance in 'rcu_torture_init_srcu_lockdep' - unexpected unlock
> 
> vim +/updownreaders +2440 kernel/rcu/rcutorture.c
> 
>   2439	
> > 2440	struct rcu_torture_one_read_state_updown *updownreaders;
>   2441	static DEFINE_TORTURE_RANDOM(rcu_torture_updown_rand);
>   2442	static int rcu_torture_updown(void *arg);
>   2443	

Good catch, and yes it should be static.  Will fix with attribution,
thank you!

							Thanx, Paul