From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, horms@kernel.org,
pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org,
shayagr@amazon.com, kalesh-anakkur.purayil@broadcom.com,
pavan.chebbi@broadcom.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v8 0/6] net: napi: add CPU affinity to napi->config
Date: Sat, 15 Feb 2025 09:43:38 -0800 [thread overview]
Message-ID: <20250215094338.7863bcef@kernel.org> (raw)
In-Reply-To: <20250215094154.1c83b224@kernel.org>
On Sat, 15 Feb 2025 09:41:54 -0800 Jakub Kicinski wrote:
> On Tue, 11 Feb 2025 14:06:51 -0700 Ahmed Zaki wrote:
> > Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
> > after reset. However, since there can be only one IRQ affinity notifier
> > for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
> > management in the core (which also registers separate IRQ affinity
> > notifiers).
>
> Could you extract all the core changes as a first patch of the series
> (rmap and affinity together). And then have the driver conversion
> patches follow? Obviously don't do it if it'd introduce transient
> breakage. But I don't think it should, since core changes should
> be a noop before any driver opts in.
>
> The way it's split now makes the logic quite hard to review.
Ah, and please add the patch with the ksft test I shared earlier to
your series:
https://github.com/kuba-moo/linux/commit/de7d2475750ac05b6e414d7e5201e354b05cf146
it just needs a commit message, I think. The prereq patches are
in the tree now.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, horms@kernel.org,
pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org,
shayagr@amazon.com, kalesh-anakkur.purayil@broadcom.com,
pavan.chebbi@broadcom.com
Subject: Re: [PATCH net-next v8 0/6] net: napi: add CPU affinity to napi->config
Date: Sat, 15 Feb 2025 09:43:38 -0800 [thread overview]
Message-ID: <20250215094338.7863bcef@kernel.org> (raw)
In-Reply-To: <20250215094154.1c83b224@kernel.org>
On Sat, 15 Feb 2025 09:41:54 -0800 Jakub Kicinski wrote:
> On Tue, 11 Feb 2025 14:06:51 -0700 Ahmed Zaki wrote:
> > Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
> > after reset. However, since there can be only one IRQ affinity notifier
> > for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
> > management in the core (which also registers separate IRQ affinity
> > notifiers).
>
> Could you extract all the core changes as a first patch of the series
> (rmap and affinity together). And then have the driver conversion
> patches follow? Obviously don't do it if it'd introduce transient
> breakage. But I don't think it should, since core changes should
> be a noop before any driver opts in.
>
> The way it's split now makes the logic quite hard to review.
Ah, and please add the patch with the ksft test I shared earlier to
your series:
https://github.com/kuba-moo/linux/commit/de7d2475750ac05b6e414d7e5201e354b05cf146
it just needs a commit message, I think. The prereq patches are
in the tree now.
next prev parent reply other threads:[~2025-02-15 17:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:06 [Intel-wired-lan] [PATCH net-next v8 0/6] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 1/6] ice: clear NAPI's IRQ numbers in ice_vsi_clear_napi_queues() Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 2/6] net: move ARFS rmap management to core Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-15 17:53 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-15 17:53 ` Jakub Kicinski
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 3/6] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-13 12:26 ` [Intel-wired-lan] " Paolo Abeni
2025-02-13 12:26 ` Paolo Abeni
2025-02-13 15:45 ` [Intel-wired-lan] " Ahmed Zaki
2025-02-13 15:45 ` Ahmed Zaki
2025-02-15 17:58 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-15 17:58 ` Jakub Kicinski
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 4/6] bnxt: use napi's irq affinity Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 5/6] ice: " Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-11 21:06 ` [Intel-wired-lan] [PATCH net-next v8 6/6] idpf: " Ahmed Zaki
2025-02-11 21:06 ` Ahmed Zaki
2025-02-15 17:41 ` [Intel-wired-lan] [PATCH net-next v8 0/6] net: napi: add CPU affinity to napi->config Jakub Kicinski
2025-02-15 17:41 ` Jakub Kicinski
2025-02-15 17:43 ` Jakub Kicinski [this message]
2025-02-15 17:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215094338.7863bcef@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayagr@amazon.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.